Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-07-11 Thread Ingo Molnar
* Wanpeng Li wrote: > Hi Ingo, Thomas, > 2016-06-22 9:28 GMT+08:00 Wanpeng Li : > > From: Wanpeng Li > > > > [ cut here ] > > WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 > > ex_handler_rdmsr_unsafe+0x6a/0x70 > > unchecked MSR access error: RDMSR from 0xce > > Mod

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-07-10 Thread Wanpeng Li
Hi Ingo, Thomas, 2016-06-22 9:28 GMT+08:00 Wanpeng Li : > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 > ex_handler_rdmsr_unsafe+0x6a/0x70 > unchecked MSR access error: RDMSR from 0xce > Modules linked in: > CPU: 0 PID: 0 Comm: swa

Re: [LKP] [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 Thread Wanpeng Li
2016-06-23 15:41 GMT+08:00 Wanpeng Li : > Hi Yu， > 2016-06-23 15:37 GMT+08:00 Yu Chen : >> On Thu, Jun 23, 2016 at 3:09 PM, Thomas Gleixner wrote: >>> On Wed, 22 Jun 2016, Wanpeng Li wrote: After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core >>> >>> Where did you find that

Re: [LKP] [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 Thread Wanpeng Li
Hi Yu， 2016-06-23 15:37 GMT+08:00 Yu Chen : > On Thu, Jun 23, 2016 at 3:09 PM, Thomas Gleixner wrote: >> On Wed, 22 Jun 2016, Wanpeng Li wrote: >>> After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core >> >> Where did you find that commit? It's neither in Linus tree nor in tip. >>

Re: [LKP] [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 Thread Yu Chen
On Thu, Jun 23, 2016 at 3:09 PM, Thomas Gleixner wrote: > On Wed, 22 Jun 2016, Wanpeng Li wrote: >> After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core > > Where did you find that commit? It's neither in Linus tree nor in tip. > It is in Len's tree, we are planing to resend the

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 Thread Wanpeng Li
Hi Jacob, 2016-06-23 15:28 GMT+08:00 Wanpeng Li : > 2016-06-23 15:09 GMT+08:00 Thomas Gleixner : >> On Wed, 22 Jun 2016, Wanpeng Li wrote: >>> After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core >> >> Where did you find that commit? It's neither in Linus tree nor in tip. > > It i

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 Thread Wanpeng Li
2016-06-23 15:09 GMT+08:00 Thomas Gleixner : > On Wed, 22 Jun 2016, Wanpeng Li wrote: >> After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core > > Where did you find that commit? It's neither in Linus tree nor in tip. It is reported by lkp. https://lkml.org/lkml/2016/6/20/110 The

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 Thread Thomas Gleixner
On Wed, 22 Jun 2016, Wanpeng Li wrote: > After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core Where did you find that commit? It's neither in Linus tree nor in tip. Thanks, tglx

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-22 Thread Paolo Bonzini
On 22/06/2016 03:28, Wanpeng Li wrote: > > get_ratio: > - rdmsr(MSR_PLATFORM_INFO, lo, hi); > - ratio = (lo >> 8) & 0xff; > + if (!rdmsr_safe(MSR_PLATFORM_INFO, &lo, &hi)) > + ratio = (lo >> 8) & 0xff; This looks good, thanks. Paolo

[PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-21 Thread Wanpeng Li
From: Wanpeng Li [ cut here ] WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe+0x6a/0x70 unchecked MSR access error: RDMSR from 0xce Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.7.0-rc3+ #1 Hardware name: QEMU Standard PC (i440F