Re: [PATCH] x86-64 kprobes: handle %RIP-relative addressing mode

2005-03-15 Thread Roland McGrath
> Can you turn these two arrays into a bitmap please? Ok. > This shouldn't be opencoded here. Instead make a utility function > like vmalloc_range() that takes a start and end address and > make the module allocation use it too. > > Also you should fix up asm-x86_64/page.h and Documentation/x86

Re: [PATCH] x86-64 kprobes: handle %RIP-relative addressing mode

2005-03-13 Thread Andrew Morton
Roland McGrath <[EMAIL PROTECTED]> wrote: > > + area = __get_vm_area(0, VM_ALLOC, MODULES_END, 0ULL - PAGE_SIZE); The longlong here seems wrong? If this is to mean "the top of the address space minus a page" then unsigned long is the appropriate type. - To unsubscribe from this list: send th

Re: [PATCH] x86-64 kprobes: handle %RIP-relative addressing mode

2005-03-13 Thread Oleg Nesterov
Roland McGrath wrote: > > + * This basically replicates __vmalloc, except that it uses a > + * range of addresses starting at MODULE_END. This also Could you look at these patches: [PATCH 1/5] vmalloc: introduce __vmalloc_area() function http://marc.theaimsgroup.com/?l=linux-kernel&m=111

Re: [PATCH] x86-64 kprobes: handle %RIP-relative addressing mode

2005-03-13 Thread Andi Kleen
Roland McGrath <[EMAIL PROTECTED]> writes: > The existing x86-64 kprobes implementation doesn't cope with the > %RIP-relative addressing mode. Kprobes work by single-stepping a copy of Thanks for fixing that long standing bug. > + static const unsigned char onebyte_has_modrm[256] = { Can

[PATCH] x86-64 kprobes: handle %RIP-relative addressing mode

2005-03-13 Thread Roland McGrath
The existing x86-64 kprobes implementation doesn't cope with the %RIP-relative addressing mode. Kprobes work by single-stepping a copy of an instruction overwritten by a breakpoint. When a probe is inserted on an instruction that uses the %RIP-relative data addressing mode, the copy run in a diff