Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Dave Jones
On Tue, Mar 13, 2007 at 12:12:20AM +0100, Pavel Machek wrote: > > 65535 characters? Are you for real? > > Stop and think about just how big that is. If you have to create > > a boot command line that long, you have serious, serious issues. > > Well, it is about the same size as my

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Pavel Machek
Hi! > > > > +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the > command line, > > > > > > Why a long? It's unlikely that someone is going to have a command line > > > bigger than 0x. > > > > Well, I could imagine overflowing that. Describing your numa setup, > >

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Dave Jones
On Mon, Mar 12, 2007 at 10:43:52AM +, Pavel Machek wrote: > On Tue 2007-03-06 13:21:34, Dave Jones wrote: > > On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: > > > > > +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command > > line, > > > > Why a

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Pavel Machek
On Tue 2007-03-06 13:21:34, Dave Jones wrote: > On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: > > > +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command > line, > > Why a long? It's unlikely that someone is going to have a command line > bigger than 0x.

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Pavel Machek
On Tue 2007-03-06 13:21:34, Dave Jones wrote: On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, Why a long? It's unlikely that someone is going to have a command line bigger than 0x. Well,

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Dave Jones
On Mon, Mar 12, 2007 at 10:43:52AM +, Pavel Machek wrote: On Tue 2007-03-06 13:21:34, Dave Jones wrote: On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, Why a long? It's

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Pavel Machek
Hi! +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, Why a long? It's unlikely that someone is going to have a command line bigger than 0x. Well, I could imagine overflowing that. Describing your numa setup, excluding few bad bits of

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-12 Thread Dave Jones
On Tue, Mar 13, 2007 at 12:12:20AM +0100, Pavel Machek wrote: 65535 characters? Are you for real? Stop and think about just how big that is. If you have to create a boot command line that long, you have serious, serious issues. Well, it is about the same size as my .config... So?

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-07 Thread Vivek Goyal
On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: > Because the command line is increased to 2048 characters after 2.6.21, > it's not possible for boot loaders and userspace tools to determine the length > of the command line the kernel can understand. The benefit of knowing the >

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-07 Thread Vivek Goyal
On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: Because the command line is increased to 2048 characters after 2.6.21, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing the length

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Alon Bar-Lev
On 3/6/07, Bernhard Walle <[EMAIL PROTECTED]> wrote: +The kernel command line is a null-terminated string. The maximum +length can be retrieved from the field cmdline_size. Before protocol +version 2.06, the maximum was 255 characters. A string that is too +long will be automatically truncated

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Dave Jones
On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: > +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, Why a long? It's unlikely that someone is going to have a command line bigger than 0x. Dave -- http://www.codemonkey.org.uk - To

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Bernhard Walle
Because the command line is increased to 2048 characters after 2.6.21, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing the length is that users can be warned if the command line size is too long

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Bernhard Walle
Because the command line is increased to 2048 characters after 2.6.21, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing the length is that users can be warned if the command line size is too long

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Dave Jones
On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote: +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, Why a long? It's unlikely that someone is going to have a command line bigger than 0x. Dave -- http://www.codemonkey.org.uk - To

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Alon Bar-Lev
On 3/6/07, Bernhard Walle [EMAIL PROTECTED] wrote: +The kernel command line is a null-terminated string. The maximum +length can be retrieved from the field cmdline_size. Before protocol +version 2.06, the maximum was 255 characters. A string that is too +long will be automatically truncated

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-02-13 Thread Bernhard Walle
[Difference to previous attempt: cmdline_size is now without terminating zero, requested by H. Peter Anvin.] Because the command line is increased to 2048 characters after 2.6.20-rc6-mm1, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-02-13 Thread Bernhard Walle
[Difference to previous attempt: cmdline_size is now without terminating zero, requested by H. Peter Anvin.] Because the command line is increased to 2048 characters after 2.6.20-rc6-mm1, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-02-04 Thread Bernhard Walle
Because the command line is increased to 2048 characters after 2.6.20-rc6-mm1, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing that length is that users can be warned if the command line size is

[PATCH] x86_64, i386: Add command line length to boot protocol

2007-02-04 Thread Bernhard Walle
Because the command line is increased to 2048 characters after 2.6.20-rc6-mm1, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing that length is that users can be warned if the command line size is