Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-09 Thread Andrew Morton
On Thu, 9 Aug 2007 14:16:16 -0700 "Aaron Durbin" <[EMAIL PROTECTED]> wrote: > > but, but. Didn't this get fixed by > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm1/broken-out/fix-hpet-init-race.patch > > ? > > > > That original patch looks good to me

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-09 Thread Aaron Durbin
On 8/9/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 8 Aug 2007 16:17:19 -0700 > Aaron Durbin <[EMAIL PROTECTED]> wrote: > > > In setup_APIC_timer with the HPET in use, a condition can arise while > > waiting for the next irq slice to expire on the HPET which will either > > cause an NMI

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-09 Thread Andrew Morton
On Wed, 8 Aug 2007 16:17:19 -0700 Aaron Durbin <[EMAIL PROTECTED]> wrote: > In setup_APIC_timer with the HPET in use, a condition can arise while > waiting for the next irq slice to expire on the HPET which will either > cause an NMI watchdog to fire or a 3 minute busy loop if the NMI > watchdog

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-09 Thread Andrew Morton
On Wed, 8 Aug 2007 16:17:19 -0700 Aaron Durbin [EMAIL PROTECTED] wrote: In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-09 Thread Aaron Durbin
On 8/9/07, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 8 Aug 2007 16:17:19 -0700 Aaron Durbin [EMAIL PROTECTED] wrote: In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-09 Thread Andrew Morton
On Thu, 9 Aug 2007 14:16:16 -0700 Aaron Durbin [EMAIL PROTECTED] wrote: but, but. Didn't this get fixed by ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm1/broken-out/fix-hpet-init-race.patch ? That original patch looks good to me as well. I just

[PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The HPET comparator and the counter keep incrementing during its

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Andi Kleen
> > I was thinking along the same lines as well, but I really didn't know how > important all that code was for waiting for the next irq slice. I'm not time > expert, but I would imagine we would resynchronize correctly in the future > after > this code path? The idea is to just have the apic

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
On 8/8/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > On Thursday 09 August 2007 01:17:19 Aaron Durbin wrote: > > In setup_APIC_timer with the HPET in use, a condition can arise while > > waiting for the next irq slice to expire on the HPET which will either > > cause an NMI watchdog to fire or a 3

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Andi Kleen
On Thursday 09 August 2007 01:17:19 Aaron Durbin wrote: > In setup_APIC_timer with the HPET in use, a condition can arise while > waiting for the next irq slice to expire on the HPET which will either > cause an NMI watchdog to fire or a 3 minute busy loop if the NMI > watchdog is disabled. > >

[PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The HPET comparator and the counter keep incrementing during its

[PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The HPET comparator and the counter keep incrementing during its

[PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The HPET comparator and the counter keep incrementing during its

[PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The HPET comparator and the counter keep incrementing during its

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Andi Kleen
On Thursday 09 August 2007 01:17:19 Aaron Durbin wrote: In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
On 8/8/07, Andi Kleen [EMAIL PROTECTED] wrote: On Thursday 09 August 2007 01:17:19 Aaron Durbin wrote: In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute

Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Andi Kleen
I was thinking along the same lines as well, but I really didn't know how important all that code was for waiting for the next irq slice. I'm not time expert, but I would imagine we would resynchronize correctly in the future after this code path? The idea is to just have the apic timers

[PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer

2007-08-08 Thread Aaron Durbin
In setup_APIC_timer with the HPET in use, a condition can arise while waiting for the next irq slice to expire on the HPET which will either cause an NMI watchdog to fire or a 3 minute busy loop if the NMI watchdog is disabled. The HPET comparator and the counter keep incrementing during its