Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 06:01 AM, Juergen Gross wrote: > On 03/11/17 10:20, Colin King wrote: >> From: Colin Ian King >> >> This is a moot point, but irq is always less than zero at the label >> out_error, so the check for irq >= 0 is redundant and can be removed. >> >> Detected

Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 06:01 AM, Juergen Gross wrote: > On 03/11/17 10:20, Colin King wrote: >> From: Colin Ian King >> >> This is a moot point, but irq is always less than zero at the label >> out_error, so the check for irq >= 0 is redundant and can be removed. >> >> Detected by CoverityScan,

Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-03 Thread Juergen Gross
On 03/11/17 10:20, Colin King wrote: > From: Colin Ian King > > This is a moot point, but irq is always less than zero at the label > out_error, so the check for irq >= 0 is redundant and can be removed. > > Detected by CoverityScan, CID#1460371 ("Logically dead code")

Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-03 Thread Juergen Gross
On 03/11/17 10:20, Colin King wrote: > From: Colin Ian King > > This is a moot point, but irq is always less than zero at the label > out_error, so the check for irq >= 0 is redundant and can be removed. > > Detected by CoverityScan, CID#1460371 ("Logically dead code") > > Fixes: cb1c7d9bbc87

[PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-03 Thread Colin King
From: Colin Ian King This is a moot point, but irq is always less than zero at the label out_error, so the check for irq >= 0 is redundant and can be removed. Detected by CoverityScan, CID#1460371 ("Logically dead code") Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement

[PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-03 Thread Colin King
From: Colin Ian King This is a moot point, but irq is always less than zero at the label out_error, so the check for irq >= 0 is redundant and can be removed. Detected by CoverityScan, CID#1460371 ("Logically dead code") Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")