Re: [PATCH] xen: avoid link error on ARM

2019-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2019 at 10:05 AM Juergen Gross wrote: > > On 05/03/2019 09:34, Arnd Bergmann wrote: > > On Tue, Mar 5, 2019 at 7:39 AM Juergen Gross wrote: > > > >> > >> Can we avoid that ifdef in the Makefile? > >> > >> I'd rather have an architecture independant builtin driver added which > >>

Re: [PATCH] xen: avoid link error on ARM

2019-03-05 Thread Juergen Gross
On 05/03/2019 09:34, Arnd Bergmann wrote: > On Tue, Mar 5, 2019 at 7:39 AM Juergen Gross wrote: > >> >> Can we avoid that ifdef in the Makefile? >> >> I'd rather have an architecture independant builtin driver added which >> is always included for CONFIG_XEN. This would allow to move redundant

Re: [PATCH] xen: avoid link error on ARM

2019-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2019 at 7:39 AM Juergen Gross wrote: > > Can we avoid that ifdef in the Makefile? > > I'd rather have an architecture independant builtin driver added which > is always included for CONFIG_XEN. This would allow to move redundant > stuff from arch/*/xen/ into it (e.g. xen_vcpu_id).

Re: [PATCH] xen: avoid link error on ARM

2019-03-04 Thread Juergen Gross
On 04/03/2019 21:47, Arnd Bergmann wrote: > Building the privcmd code as a loadable module on ARM, we get > a link error due to the private cache management functions: > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! > > Move the code into a new file that is built along

Re: [PATCH] xen: avoid link error on ARM

2019-03-04 Thread Arnd Bergmann
On Mon, Mar 4, 2019 at 10:19 PM Boris Ostrovsky wrote: > > On 3/4/19 3:47 PM, Arnd Bergmann wrote: > > Building the privcmd code as a loadable module on ARM, we get > > a link error due to the private cache management functions: > > > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko]

Re: [PATCH] xen: avoid link error on ARM

2019-03-04 Thread Boris Ostrovsky
On 3/4/19 3:47 PM, Arnd Bergmann wrote: > Building the privcmd code as a loadable module on ARM, we get > a link error due to the private cache management functions: > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! Can __sync_icache_dcache be exported in arm32, just like

[PATCH] xen: avoid link error on ARM

2019-03-04 Thread Arnd Bergmann
Building the privcmd code as a loadable module on ARM, we get a link error due to the private cache management functions: ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! Move the code into a new file that is built along with privcmd.o but is always built-in, even when the