Anthony Liguori wrote:
> If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible
> too? I think the point was that you should either be checking for
> 'xen-3.x' or something more general that would accept anything >=
> xen-3.0.
The signature is supposed to be an ABI signature, so
Jeremy Fitzhardinge wrote:
Bodo Eggert wrote:
Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ?
I don't thin Xen version 32 will be compatible ...
It had better be; if it loads the kernel, it should present a xen-3
compatible ABI.
If xen-32.0 should be compatible than
Jeremy Fitzhardinge wrote:
Bodo Eggert wrote:
Not BUG_ON(memcmp(xen_start_info-magic, xen-3., 6) != 0); ?
I don't thin Xen version 32 will be compatible ...
It had better be; if it loads the kernel, it should present a xen-3
compatible ABI.
If xen-32.0 should be compatible than wouldn't
Anthony Liguori wrote:
If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible
too? I think the point was that you should either be checking for
'xen-3.x' or something more general that would accept anything =
xen-3.0.
The signature is supposed to be an ABI signature, so
Bodo Eggert wrote:
> Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ?
> I don't thin Xen version 32 will be compatible ...
>
It had better be; if it loads the kernel, it should present a xen-3
compatible ABI.
But this is just a sanity check to make sure things are basically OK;
Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> Some versions of Xen 3.x set their magic number to "xen-3.[12]", so
> relax the test to match them.
> - BUG_ON(memcmp(xen_start_info->magic, "xen-3.0", 7) != 0);
> + BUG_ON(memcmp(xen_start_info->magic, "xen-3", 5) != 0);
Not
Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
Some versions of Xen 3.x set their magic number to xen-3.[12], so
relax the test to match them.
- BUG_ON(memcmp(xen_start_info-magic, xen-3.0, 7) != 0);
+ BUG_ON(memcmp(xen_start_info-magic, xen-3, 5) != 0);
Not
Bodo Eggert wrote:
Not BUG_ON(memcmp(xen_start_info-magic, xen-3., 6) != 0); ?
I don't thin Xen version 32 will be compatible ...
It had better be; if it loads the kernel, it should present a xen-3
compatible ABI.
But this is just a sanity check to make sure things are basically OK;
BUG_ON
Some versions of Xen 3.x set their magic number to "xen-3.[12]", so
relax the test to match them.
[ Linus: Please apply for 2.6.24. Thanks - J ]
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
---
arch/x86/xen/enlighten.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Some versions of Xen 3.x set their magic number to xen-3.[12], so
relax the test to match them.
[ Linus: Please apply for 2.6.24. Thanks - J ]
Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED]
---
arch/x86/xen/enlighten.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
10 matches
Mail list logo