Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Konrad Rzeszutek Wilk
On Thu, Feb 14, 2013 at 04:02:43PM +0100, Roger Pau Monné wrote: > On 14/02/13 14:23, Konrad Rzeszutek Wilk wrote: > > On Thu, Feb 14, 2013 at 11:12:09AM +0100, Roger Pau Monne wrote: > >> With current persistent grants implementation we are not freeing the > >> persistent grants after we

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Roger Pau Monné
On 14/02/13 14:23, Konrad Rzeszutek Wilk wrote: > On Thu, Feb 14, 2013 at 11:12:09AM +0100, Roger Pau Monne wrote: >> With current persistent grants implementation we are not freeing the >> persistent grants after we disconnect the device. Since grant map > > Can you explain this in more details

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Konrad Rzeszutek Wilk
On Thu, Feb 14, 2013 at 11:12:09AM +0100, Roger Pau Monne wrote: > With current persistent grants implementation we are not freeing the > persistent grants after we disconnect the device. Since grant map Can you explain this in more details please? Isn't gnttab_set_unmap_op in

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Roger Pau Monné
On 14/02/13 11:12, Roger Pau Monne wrote: > With current persistent grants implementation we are not freeing the > persistent grants after we disconnect the device. Since grant map > operations change the mfn of the allocated page, and we can no longer > pass it to __free_page without setting the

[PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Roger Pau Monne
With current persistent grants implementation we are not freeing the persistent grants after we disconnect the device. Since grant map operations change the mfn of the allocated page, and we can no longer pass it to __free_page without setting the mfn to a sane value, use balloon grant pages

[PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Roger Pau Monne
With current persistent grants implementation we are not freeing the persistent grants after we disconnect the device. Since grant map operations change the mfn of the allocated page, and we can no longer pass it to __free_page without setting the mfn to a sane value, use balloon grant pages

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Roger Pau Monné
On 14/02/13 11:12, Roger Pau Monne wrote: With current persistent grants implementation we are not freeing the persistent grants after we disconnect the device. Since grant map operations change the mfn of the allocated page, and we can no longer pass it to __free_page without setting the mfn

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Konrad Rzeszutek Wilk
On Thu, Feb 14, 2013 at 11:12:09AM +0100, Roger Pau Monne wrote: With current persistent grants implementation we are not freeing the persistent grants after we disconnect the device. Since grant map Can you explain this in more details please? Isn't gnttab_set_unmap_op in free_persistent_gnts

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Roger Pau Monné
On 14/02/13 14:23, Konrad Rzeszutek Wilk wrote: On Thu, Feb 14, 2013 at 11:12:09AM +0100, Roger Pau Monne wrote: With current persistent grants implementation we are not freeing the persistent grants after we disconnect the device. Since grant map Can you explain this in more details please?

Re: [PATCH] xen-blkback: use balloon pages for persistent grants

2013-02-14 Thread Konrad Rzeszutek Wilk
On Thu, Feb 14, 2013 at 04:02:43PM +0100, Roger Pau Monné wrote: On 14/02/13 14:23, Konrad Rzeszutek Wilk wrote: On Thu, Feb 14, 2013 at 11:12:09AM +0100, Roger Pau Monne wrote: With current persistent grants implementation we are not freeing the persistent grants after we disconnect the