Hi,
On (05/25/15 23:21), Minchan Kim wrote:
[..]
> find_backend is just utility function to get zcomp_backend.
> IOW, it might be used for several cases in future so I want
> make error report as caller's work.
[..]
> > if (sz > 0 && zram->compressor[sz - 1] == '\n')
> >
On Mon, May 25, 2015 at 03:18:38PM +0900, Sergey Senozhatsky wrote:
> On (05/22/15 15:26), Marcin Jabrzyk wrote:
> > >> From the other hand, the only valid values that can be written are
> > >>in 'comp_algorithm'.
> > >>So when writing other one, returning -EINVAL seems to be reasonable.
> > >>The
Hello Sergey,
On Mon, May 25, 2015 at 01:03:04PM +0900, Sergey Senozhatsky wrote:
> On (05/22/15 22:14), Minchan Kim wrote:
> > > > >second, there is not much value in exposing zcomp internals,
> > > > >especially when the result is just another line in dmesg output.
> > > >
> > > > From the
On 25/05/15 09:34, Sergey Senozhatsky wrote:
On (05/25/15 09:15), Marcin Jabrzyk wrote:
[..]
I'm perfectly fine with this solution. It just does what
I'd expect.
cool, let's hear from Minchan.
btw, if we decide to move on, how do you guys want to route
it? do you want Marcin (I don't
On (05/25/15 09:15), Marcin Jabrzyk wrote:
[..]
> >
> I'm perfectly fine with this solution. It just does what
> I'd expect.
cool, let's hear from Minchan.
btw, if we decide to move on, how do you guys want to route
it? do you want Marcin (I don't mind) or me (of course,
with the appropriate
Hi Sergey,
On 25/05/15 08:18, Sergey Senozhatsky wrote:
On (05/22/15 15:26), Marcin Jabrzyk wrote:
From the other hand, the only valid values that can be written are
in 'comp_algorithm'.
So when writing other one, returning -EINVAL seems to be reasonable.
The user would get immediately
On (05/25/15 15:18), Sergey Senozhatsky wrote:
> find_backend() returns back to its caller a raw and completely initialized
*UN-initialized. a typo.
-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
On (05/22/15 15:26), Marcin Jabrzyk wrote:
> >> From the other hand, the only valid values that can be written are
> >>in 'comp_algorithm'.
> >>So when writing other one, returning -EINVAL seems to be reasonable.
> >>The user would get immediately information that he can't do that,
> >>now the
On (05/25/15 15:18), Sergey Senozhatsky wrote:
find_backend() returns back to its caller a raw and completely initialized
*UN-initialized. a typo.
-ss
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On (05/22/15 15:26), Marcin Jabrzyk wrote:
From the other hand, the only valid values that can be written are
in 'comp_algorithm'.
So when writing other one, returning -EINVAL seems to be reasonable.
The user would get immediately information that he can't do that,
now the information can be
On 25/05/15 09:34, Sergey Senozhatsky wrote:
On (05/25/15 09:15), Marcin Jabrzyk wrote:
[..]
I'm perfectly fine with this solution. It just does what
I'd expect.
cool, let's hear from Minchan.
btw, if we decide to move on, how do you guys want to route
it? do you want Marcin (I don't
Hi Sergey,
On 25/05/15 08:18, Sergey Senozhatsky wrote:
On (05/22/15 15:26), Marcin Jabrzyk wrote:
From the other hand, the only valid values that can be written are
in 'comp_algorithm'.
So when writing other one, returning -EINVAL seems to be reasonable.
The user would get immediately
On (05/25/15 09:15), Marcin Jabrzyk wrote:
[..]
I'm perfectly fine with this solution. It just does what
I'd expect.
cool, let's hear from Minchan.
btw, if we decide to move on, how do you guys want to route
it? do you want Marcin (I don't mind) or me (of course,
with the appropriate
Hello Sergey,
On Mon, May 25, 2015 at 01:03:04PM +0900, Sergey Senozhatsky wrote:
On (05/22/15 22:14), Minchan Kim wrote:
second, there is not much value in exposing zcomp internals,
especially when the result is just another line in dmesg output.
From the other hand, the only
On Mon, May 25, 2015 at 03:18:38PM +0900, Sergey Senozhatsky wrote:
On (05/22/15 15:26), Marcin Jabrzyk wrote:
From the other hand, the only valid values that can be written are
in 'comp_algorithm'.
So when writing other one, returning -EINVAL seems to be reasonable.
The user would get
Hi,
On (05/25/15 23:21), Minchan Kim wrote:
[..]
find_backend is just utility function to get zcomp_backend.
IOW, it might be used for several cases in future so I want
make error report as caller's work.
[..]
if (sz 0 zram-compressor[sz - 1] == '\n')
zram-compressor[sz
On (05/22/15 22:14), Minchan Kim wrote:
> > > >second, there is not much value in exposing zcomp internals,
> > > >especially when the result is just another line in dmesg output.
> > >
> > > From the other hand, the only valid values that can be written are
> > > in 'comp_algorithm'.
> > > So
On (05/22/15 22:14), Minchan Kim wrote:
second, there is not much value in exposing zcomp internals,
especially when the result is just another line in dmesg output.
From the other hand, the only valid values that can be written are
in 'comp_algorithm'.
So when writing other
Hello Minchan,
On 22/05/15 15:14, Minchan Kim wrote:
Hello Sergey,
On Fri, May 22, 2015 at 09:44:11PM +0900, Sergey Senozhatsky wrote:
On (05/22/15 11:12), Marcin Jabrzyk wrote:
no.
zram already complains about failed comp backend creation.
it's in dmesg (or syslog, etc.):
"zram:
On 22/05/15 14:44, Sergey Senozhatsky wrote:
On (05/22/15 11:12), Marcin Jabrzyk wrote:
no.
zram already complains about failed comp backend creation.
it's in dmesg (or syslog, etc.):
"zram: Cannot initialise %s compressing backend"
OK, now I see that. Sorry for the noise.
Hello Sergey,
On Fri, May 22, 2015 at 09:44:11PM +0900, Sergey Senozhatsky wrote:
> On (05/22/15 11:12), Marcin Jabrzyk wrote:
> > >
> > >no.
> > >
> > >zram already complains about failed comp backend creation.
> > >it's in dmesg (or syslog, etc.):
> > >
> > > "zram: Cannot initialise %s
On (05/22/15 11:12), Marcin Jabrzyk wrote:
> >
> >no.
> >
> >zram already complains about failed comp backend creation.
> >it's in dmesg (or syslog, etc.):
> >
> > "zram: Cannot initialise %s compressing backend"
> >
> OK, now I see that. Sorry for the noise.
>
> >second, there is not much
Hi,
On 22/05/15 10:56, Sergey Senozhatsky wrote:
On (05/22/15 10:31), Marcin Jabrzyk wrote:
Zram sysfs interface was not making any check of
proper compressor name when setting it.
Any name is accepted, but further tries of device
creation would end up with not very meaningfull error.
eg.
On (05/22/15 10:31), Marcin Jabrzyk wrote:
> Zram sysfs interface was not making any check of
> proper compressor name when setting it.
> Any name is accepted, but further tries of device
> creation would end up with not very meaningfull error.
> eg.
>
> echo lz0 > comp_algorithm
> echo 200M >
Zram sysfs interface was not making any check of
proper compressor name when setting it.
Any name is accepted, but further tries of device
creation would end up with not very meaningfull error.
eg.
echo lz0 > comp_algorithm
echo 200M > disksize
echo: write error: Invalid argument
This commit
Zram sysfs interface was not making any check of
proper compressor name when setting it.
Any name is accepted, but further tries of device
creation would end up with not very meaningfull error.
eg.
echo lz0 comp_algorithm
echo 200M disksize
echo: write error: Invalid argument
This commit fixes
On (05/22/15 10:31), Marcin Jabrzyk wrote:
Zram sysfs interface was not making any check of
proper compressor name when setting it.
Any name is accepted, but further tries of device
creation would end up with not very meaningfull error.
eg.
echo lz0 comp_algorithm
echo 200M disksize
Hi,
On 22/05/15 10:56, Sergey Senozhatsky wrote:
On (05/22/15 10:31), Marcin Jabrzyk wrote:
Zram sysfs interface was not making any check of
proper compressor name when setting it.
Any name is accepted, but further tries of device
creation would end up with not very meaningfull error.
eg.
On 22/05/15 14:44, Sergey Senozhatsky wrote:
On (05/22/15 11:12), Marcin Jabrzyk wrote:
no.
zram already complains about failed comp backend creation.
it's in dmesg (or syslog, etc.):
zram: Cannot initialise %s compressing backend
OK, now I see that. Sorry for the noise.
Hello Sergey,
On Fri, May 22, 2015 at 09:44:11PM +0900, Sergey Senozhatsky wrote:
On (05/22/15 11:12), Marcin Jabrzyk wrote:
no.
zram already complains about failed comp backend creation.
it's in dmesg (or syslog, etc.):
zram: Cannot initialise %s compressing backend
OK,
On (05/22/15 11:12), Marcin Jabrzyk wrote:
no.
zram already complains about failed comp backend creation.
it's in dmesg (or syslog, etc.):
zram: Cannot initialise %s compressing backend
OK, now I see that. Sorry for the noise.
second, there is not much value in exposing zcomp
Hello Minchan,
On 22/05/15 15:14, Minchan Kim wrote:
Hello Sergey,
On Fri, May 22, 2015 at 09:44:11PM +0900, Sergey Senozhatsky wrote:
On (05/22/15 11:12), Marcin Jabrzyk wrote:
no.
zram already complains about failed comp backend creation.
it's in dmesg (or syslog, etc.):
zram:
32 matches
Mail list logo
