Re: [PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning
On Sun, 2 Sep 2007, Adrian Bunk wrote: > > On Sun, Sep 02, 2007 at 05:12:14AM +0530, Satyam Sharma wrote: > > > > drivers/acpi/tables/tbutils.c: In function 'acpi_tb_parse_root_table': > > drivers/acpi/tables/tbutils.c:403: > > warning: 'rsdt_address' may be used uninitialized in this function > > > > has been verified to be a bogus warning. Let's just initialize the > > variable to zero and shut this up. > >... > > Please use uninitialized_var() instead. On Sun, 2 Sep 2007, Satyam Sharma wrote: > [...] > I didn't use uninitialized_var() here because drivers/acpi/ is dual-licensed > stuff and used elsewhere, where that macro may be unavailable (?) Len, would it be okay to use uninitialized_var() in drivers/acpi/ code? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning
On Sun, Sep 02, 2007 at 05:12:14AM +0530, Satyam Sharma wrote: > > drivers/acpi/tables/tbutils.c: In function 'acpi_tb_parse_root_table': > drivers/acpi/tables/tbutils.c:403: > warning: 'rsdt_address' may be used uninitialized in this function > > has been verified to be a bogus warning. Let's just initialize the > variable to zero and shut this up. >... Please use uninitialized_var() instead. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning
drivers/acpi/tables/tbutils.c: In function 'acpi_tb_parse_root_table': drivers/acpi/tables/tbutils.c:403: warning: 'rsdt_address' may be used uninitialized in this function has been verified to be a bogus warning. Let's just initialize the variable to zero and shut this up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- I didn't use uninitialized_var() here because drivers/acpi/ is dual-licensed stuff and used elsewhere, where that macro may be unavailable (?) drivers/acpi/tables/tbutils.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/acpi/tables/tbutils.c~fix 2007-09-02 05:07:02.0 +0530 +++ linux-2.6.23-rc4-mm1/drivers/acpi/tables/tbutils.c 2007-09-02 05:07:14.0 +0530 @@ -400,7 +400,7 @@ acpi_tb_parse_root_table(acpi_physical_a u32 table_count; struct acpi_table_header *table; acpi_physical_address address; - acpi_physical_address rsdt_address; + acpi_physical_address rsdt_address = 0; u32 length; u8 *table_entry; acpi_status status; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning
drivers/acpi/tables/tbutils.c: In function 'acpi_tb_parse_root_table': drivers/acpi/tables/tbutils.c:403: warning: 'rsdt_address' may be used uninitialized in this function has been verified to be a bogus warning. Let's just initialize the variable to zero and shut this up. Signed-off-by: Satyam Sharma [EMAIL PROTECTED] --- I didn't use uninitialized_var() here because drivers/acpi/ is dual-licensed stuff and used elsewhere, where that macro may be unavailable (?) drivers/acpi/tables/tbutils.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/acpi/tables/tbutils.c~fix 2007-09-02 05:07:02.0 +0530 +++ linux-2.6.23-rc4-mm1/drivers/acpi/tables/tbutils.c 2007-09-02 05:07:14.0 +0530 @@ -400,7 +400,7 @@ acpi_tb_parse_root_table(acpi_physical_a u32 table_count; struct acpi_table_header *table; acpi_physical_address address; - acpi_physical_address rsdt_address; + acpi_physical_address rsdt_address = 0; u32 length; u8 *table_entry; acpi_status status; - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning
On Sun, Sep 02, 2007 at 05:12:14AM +0530, Satyam Sharma wrote: drivers/acpi/tables/tbutils.c: In function 'acpi_tb_parse_root_table': drivers/acpi/tables/tbutils.c:403: warning: 'rsdt_address' may be used uninitialized in this function has been verified to be a bogus warning. Let's just initialize the variable to zero and shut this up. ... Please use uninitialized_var() instead. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning
On Sun, 2 Sep 2007, Adrian Bunk wrote: On Sun, Sep 02, 2007 at 05:12:14AM +0530, Satyam Sharma wrote: drivers/acpi/tables/tbutils.c: In function 'acpi_tb_parse_root_table': drivers/acpi/tables/tbutils.c:403: warning: 'rsdt_address' may be used uninitialized in this function has been verified to be a bogus warning. Let's just initialize the variable to zero and shut this up. ... Please use uninitialized_var() instead. On Sun, 2 Sep 2007, Satyam Sharma wrote: [...] I didn't use uninitialized_var() here because drivers/acpi/ is dual-licensed stuff and used elsewhere, where that macro may be unavailable (?) Len, would it be okay to use uninitialized_var() in drivers/acpi/ code? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
