Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-16 Thread Mike Kravetz
On 05/16/2018 02:12 AM, Michal Hocko wrote: > On Tue 15-05-18 08:57:56, Huang, Ying wrote: >> From: Huang Ying >> >> This is to take better advantage of huge page clearing >> optimization (c79b57e462b5d, "mm: hugetlb: clear target sub-page last >> when clearing huge page").

Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-16 Thread Michal Hocko
On Tue 15-05-18 08:57:56, Huang, Ying wrote: > From: Huang Ying > > This is to take better advantage of huge page clearing > optimization (c79b57e462b5d, "mm: hugetlb: clear target sub-page last > when clearing huge page"). Which will clear to access sub-page last > to

Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-16 Thread Kirill A. Shutemov
On Wed, May 16, 2018 at 12:42:43AM +, Huang, Ying wrote: > >> + unsigned long address = faddress & huge_page_mask(h); > > > > faddress? I would rather keep it address and rename maked out variable to > > 'haddr'. We use 'haddr' for the cause in other places. > > I found haddr is popular in

Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-15 Thread Kirill A. Shutemov
On Tue, May 15, 2018 at 08:57:56AM +0800, Huang, Ying wrote: > From: Huang Ying > > This is to take better advantage of huge page clearing > optimization (c79b57e462b5d, "mm: hugetlb: clear target sub-page last > when clearing huge page"). Which will clear to access

Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-15 Thread David Rientjes
On Tue, 15 May 2018, Huang, Ying wrote: > From: Huang Ying > > This is to take better advantage of huge page clearing > optimization (c79b57e462b5d, "mm: hugetlb: clear target sub-page last > when clearing huge page"). Which will clear to access sub-page last > to avoid

Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-14 Thread Mike Kravetz
On 05/14/2018 05:57 PM, Huang, Ying wrote: > From: Huang Ying > > This is to take better advantage of huge page clearing > optimization (c79b57e462b5d, "mm: hugetlb: clear target sub-page last > when clearing huge page"). Which will clear to access sub-page last > to avoid

[PATCH -mm] mm, hugetlb: Pass fault address to no page handler

2018-05-14 Thread Huang, Ying
From: Huang Ying This is to take better advantage of huge page clearing optimization (c79b57e462b5d, "mm: hugetlb: clear target sub-page last when clearing huge page"). Which will clear to access sub-page last to avoid the cache lines of to access sub-page to be evicted