Re: [PATCH -mm] remove __GFP_NO_KSWAPD fixes

2012-07-25 Thread Minchan Kim
On Wed, Jul 25, 2012 at 02:51:19PM -0400, Rik van Riel wrote: > Turns out I missed two spots where __GFP_NO_KSWAPD is used. > > The removal from the trace code is obvious, since the flag > got removed there is no need to print it. > > For mtdcore.c, now that memory compaction has been fixed, > we

[PATCH -mm] remove __GFP_NO_KSWAPD fixes

2012-07-25 Thread Rik van Riel
Turns out I missed two spots where __GFP_NO_KSWAPD is used. The removal from the trace code is obvious, since the flag got removed there is no need to print it. For mtdcore.c, now that memory compaction has been fixed, we should no longer see large swap storms from an attempt to allocate a large

Re: [PATCH -mm] remove __GFP_NO_KSWAPD

2012-07-25 Thread Rik van Riel
On 07/24/2012 07:34 PM, Minchan Kim wrote: Hi Rik, On Tue, Jul 24, 2012 at 11:12:22AM -0400, Rik van Riel wrote: When transparent huge pages were introduced, memory compaction and swap storms were an issue, and the kernel had to be careful to not make THP allocations cause pageout or compaction

Re: [PATCH -mm] remove __GFP_NO_KSWAPD

2012-07-24 Thread Minchan Kim
Hi Rik, On Tue, Jul 24, 2012 at 11:12:22AM -0400, Rik van Riel wrote: > When transparent huge pages were introduced, memory compaction and > swap storms were an issue, and the kernel had to be careful to not > make THP allocations cause pageout or compaction. > > Now that we have working compacti

[PATCH -mm] remove __GFP_NO_KSWAPD

2012-07-24 Thread Rik van Riel
When transparent huge pages were introduced, memory compaction and swap storms were an issue, and the kernel had to be careful to not make THP allocations cause pageout or compaction. Now that we have working compaction deferral, kswapd is smart enough to invoke compaction and the quadratic behavi