Re: [PATCH -mm] sata_nv: fix kfree ordering in remove

2006-12-12 Thread Jeff Garzik
Robert Hancock wrote: Jeff Garzik wrote: It is unwise to free the struct before the ports are even detached. Right, theoretically something bad could happen here (though not likely). Here's a fix. Sorry for attaching with something so trivial, but Thunderbird isn't very cooperative..

Re: [PATCH -mm] sata_nv: fix kfree ordering in remove

2006-12-12 Thread Jeff Garzik
Robert Hancock wrote: Jeff Garzik wrote: It is unwise to free the struct before the ports are even detached. Right, theoretically something bad could happen here (though not likely). Here's a fix. Sorry for attaching with something so trivial, but Thunderbird isn't very cooperative..

[PATCH -mm] sata_nv: fix kfree ordering in remove

2006-12-11 Thread Robert Hancock
Jeff Garzik wrote: It is unwise to free the struct before the ports are even detached. Right, theoretically something bad could happen here (though not likely). Here's a fix. Sorry for attaching with something so trivial, but Thunderbird isn't very cooperative.. --- The suspend/resume

[PATCH -mm] sata_nv: fix kfree ordering in remove

2006-12-11 Thread Robert Hancock
Jeff Garzik wrote: It is unwise to free the struct before the ports are even detached. Right, theoretically something bad could happen here (though not likely). Here's a fix. Sorry for attaching with something so trivial, but Thunderbird isn't very cooperative.. --- The suspend/resume