Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
On Mon, 3 Sep 2007, Satyam Sharma wrote: > > On Sun, 2 Sep 2007, Alistair John Strachan wrote: > > > > The encoding is set to ISO-2022-JP, this is probably breaking things. > > ??? I have no clue how/why/when that suddenly happened. > > I clearly see "Content-Type: TEXT/PLAIN; charset=us-ascii" for the first > mail I sent out -- but all the replies seem to have somehow got this > weirdness. OK, I've got it figured out now. What happened is this -- alpine has this nifty feature that (if not explicitly set) it will automatically adjust the content-type encoding of outgoing mails depending upon the kind of text it sees written in the mail. Now when I normally post (eg. the first mail in this set), it naturally goes out as US-ASCII. What was special about the other mails was that each contained GCC's error/warning output. And if you've noticed it produces that totally pointless special non- US-ASCII 'quotes' around wherever it points out the name of an identifier -- and that confused alpine into thinking I was writing in Japanese (!) Anyway, I've explicitly set all mails to be sent out as US-ASCII only now, so hopefully things will be ok ... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
On Sun, 2 Sep 2007, Alistair John Strachan wrote:
> On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote:
> > On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > > Hi Jesper,
> > >
> > > On Sun, 2 Sep 2007, Jesper Juhl wrote:
> > > > > - if (!(interface = usb_find_interface(&sisusb_driver,
> > > > > subminor))) { - dev_err(&sisusb->sisusb_dev->dev,
> > > > > "Failed to find interface¥n");
> > > >
> > > > Odd how in your patch the line ends with "¥n" but if I look in my
> > > > local copy of the source tree I see "\n".
> > >
> > > Odd, indeed. I see correct '\n' in the mail I sent, but in your mail
> > > here it's coming out wrong -- lkml.org shows badness as well. Hmmm,
> > > "insert file" using ^R in alpine never gave any problems before ...
>
> The encoding is set to ISO-2022-JP, this is probably breaking things.
??? I have no clue how/why/when that suddenly happened.
I clearly see "Content-Type: TEXT/PLAIN; charset=us-ascii" for the first
mail I sent out -- but all the replies seem to have somehow got this
weirdness. Will close and restart my alpine session, just in case ...
thanks for heads-up, Alistair.
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote:
> On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > Hi Jesper,
> >
> > On Sun, 2 Sep 2007, Jesper Juhl wrote:
> > > > - if (!(interface = usb_find_interface(&sisusb_driver,
> > > > subminor))) { - dev_err(&sisusb->sisusb_dev->dev,
> > > > "Failed to find interface¥n");
> > >
> > > Odd how in your patch the line ends with "¥n" but if I look in my
> > > local copy of the source tree I see "\n".
> >
> > Odd, indeed. I see correct '\n' in the mail I sent, but in your mail
> > here it's coming out wrong -- lkml.org shows badness as well. Hmmm,
> > "insert file" using ^R in alpine never gave any problems before ...
The encoding is set to ISO-2022-JP, this is probably breaking things.
--
Cheers,
Alistair.
137/1 Warrender Park Road, Edinburgh, UK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> Hi Jesper,
>
>
> On Sun, 2 Sep 2007, Jesper Juhl wrote:
> >
> > > - if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
> > > - dev_err(&sisusb->sisusb_dev->dev, "Failed to find
> > > interface¥n");
> >
> > Odd how in your patch the line ends with "¥n" but if I look in my
> > local copy of the source tree I see "\n".
>
> Odd, indeed. I see correct '\n' in the mail I sent, but in your mail
> here it's coming out wrong -- lkml.org shows badness as well. Hmmm,
> "insert file" using ^R in alpine never gave any problems before ...
Hmm, I often use pine and ^R myself without trouble - haven't upgraded
to alpine yet, but something certainly is wrong.
I see the badness in your mail both in the gmail web interface and
kmail. So I guess it is caused on your end.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
Hi Jesper,
On Sun, 2 Sep 2007, Jesper Juhl wrote:
>
> > - if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
> > - dev_err(&sisusb->sisusb_dev->dev, "Failed to find
> > interface¥n");
>
> Odd how in your patch the line ends with "¥n" but if I look in my
> local copy of the source tree I see "\n".
Odd, indeed. I see correct '\n' in the mail I sent, but in your mail
here it's coming out wrong -- lkml.org shows badness as well. Hmmm,
"insert file" using ^R in alpine never gave any problems before ...
Re: [PATCH -mm] sisusbvga: Fix bug and build warnings
On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
> drivers/usb/misc/sisusbvga/sisusb.c: In function 'usb_sisusb_init':
> drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable 'sisusb'
> drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable 'retval'
>
> are trivially solved by getting rid of the unused variables.
>
> drivers/usb/misc/sisusbvga/sisusb.c: In function 'sisusb_open':
> drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: 'sisusb' is used
> uninitialized in this function
>
> is a genuine bug (which will cause oops). We cannot use "sisusb" in
> error path for (!interface), because sisusb will itself be derived
> from "interface" later.
>
> Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
>
> ---
>
> drivers/usb/misc/sisusbvga/sisusb.c |7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> --- linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c~fix
> 2007-09-02 19:06:01.0 +0530
> +++ linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c2007-09-02
> 19:10:52.0 +0530
> @@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct
> struct usb_interface *interface;
> int subminor = iminor(inode);
>
> - if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
> - dev_err(&sisusb->sisusb_dev->dev, "Failed to find
> interface\n");
Odd how in your patch the line ends with "\n" but if I look in my
local copy of the source tree I see "\n".
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH -mm] sisusbvga: Fix bug and build warnings
drivers/usb/misc/sisusbvga/sisusb.c: In function ‘usb_sisusb_init’:
drivers/usb/misc/sisusbvga/sisusb.c:3321: warning: unused variable ‘sisusb’
drivers/usb/misc/sisusbvga/sisusb.c:3320: warning: unused variable ‘retval’
are trivially solved by getting rid of the unused variables.
drivers/usb/misc/sisusbvga/sisusb.c: In function ‘sisusb_open’:
drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: ‘sisusb’ is used
uninitialized in this function
is a genuine bug (which will cause oops). We cannot use "sisusb" in
error path for (!interface), because sisusb will itself be derived
from "interface" later.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
drivers/usb/misc/sisusbvga/sisusb.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
--- linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c~fix
2007-09-02 19:06:01.0 +0530
+++ linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c2007-09-02
19:10:52.0 +0530
@@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct
struct usb_interface *interface;
int subminor = iminor(inode);
- if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
- dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface\n");
+ if (!(interface = usb_find_interface(&sisusb_driver, subminor)))
return -ENODEV;
- }
if (!(sisusb = usb_get_intfdata(interface)))
return -ENODEV;
@@ -3317,9 +3315,6 @@ static struct usb_driver sisusb_driver =
static int __init usb_sisusb_init(void)
{
- int retval;
- struct sisusb_usb_data *sisusb;
-
#ifdef INCL_SISUSB_CON
sisusb_init_concode();
#endif
