Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Fri, Feb 16, 2018 at 12:13:17AM +, Al Viro wrote: > On Fri, Feb 16, 2018 at 12:41:13AM +0300, Alexey Dobriyan wrote: > > On Thu, Feb 15, 2018 at 07:07:13PM +, Al Viro wrote: > > > On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > > > > > > > The more the merrier. > > >

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Fri, Feb 16, 2018 at 12:13:17AM +, Al Viro wrote: > On Fri, Feb 16, 2018 at 12:41:13AM +0300, Alexey Dobriyan wrote: > > On Thu, Feb 15, 2018 at 07:07:13PM +, Al Viro wrote: > > > On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > > > > > > > The more the merrier. > > >

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Thu, Feb 15, 2018 at 04:53:29PM -0800, Kees Cook wrote: > On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan wrote: > > The more the merrier. > > What made you choose this structure, BTW? Nothing depends on its layout. No funky memcpy/memset... It is strange you didn't

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Thu, Feb 15, 2018 at 04:53:29PM -0800, Kees Cook wrote: > On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan wrote: > > The more the merrier. > > What made you choose this structure, BTW? Nothing depends on its layout. No funky memcpy/memset... It is strange you didn't annotate like 95% of

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Thu, Feb 15, 2018 at 4:13 PM, Al Viro wrote: > Guess what happens to cache footprint of dcache lookups if the bunch in the > beginning gets spread over the entire thing? Right... And that's besides the > outright miscompiles. Mentioned in private communication, but

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Thu, Feb 15, 2018 at 4:13 PM, Al Viro wrote: > Guess what happens to cache footprint of dcache lookups if the bunch in the > beginning gets spread over the entire thing? Right... And that's besides the > outright miscompiles. Mentioned in private communication, but just for posterity:

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan wrote: > The more the merrier. What made you choose this structure, BTW? > Signed-off-by: Alexey Dobriyan > --- > > fs/proc/internal.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > ---

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan wrote: > The more the merrier. What made you choose this structure, BTW? > Signed-off-by: Alexey Dobriyan > --- > > fs/proc/internal.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/fs/proc/internal.h > +++

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Fri, Feb 16, 2018 at 12:41:13AM +0300, Alexey Dobriyan wrote: > On Thu, Feb 15, 2018 at 07:07:13PM +, Al Viro wrote: > > On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > > > > > The more the merrier. > > > > ITYM "Sanity is overrated anyway." > > If you view annotations

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Fri, Feb 16, 2018 at 12:41:13AM +0300, Alexey Dobriyan wrote: > On Thu, Feb 15, 2018 at 07:07:13PM +, Al Viro wrote: > > On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > > > > > The more the merrier. > > > > ITYM "Sanity is overrated anyway." > > If you view annotations

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Thu, Feb 15, 2018 at 07:07:13PM +, Al Viro wrote: > On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > > > The more the merrier. > > ITYM "Sanity is overrated anyway." If you view annotations as debugging option the thing is not that bad.

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Thu, Feb 15, 2018 at 07:07:13PM +, Al Viro wrote: > On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > > > The more the merrier. > > ITYM "Sanity is overrated anyway." If you view annotations as debugging option the thing is not that bad.

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > The more the merrier. ITYM "Sanity is overrated anyway."

Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"

On Wed, Feb 14, 2018 at 11:19:35AM +0300, Alexey Dobriyan wrote: > The more the merrier. ITYM "Sanity is overrated anyway."

[PATCH -mm 1/3] proc: randomize "struct pde_opener"

The more the merrier. Signed-off-by: Alexey Dobriyan --- fs/proc/internal.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -177,7 +177,7 @@ struct pde_opener { struct list_head lh; bool

[PATCH -mm 1/3] proc: randomize "struct pde_opener"

The more the merrier. Signed-off-by: Alexey Dobriyan --- fs/proc/internal.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -177,7 +177,7 @@ struct pde_opener { struct list_head lh; bool closing; struct