Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Sam Ravnborg
On Fri, Dec 21, 2007 at 12:51:06PM -0500, Kyle McMartin wrote: > On Fri, Dec 21, 2007 at 12:56:09AM -0800, Roland McGrath wrote: > > > On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: > > > > +obj-$(CONFIG_PPC64)+= ../../../fs/compat_binfmt_elf.o > > > > > > Building

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Arnd Bergmann
On Friday 21 December 2007, Kyle McMartin wrote: > Just taking a stab that hch means, > > config BINFMT_COMPAT_ELF > def_bool n > depends on 64BIT > I'd call it COMPAT_BINFMT_ELF, for consistency with the file name. Also, the definition and the depends are redundant if you

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Kyle McMartin
On Fri, Dec 21, 2007 at 12:56:09AM -0800, Roland McGrath wrote: > > On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: > > > +obj-$(CONFIG_PPC64) += ../../../fs/compat_binfmt_elf.o > > > > Building files from another directory is nasty. Please add a > >

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Roland McGrath
> On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: > > +obj-$(CONFIG_PPC64)+= ../../../fs/compat_binfmt_elf.o > > Building files from another directory is nasty. Please add a > CONFIG_BINFMT_COMPAT_ELF so we can simply build it in fs/ If that's better, please post

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Roland McGrath
On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: +obj-$(CONFIG_PPC64)+= ../../../fs/compat_binfmt_elf.o Building files from another directory is nasty. Please add a CONFIG_BINFMT_COMPAT_ELF so we can simply build it in fs/ If that's better, please post the

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Kyle McMartin
On Fri, Dec 21, 2007 at 12:56:09AM -0800, Roland McGrath wrote: On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: +obj-$(CONFIG_PPC64) += ../../../fs/compat_binfmt_elf.o Building files from another directory is nasty. Please add a CONFIG_BINFMT_COMPAT_ELF so

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Arnd Bergmann
On Friday 21 December 2007, Kyle McMartin wrote: Just taking a stab that hch means, config BINFMT_COMPAT_ELF def_bool n depends on 64BIT I'd call it COMPAT_BINFMT_ELF, for consistency with the file name. Also, the definition and the depends are redundant if you expect the

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-21 Thread Sam Ravnborg
On Fri, Dec 21, 2007 at 12:51:06PM -0500, Kyle McMartin wrote: On Fri, Dec 21, 2007 at 12:56:09AM -0800, Roland McGrath wrote: On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: +obj-$(CONFIG_PPC64)+= ../../../fs/compat_binfmt_elf.o Building files from

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-20 Thread Christoph Hellwig
On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: > +obj-$(CONFIG_PPC64) += ../../../fs/compat_binfmt_elf.o Building files from another directory is nasty. Please add a CONFIG_BINFMT_COMPAT_ELF so we can simply build it in fs/ -- To unsubscribe from this list: send the

[PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-20 Thread Roland McGrath
This switches the CONFIG_PPC64 support for 32-bit ELF to use the generic fs/compat_binfmt_elf.c implementation instead of our own binfmt_elf32.c. Since so much is the same between 32/64, there is only one macro we have to define to make the generic support work out of the box. Signed-off-by:

[PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-20 Thread Roland McGrath
This switches the CONFIG_PPC64 support for 32-bit ELF to use the generic fs/compat_binfmt_elf.c implementation instead of our own binfmt_elf32.c. Since so much is the same between 32/64, there is only one macro we have to define to make the generic support work out of the box. Signed-off-by:

Re: [PATCH -mm 18/43] powerpc compat_binfmt_elf

2007-12-20 Thread Christoph Hellwig
On Thu, Dec 20, 2007 at 03:58:16AM -0800, Roland McGrath wrote: +obj-$(CONFIG_PPC64) += ../../../fs/compat_binfmt_elf.o Building files from another directory is nasty. Please add a CONFIG_BINFMT_COMPAT_ELF so we can simply build it in fs/ -- To unsubscribe from this list: send the