Re: [PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-18 Thread Jan Blunck
On Sun, Feb 17, Christoph Hellwig wrote: > On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote: > > diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c > > index 02223e2..a57b024 100644 > > --- a/fs/sysfs/file.c > > +++ b/fs/sysfs/file.c > > @@ -329,9 +329,11 @@ static int

Re: [PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-18 Thread Jan Blunck
On Sun, Feb 17, Christoph Hellwig wrote: On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote: diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 02223e2..a57b024 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode

Re: [PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-17 Thread Christoph Hellwig
On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote: > diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c > index 02223e2..a57b024 100644 > --- a/fs/sysfs/file.c > +++ b/fs/sysfs/file.c > @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode *inode, struct > file *file) > struct

Re: [PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-17 Thread Christoph Hellwig
On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote: diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 02223e2..a57b024 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode *inode, struct file *file) struct

[PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-16 Thread Erez Zadok
Using mmotm-2008-02-15-11-03, I get CC fs/sysfs/file.o fs/sysfs/file.c: In function 'sysfs_open_file': fs/sysfs/file.c:334: warning: passing argument 1 of 'd_path' from incompatible pointer type fs/sysfs/file.c:334: warning: passing argument 2 of 'd_path' from incompatible pointer type

[PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-16 Thread Erez Zadok
Using mmotm-2008-02-15-11-03, I get CC fs/sysfs/file.o fs/sysfs/file.c: In function 'sysfs_open_file': fs/sysfs/file.c:334: warning: passing argument 1 of 'd_path' from incompatible pointer type fs/sysfs/file.c:334: warning: passing argument 2 of 'd_path' from incompatible pointer type