Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-22 Thread Daniel Vetter
On Sun, May 21, 2017 at 01:09:05PM +0100, Chris Wilson wrote: > On Sun, May 21, 2017 at 01:19:39AM +, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function platform_device_register_simple() returns > > ERR_PTR() and never returns NULL. The

Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-22 Thread Daniel Vetter
On Sun, May 21, 2017 at 01:09:05PM +0100, Chris Wilson wrote: > On Sun, May 21, 2017 at 01:19:39AM +, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function platform_device_register_simple() returns > > ERR_PTR() and never returns NULL. The NULL test in the return

Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-21 Thread Chris Wilson
On Sun, May 21, 2017 at 01:19:39AM +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_device_register_simple() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). >

Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-21 Thread Chris Wilson
On Sun, May 21, 2017 at 01:19:39AM +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_device_register_simple() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). > > Fixes: 315f0242aa2b

[PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-20 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 315f0242aa2b ("drm/vgem: Convert to a struct drm_device

[PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-20 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 315f0242aa2b ("drm/vgem: Convert to a struct drm_device subclass") Signed-off-by: Wei