Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns
On Tue, Feb 16, 2021 at 09:48:25AM +0100, Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warning in libfs.c. > > > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not > > described in 'simple_setattr' > > Shouldn't the subject say simple_setattr instead of mnt_userns? > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig So I've picked this up but just as an fyi b4 fell all over its face on this series always giving me partial patches or prefixing it with v2 or v3 or sm. Really strange, I'll report this to Konstantin. Christian
Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns
On Tue, Feb 16, 2021 at 09:48:25AM +0100, Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warning in libfs.c. > > > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not > > described in 'simple_setattr' > > Shouldn't the subject say simple_setattr instead of mnt_userns? > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Just an fyi, Lukas sent a series for this 1 or 2 weeks ago https://lore.kernel.org/lkml/20210204180059.28360-1-lukas.bulw...@gmail.com Hadn't yet replied to that one. Christian
Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns
On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > Fix kernel-doc warning in libfs.c. > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not > described in 'simple_setattr' Shouldn't the subject say simple_setattr instead of mnt_userns? Otherwise looks good: Reviewed-by: Christoph Hellwig
[PATCH -next] fs: libfs: fix kernel-doc for mnt_userns
Fix kernel-doc warning in libfs.c.
../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not
described in 'simple_setattr'
Fixes: 549c7297717c ("fs: make helpers idmap mount aware")
Signed-off-by: Randy Dunlap
Cc: Christoph Hellwig
Cc: David Howells
Cc: Al Viro
Cc: linux-fsde...@vger.kernel.org
Cc: Christian Brauner
---
fs/libfs.c |1 +
1 file changed, 1 insertion(+)
--- linux-next-20210215.orig/fs/libfs.c
+++ linux-next-20210215/fs/libfs.c
@@ -481,6 +481,7 @@ EXPORT_SYMBOL(simple_rename);
/**
* simple_setattr - setattr for simple filesystem
+ * @mnt_userns: user namespace of the target mount
* @dentry: dentry
* @iattr: iattr structure
*
