Re: [PATCH -next] irqchip/exiu: Fix return value check in exiu_init()

2017-11-14 Thread Marc Zyngier
On Tue, Nov 14 2017 at 9:55:46 am GMT, Ard Biesheuvel wrote: > On 14 November 2017 at 06:57, Wei Yongjun wrote: >> In case of error, the function of_iomap() returns NULL pointer not >> ERR_PTR(). The IS_ERR() test in the return value check

Re: [PATCH -next] irqchip/exiu: Fix return value check in exiu_init()

2017-11-14 Thread Ard Biesheuvel
On 14 November 2017 at 06:57, Wei Yongjun wrote: > In case of error, the function of_iomap() returns NULL pointer not > ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 706cffc1b912 ("irqchip/exiu: Add support for

[PATCH -next] irqchip/exiu: Fix return value check in exiu_init()

2017-11-13 Thread Wei Yongjun
In case of error, the function of_iomap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 706cffc1b912 ("irqchip/exiu: Add support for Socionext Synquacer EXIU controller") Signed-off-by: Wei Yongjun