Re: [PATCH -next] misc: vexpress: Fix potential NULL dereference in vexpress_syscfg_probe()

2018-07-12 Thread Liviu Dudau
On Wed, Jul 11, 2018 at 04:41:10PM +0100, Sudeep Holla wrote: > On Wed, Jul 11, 2018 at 01:17:38PM +, Wei Yongjun wrote: > > platform_get_resource() may fail and return NULL, so we should > > better check it's return value to avoid a NULL pointer dereference > > a bit later in the code. > > >

Re: [PATCH -next] misc: vexpress: Fix potential NULL dereference in vexpress_syscfg_probe()

2018-07-11 Thread Sudeep Holla
On Wed, Jul 11, 2018 at 01:17:38PM +, Wei Yongjun wrote: > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference > a bit later in the code. > > This is detected by Coccinelle semantic patch. > > @@ > expression

[PATCH -next] misc: vexpress: Fix potential NULL dereference in vexpress_syscfg_probe()

2018-07-11 Thread Wei Yongjun
platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference a bit later in the code. This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = platform_get_resource(pdev, t, n); + if