Re: [PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'

[Jakub Kicinski]

On Fri, 8 May 2020 20:00:55 +0800 Samuel Zou wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set 
> but not used [-Wunused-but-set-variable]
>   u32 prev_time = 0;
>   ^
> 
> Reported-by: Hulk Robot 
> Signed-off-by: Samuel Zou 

Applied, thank you!

Re: [PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'

[Vladimir Oltean]

Hi Samuel,

On Fri, 8 May 2020 at 14:55, Samuel Zou  wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set 
> but not used [-Wunused-but-set-variable]
>   u32 prev_time = 0;
>   ^
>
> Reported-by: Hulk Robot 
> Signed-off-by: Samuel Zou 
> ---

Thank you for the patch!

Reviewed-by: Vladimir Oltean 
Tested-by: Vladimir Oltean 

>  drivers/net/dsa/sja1105/sja1105_vl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_vl.c 
> b/drivers/net/dsa/sja1105/sja1105_vl.c
> index b52f1af..aa9b0b9 100644
> --- a/drivers/net/dsa/sja1105/sja1105_vl.c
> +++ b/drivers/net/dsa/sja1105/sja1105_vl.c
> @@ -465,7 +465,6 @@ sja1105_gating_cfg_time_to_interval(struct 
> sja1105_gating_config *gating_cfg,
> struct sja1105_gate_entry *last_e;
> struct sja1105_gate_entry *e;
> struct list_head *prev;
> -   u32 prev_time = 0;
>
> list_for_each_entry(e, _cfg->entries, list) {
> struct sja1105_gate_entry *p;
> @@ -476,7 +475,6 @@ sja1105_gating_cfg_time_to_interval(struct 
> sja1105_gating_config *gating_cfg,
> continue;
>
> p = list_entry(prev, struct sja1105_gate_entry, list);
> -   prev_time = e->interval;
> p->interval = e->interval - p->interval;
> }
> last_e = list_last_entry(_cfg->entries,
> --
> 2.6.2
>

[PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'

[Samuel Zou]

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set 
but not used [-Wunused-but-set-variable]
  u32 prev_time = 0;
  ^

Reported-by: Hulk Robot 
Signed-off-by: Samuel Zou 
---
 drivers/net/dsa/sja1105/sja1105_vl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_vl.c 
b/drivers/net/dsa/sja1105/sja1105_vl.c
index b52f1af..aa9b0b9 100644
--- a/drivers/net/dsa/sja1105/sja1105_vl.c
+++ b/drivers/net/dsa/sja1105/sja1105_vl.c
@@ -465,7 +465,6 @@ sja1105_gating_cfg_time_to_interval(struct 
sja1105_gating_config *gating_cfg,
struct sja1105_gate_entry *last_e;
struct sja1105_gate_entry *e;
struct list_head *prev;
-   u32 prev_time = 0;
 
list_for_each_entry(e, _cfg->entries, list) {
struct sja1105_gate_entry *p;
@@ -476,7 +475,6 @@ sja1105_gating_cfg_time_to_interval(struct 
sja1105_gating_config *gating_cfg,
continue;
 
p = list_entry(prev, struct sja1105_gate_entry, list);
-   prev_time = e->interval;
p->interval = e->interval - p->interval;
}
last_e = list_last_entry(_cfg->entries,
-- 
2.6.2