Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock

2013-07-26 Thread Greg KH
On Fri, Jul 26, 2013 at 10:32:33AM +0300, Dan Carpenter wrote: > On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > > > A spin lock is taken here so we should use GFP_ATOMIC. > > > > Acked-by: Dan Carpenter > > But the locking here is really odd and pointle

Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock

2013-07-26 Thread Dan Carpenter
On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > A spin lock is taken here so we should use GFP_ATOMIC. > Acked-by: Dan Carpenter But the locking here is really odd and pointless. usb_submit_urb() returns asynchronously before the data has been sent, so th

[PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock

2013-07-25 Thread Wei Yongjun
From: Wei Yongjun A spin lock is taken here so we should use GFP_ATOMIC. Signed-off-by: Wei Yongjun --- drivers/staging/gdm724x/gdm_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index f570bc0..7b