Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

2018-11-10 Thread Al Viro
On Sat, Nov 10, 2018 at 04:13:24AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > fs/sysv/inode.c: In function '__sysv_write_inode': > fs/sysv/inode.c:239:6: warning: > variable 'err' set but not used [-Wunused-but-set-variable] > > __sysv_write_inode should

Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

2018-11-10 Thread Christoph Hellwig
Looks fine: Reviewed-by: Christoph Hellwig Al, can you queue it up?

[PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

2018-11-09 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: fs/sysv/inode.c: In function '__sysv_write_inode': fs/sysv/inode.c:239:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] __sysv_write_inode should return 'err' instead of 0 Fixes: 05459ca81ac3 ("repair sysv_write_inode(),