Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Sam Ravnborg
On Thu, Jul 18, 2013 at 12:30:33AM +0200, Yann E. MORIN wrote: > Sam, All, > > Well, while I was fighting on this on my side... ;-) > > On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: > > > We could extend the symbol option part to retreive values from a binary. > > > Something like this:

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Geert Uytterhoeven
On Thu, Jul 18, 2013 at 1:22 AM, H. Peter Anvin wrote: > It is worth noting that one of the things that keep getting brought up > as something that need this is gcc/binutils support for a specific feature. Yeah, then those tests would be run only once, at kconfig time. I guess we still run some

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Andrew Morton
On Thu, 18 Jul 2013 09:47:02 +0200 "Yann E. MORIN" wrote: > > > > I prefer the "option exec" approach, actually. That way the shell-outs > > are colocated with the code which uses > > Indeed, but in this case, all the checks will be spread-out in the Kconfig > files, and not easily

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Yann E. MORIN
Andrew, All, On Thursday 18 July 2013 09:34:08 Andrew Morton wrote: > On Thu, 18 Jul 2013 09:22:58 +0200 Geert Uytterhoeven > wrote: > > On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN > > wrote: > > > On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: > > >> > We could extend the symbol

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Andrew Morton
On Thu, 18 Jul 2013 09:22:58 +0200 Geert Uytterhoeven wrote: > On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN > wrote: > > On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: > >> > We could extend the symbol option part to retreive values from a binary. > >> > Something like this: > >> >

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Geert Uytterhoeven
On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN wrote: > On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: >> > We could extend the symbol option part to retreive values from a binary. >> > Something like this: >> > >> > config FOOBAR >> > bool >> > option exec="true" >> > >>

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Geert Uytterhoeven
On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN yann.morin.1...@free.fr wrote: On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: We could extend the symbol option part to retreive values from a binary. Something like this: config FOOBAR bool option exec=true

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Andrew Morton
On Thu, 18 Jul 2013 09:22:58 +0200 Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN yann.morin.1...@free.fr wrote: On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: We could extend the symbol option part to retreive values from a binary.

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Yann E. MORIN
Andrew, All, On Thursday 18 July 2013 09:34:08 Andrew Morton wrote: On Thu, 18 Jul 2013 09:22:58 +0200 Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN yann.morin.1...@free.fr wrote: On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly:

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Andrew Morton
On Thu, 18 Jul 2013 09:47:02 +0200 Yann E. MORIN yann.morin.1...@free.fr wrote: I prefer the option exec approach, actually. That way the shell-outs are colocated with the code which uses Indeed, but in this case, all the checks will be spread-out in the Kconfig files, and not easily

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Geert Uytterhoeven
On Thu, Jul 18, 2013 at 1:22 AM, H. Peter Anvin h...@zytor.com wrote: It is worth noting that one of the things that keep getting brought up as something that need this is gcc/binutils support for a specific feature. Yeah, then those tests would be run only once, at kconfig time. I guess we

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-18 Thread Sam Ravnborg
On Thu, Jul 18, 2013 at 12:30:33AM +0200, Yann E. MORIN wrote: Sam, All, Well, while I was fighting on this on my side... ;-) On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: We could extend the symbol option part to retreive values from a binary. Something like this:

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread H. Peter Anvin
On 07/17/2013 03:30 PM, Yann E. MORIN wrote: > > At the very least we'd have to decide if this is available only for > booleans/tristates, or for any type? Your implementation seems to make > it valid for strings/ints, too. > I feel the test should *export* a boolean. It is worth noting that

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread Yann E. MORIN
Sam, All, Well, while I was fighting on this on my side... ;-) On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: > > We could extend the symbol option part to retreive values from a binary. > > Something like this: > > > > config FOOBAR > > bool > > option exec="true" > > >

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread Borislav Petkov
On Wed, Jul 17, 2013 at 11:16:49PM +0200, Sam Ravnborg wrote: > + > +static void exec_command(const char *command, struct symbol *sym) > +{ > + char buffer[2048]; > + FILE *stream; Just some indentation level saving: > + > + stream = popen(command, "r"); > + > + if (stream !=

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread Sam Ravnborg
> > We could extend the symbol option part to retreive values from a binary. > Something like this: > > config FOOBAR > bool > option exec="true" > > FOOBAR would assume the value "y" if the command true has exit code == 0, > otherwise "n". > And similar conversions for other

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread Sam Ravnborg
We could extend the symbol option part to retreive values from a binary. Something like this: config FOOBAR bool option exec=true FOOBAR would assume the value y if the command true has exit code == 0, otherwise n. And similar conversions for other types. This

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread Borislav Petkov
On Wed, Jul 17, 2013 at 11:16:49PM +0200, Sam Ravnborg wrote: + +static void exec_command(const char *command, struct symbol *sym) +{ + char buffer[2048]; + FILE *stream; Just some indentation level saving: + + stream = popen(command, r); + + if (stream != NULL) {

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread Yann E. MORIN
Sam, All, Well, while I was fighting on this on my side... ;-) On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: We could extend the symbol option part to retreive values from a binary. Something like this: config FOOBAR bool option exec=true FOOBAR would

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-17 Thread H. Peter Anvin
On 07/17/2013 03:30 PM, Yann E. MORIN wrote: At the very least we'd have to decide if this is available only for booleans/tristates, or for any type? Your implementation seems to make it valid for strings/ints, too. I feel the test should *export* a boolean. It is worth noting that one of

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Sam Ravnborg
On Tue, Jul 16, 2013 at 10:08:07AM +0200, Yann E. MORIN wrote: > Andrew, All, > > On Tuesday 16 July 2013 09:56:11 Andrew Morton wrote: > > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton > > wrote: > > > On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" > > > wrote: > > > > On 07/15/2013

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Florian Fainelli
2013/7/16 Borislav Petkov : > On Tue, Jul 16, 2013 at 11:45:27AM +0200, Yann E. MORIN wrote: >> As discussed with Florian in this thread, either one of: >> - a warning at check time >> - a comment in Kconfig > > Whatever you do, make sure to make it quite clear to users what she > needs to do.

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 11:45:27AM +0200, Yann E. MORIN wrote: > As discussed with Florian in this thread, either one of: > - a warning at check time > - a comment in Kconfig Whatever you do, make sure to make it quite clear to users what she needs to do. What I really have a problem with is

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Borislav, All, On Tuesday 16 July 2013 11:38:20 Borislav Petkov wrote: > On Tue, Jul 16, 2013 at 11:32:39AM +0200, Yann E. MORIN wrote: > > That does not work in two cases: > > - older distros that do not have the tool packaged > > This point is moot - distro kernels are built by the distro

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 11:32:39AM +0200, Yann E. MORIN wrote: > No, this is already too late: the given .config *is* already broken and > unbuildable. Yes, and we don't build it because we fail the build. > That does not work in two cases: > - older distros that do not have the tool packaged

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Borislav, All, On Tuesday 16 July 2013 11:22:42 Borislav Petkov wrote: > On Tue, Jul 16, 2013 at 11:12:17AM +0200, Yann E. MORIN wrote: > > The goal is to avoid generating a non-buildable kernel in the first place. > > I know, that's why I'm proposing to fail the build with the script run > as

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Florian, All, On Tuesday 16 July 2013 11:13:24 Florian Fainelli wrote: > 2013/7/16 Andrew Morton : > > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton > > wrote: > > > >> On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: > >> > >> > On 07/15/2013 03:03 PM, Andrew Morton wrote: > >> >

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 11:12:17AM +0200, Yann E. MORIN wrote: > The goal is to avoid generating a non-buildable kernel in the first place. I know, that's why I'm proposing to fail the build with the script run as one of the first things by make. > > I.e., those steps: > > 1. make config > > 2.

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 01:27:56AM -0700, Andrew Morton wrote: > What I'm angling at is, rather than a single global front-end script, > can we embed the scripts in some fashion within the various Kconfig > files? Say, > > script ./some-script.sh > > and the config system will only

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Florian Fainelli
2013/7/16 Andrew Morton : > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton > wrote: > >> On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: >> >> > On 07/15/2013 03:03 PM, Andrew Morton wrote: >> > > >> > > I don't know how to do this. Any suggestions? >> > > >> > > It has to be done

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Borislav, All, On Tuesday 16 July 2013 11:05:46 Borislav Petkov wrote: > On Tue, Jul 16, 2013 at 01:27:56AM -0700, Andrew Morton wrote: > > What I'm angling at is, rather than a single global front-end script, > > can we embed the scripts in some fashion within the various Kconfig > > files?

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Andrew Morton
On Tue, 16 Jul 2013 10:08:07 +0200 "Yann E. MORIN" wrote: > > Or, easier and faster, run some front-end script which generates > > once-off Kconfig symbols. > > > > if [ -x /bin/lz4c ] > > then > > echo CONFIG_HAVE_LZ4C > > fi > > > > then munge the output of that

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Andrew, All, On Tuesday 16 July 2013 09:56:11 Andrew Morton wrote: > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton > wrote: > > On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: > > > On 07/15/2013 03:03 PM, Andrew Morton wrote: [--SNIP--] > > > We keep running over the need to be

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Andrew Morton
On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton wrote: > On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: > > > On 07/15/2013 03:03 PM, Andrew Morton wrote: > > > > > > I don't know how to do this. Any suggestions? > > > > > > It has to be done at `make config' time. We'd need

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Andrew Morton
On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: > On 07/15/2013 03:03 PM, Andrew Morton wrote: > > > > I don't know how to do this. Any suggestions? > > > > It has to be done at `make config' time. We'd need to probe for the > > presence of lz4c and then what? > > > > Is

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Andrew Morton
On Mon, 15 Jul 2013 15:08:20 -0700 H. Peter Anvin h...@zytor.com wrote: On 07/15/2013 03:03 PM, Andrew Morton wrote: I don't know how to do this. Any suggestions? It has to be done at `make config' time. We'd need to probe for the presence of lz4c and then what? Is there

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Andrew Morton
On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton a...@linux-foundation.org wrote: On Mon, 15 Jul 2013 15:08:20 -0700 H. Peter Anvin h...@zytor.com wrote: On 07/15/2013 03:03 PM, Andrew Morton wrote: I don't know how to do this. Any suggestions? It has to be done at `make

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Andrew, All, On Tuesday 16 July 2013 09:56:11 Andrew Morton wrote: On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton a...@linux-foundation.org wrote: On Mon, 15 Jul 2013 15:08:20 -0700 H. Peter Anvin h...@zytor.com wrote: On 07/15/2013 03:03 PM, Andrew Morton wrote: [--SNIP--] We keep

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Andrew Morton
On Tue, 16 Jul 2013 10:08:07 +0200 Yann E. MORIN yann.morin.1...@free.fr wrote: Or, easier and faster, run some front-end script which generates once-off Kconfig symbols. if [ -x /bin/lz4c ] then echo CONFIG_HAVE_LZ4C fi then munge the output of that

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Borislav, All, On Tuesday 16 July 2013 11:05:46 Borislav Petkov wrote: On Tue, Jul 16, 2013 at 01:27:56AM -0700, Andrew Morton wrote: What I'm angling at is, rather than a single global front-end script, can we embed the scripts in some fashion within the various Kconfig files? Say,

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Florian Fainelli
2013/7/16 Andrew Morton a...@linux-foundation.org: On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton a...@linux-foundation.org wrote: On Mon, 15 Jul 2013 15:08:20 -0700 H. Peter Anvin h...@zytor.com wrote: On 07/15/2013 03:03 PM, Andrew Morton wrote: I don't know how to do this. Any

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 01:27:56AM -0700, Andrew Morton wrote: What I'm angling at is, rather than a single global front-end script, can we embed the scripts in some fashion within the various Kconfig files? Say, script ./some-script.sh and the config system will only evaluate that

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 11:12:17AM +0200, Yann E. MORIN wrote: The goal is to avoid generating a non-buildable kernel in the first place. I know, that's why I'm proposing to fail the build with the script run as one of the first things by make. I.e., those steps: 1. make whateverconfig 2.

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Florian, All, On Tuesday 16 July 2013 11:13:24 Florian Fainelli wrote: 2013/7/16 Andrew Morton a...@linux-foundation.org: On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton a...@linux-foundation.org wrote: On Mon, 15 Jul 2013 15:08:20 -0700 H. Peter Anvin h...@zytor.com wrote: On

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Borislav, All, On Tuesday 16 July 2013 11:22:42 Borislav Petkov wrote: On Tue, Jul 16, 2013 at 11:12:17AM +0200, Yann E. MORIN wrote: The goal is to avoid generating a non-buildable kernel in the first place. I know, that's why I'm proposing to fail the build with the script run as one of

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 11:32:39AM +0200, Yann E. MORIN wrote: No, this is already too late: the given .config *is* already broken and unbuildable. Yes, and we don't build it because we fail the build. That does not work in two cases: - older distros that do not have the tool packaged

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Yann E. MORIN
Borislav, All, On Tuesday 16 July 2013 11:38:20 Borislav Petkov wrote: On Tue, Jul 16, 2013 at 11:32:39AM +0200, Yann E. MORIN wrote: That does not work in two cases: - older distros that do not have the tool packaged This point is moot - distro kernels are built by the distro people.

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Borislav Petkov
On Tue, Jul 16, 2013 at 11:45:27AM +0200, Yann E. MORIN wrote: As discussed with Florian in this thread, either one of: - a warning at check time - a comment in Kconfig Whatever you do, make sure to make it quite clear to users what she needs to do. What I really have a problem with is

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Florian Fainelli
2013/7/16 Borislav Petkov b...@alien8.de: On Tue, Jul 16, 2013 at 11:45:27AM +0200, Yann E. MORIN wrote: As discussed with Florian in this thread, either one of: - a warning at check time - a comment in Kconfig Whatever you do, make sure to make it quite clear to users what she needs to

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-16 Thread Sam Ravnborg
On Tue, Jul 16, 2013 at 10:08:07AM +0200, Yann E. MORIN wrote: Andrew, All, On Tuesday 16 July 2013 09:56:11 Andrew Morton wrote: On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton a...@linux-foundation.org wrote: On Mon, 15 Jul 2013 15:08:20 -0700 H. Peter Anvin h...@zytor.com

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-15 Thread H. Peter Anvin
On 07/15/2013 03:03 PM, Andrew Morton wrote: > > I don't know how to do this. Any suggestions? > > It has to be done at `make config' time. We'd need to probe for the > presence of lz4c and then what? > > Is there any precedent for this? > > I don't think we can just ignore the absence

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-15 Thread Andrew Morton
On Fri, 12 Jul 2013 09:56:02 +0200 Ingo Molnar wrote: > > * Kyungsik Lee wrote: > > quiet_cmd_lz4 = LZ4 $@ > > cmd_lz4 = (cat $(filter-out FORCE,$^) | \ > > - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out > > FORCE,$^))) > $@ || \ > > + lz4c -l -c1 stdin stdout &&

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-15 Thread Andrew Morton
On Fri, 12 Jul 2013 09:56:02 +0200 Ingo Molnar mi...@kernel.org wrote: * Kyungsik Lee kyungsik@lge.com wrote: quiet_cmd_lz4 = LZ4 $@ cmd_lz4 = (cat $(filter-out FORCE,$^) | \ - lz4demo -c1 stdin stdout $(call size_append, $(filter-out FORCE,$^))) $@ || \ + lz4c -l

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-15 Thread H. Peter Anvin
On 07/15/2013 03:03 PM, Andrew Morton wrote: I don't know how to do this. Any suggestions? It has to be done at `make config' time. We'd need to probe for the presence of lz4c and then what? Is there any precedent for this? I don't think we can just ignore the absence of lz4c -

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 01:34:38PM +0100, Florian Fainelli wrote: > Shall we provide a shell script wrapper for all of these compressor > commands which would test for the utility presence and issue a BIG FAT > WARNING if not, but still create the file not to make the kernel build > fail? I guess

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Florian Fainelli
Hello, 2013/7/12 Borislav Petkov : > On Fri, Jul 12, 2013 at 04:18:10AM -0700, Andrew Morton wrote: >> Well y'know, if whining fixed bugs then there would be no problem here >> at all. > > I know. I decided to whine this time and not try to fix it because > attempting to fix every fallout I'm

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 04:18:10AM -0700, Andrew Morton wrote: > Well y'know, if whining fixed bugs then there would be no problem here > at all. I know. I decided to whine this time and not try to fix it because attempting to fix every fallout I'm seeing in the tree with randconfigs is a

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Ingo Molnar
* Andrew Morton wrote: > On Fri, 12 Jul 2013 12:23:26 +0200 Borislav Petkov wrote: > > > On Fri, Jul 12, 2013 at 12:13:19PM +0200, Ingo Molnar wrote: > > > and now it is upstream already, via -mm: > > > > > >e76e1fdfa8f8 lib: add support for LZ4-compressed kernel > > > > Sure. Let's see

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Andrew Morton
On Fri, 12 Jul 2013 12:23:26 +0200 Borislav Petkov wrote: > On Fri, Jul 12, 2013 at 12:13:19PM +0200, Ingo Molnar wrote: > > and now it is upstream already, via -mm: > > > >e76e1fdfa8f8 lib: add support for LZ4-compressed kernel > > Sure. Let's see if it manages to get released b0rked like

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 12:13:19PM +0200, Ingo Molnar wrote: > and now it is upstream already, via -mm: > >e76e1fdfa8f8 lib: add support for LZ4-compressed kernel Sure. Let's see if it manages to get released b0rked like it is right now. -- Regards/Gruss, Boris. Sent from a fat crate

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Ingo Molnar
* Borislav Petkov wrote: > On Fri, Jul 12, 2013 at 09:56:02AM +0200, Ingo Molnar wrote: > > > > If a utility is not widely available yet and if the utility is not in > > the kernel proper, could you please at least make sure that randconfig > > does not stumble over non-buildable kernels? >

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 09:56:02AM +0200, Ingo Molnar wrote: > If a utility is not widely available yet and if the utility is not in > the kernel proper, could you please at least make sure that randconfig > does not stumble over non-buildable kernels? Two months ago I've complained about this

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Ingo Molnar
* Kyungsik Lee wrote: > LZ4 has been updated with LZ4 Streaming Format specification(v1.3). > lz4demo is replaced by lz4c. lz4c supports both the new streaming and > legacy format with -l option. > > This patch makes use of lz4c to support legacy format which is > used for LZ4 De/compression

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Ingo Molnar
* Kyungsik Lee kyungsik@lge.com wrote: LZ4 has been updated with LZ4 Streaming Format specification(v1.3). lz4demo is replaced by lz4c. lz4c supports both the new streaming and legacy format with -l option. This patch makes use of lz4c to support legacy format which is used for LZ4

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 09:56:02AM +0200, Ingo Molnar wrote: If a utility is not widely available yet and if the utility is not in the kernel proper, could you please at least make sure that randconfig does not stumble over non-buildable kernels? Two months ago I've complained about this and

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Ingo Molnar
* Borislav Petkov b...@alien8.de wrote: On Fri, Jul 12, 2013 at 09:56:02AM +0200, Ingo Molnar wrote: If a utility is not widely available yet and if the utility is not in the kernel proper, could you please at least make sure that randconfig does not stumble over non-buildable

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 12:13:19PM +0200, Ingo Molnar wrote: and now it is upstream already, via -mm: e76e1fdfa8f8 lib: add support for LZ4-compressed kernel Sure. Let's see if it manages to get released b0rked like it is right now. -- Regards/Gruss, Boris. Sent from a fat crate

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Andrew Morton
On Fri, 12 Jul 2013 12:23:26 +0200 Borislav Petkov b...@alien8.de wrote: On Fri, Jul 12, 2013 at 12:13:19PM +0200, Ingo Molnar wrote: and now it is upstream already, via -mm: e76e1fdfa8f8 lib: add support for LZ4-compressed kernel Sure. Let's see if it manages to get released b0rked

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Ingo Molnar
* Andrew Morton a...@linux-foundation.org wrote: On Fri, 12 Jul 2013 12:23:26 +0200 Borislav Petkov b...@alien8.de wrote: On Fri, Jul 12, 2013 at 12:13:19PM +0200, Ingo Molnar wrote: and now it is upstream already, via -mm: e76e1fdfa8f8 lib: add support for LZ4-compressed

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 04:18:10AM -0700, Andrew Morton wrote: Well y'know, if whining fixed bugs then there would be no problem here at all. I know. I decided to whine this time and not try to fix it because attempting to fix every fallout I'm seeing in the tree with randconfigs is a full-time

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Florian Fainelli
Hello, 2013/7/12 Borislav Petkov b...@alien8.de: On Fri, Jul 12, 2013 at 04:18:10AM -0700, Andrew Morton wrote: Well y'know, if whining fixed bugs then there would be no problem here at all. I know. I decided to whine this time and not try to fix it because attempting to fix every fallout

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-12 Thread Borislav Petkov
On Fri, Jul 12, 2013 at 01:34:38PM +0100, Florian Fainelli wrote: Shall we provide a shell script wrapper for all of these compressor commands which would test for the utility presence and issue a BIG FAT WARNING if not, but still create the file not to make the kernel build fail? I guess we

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Kyungsik Lee
> > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore > > diff --git a/.gitignore b/.gitignore > index 3b8b9b3..7e9932e 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -29,6 +29,7 @@

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Borislav Petkov
On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: > Well, there's also no hand-holding when lzop is missing for LZO. And > the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Markus Trippelsdorf
On 2013.07.10 at 11:36 +0200, Borislav Petkov wrote: > On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > > >> index a0ab6d7..c9bfbb0 100644 > > >> --- a/scripts/Makefile.lib > > >> +++ b/scripts/Makefile.lib > > >>

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Borislav Petkov
On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >> index a0ab6d7..c9bfbb0 100644 > >> --- a/scripts/Makefile.lib > >> +++ b/scripts/Makefile.lib > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ >

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Geert Uytterhoeven
On Mon, May 6, 2013 at 11:51 AM, Borislav Petkov wrote: > On Mon, May 06, 2013 at 05:42:55PM +0900, Kyungsik Lee wrote: >> LZ4 has been updated with LZ4 Streaming Format specification(v1.3). >> lz4demo is replaced by lz4c. lz4c supports both the new streaming and >> legacy format with -l option.

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Geert Uytterhoeven
On Mon, May 6, 2013 at 11:51 AM, Borislav Petkov b...@alien8.de wrote: On Mon, May 06, 2013 at 05:42:55PM +0900, Kyungsik Lee wrote: LZ4 has been updated with LZ4 Streaming Format specification(v1.3). lz4demo is replaced by lz4c. lz4c supports both the new streaming and legacy format with -l

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Borislav Petkov
On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index a0ab6d7..c9bfbb0 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Markus Trippelsdorf
On 2013.07.10 at 11:36 +0200, Borislav Petkov wrote: On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index a0ab6d7..c9bfbb0 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -313,7 +313,7 @@

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Borislav Petkov
On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: Well, there's also no hand-holding when lzop is missing for LZO. And the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-07-10 Thread Kyungsik Lee
BTW speaking of introductory-level patches, what about the following one: Now that lz4 kernel compression is available, add *.lz4 to .gitignore diff --git a/.gitignore b/.gitignore index 3b8b9b3..7e9932e 100644 --- a/.gitignore +++ b/.gitignore @@ -29,6 +29,7 @@ modules.builtin

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-05-06 Thread Borislav Petkov
On Mon, May 06, 2013 at 05:42:55PM +0900, Kyungsik Lee wrote: > LZ4 has been updated with LZ4 Streaming Format specification(v1.3). > lz4demo is replaced by lz4c. lz4c supports both the new streaming and > legacy format with -l option. > > This patch makes use of lz4c to support legacy format

[PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-05-06 Thread Kyungsik Lee
LZ4 has been updated with LZ4 Streaming Format specification(v1.3). lz4demo is replaced by lz4c. lz4c supports both the new streaming and legacy format with -l option. This patch makes use of lz4c to support legacy format which is used for LZ4 De/compression in the linux kernel. Link:

[PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-05-06 Thread Kyungsik Lee
LZ4 has been updated with LZ4 Streaming Format specification(v1.3). lz4demo is replaced by lz4c. lz4c supports both the new streaming and legacy format with -l option. This patch makes use of lz4c to support legacy format which is used for LZ4 De/compression in the linux kernel. Link:

Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format

2013-05-06 Thread Borislav Petkov
On Mon, May 06, 2013 at 05:42:55PM +0900, Kyungsik Lee wrote: LZ4 has been updated with LZ4 Streaming Format specification(v1.3). lz4demo is replaced by lz4c. lz4c supports both the new streaming and legacy format with -l option. This patch makes use of lz4c to support legacy format which is