Re: [PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-30 Thread Daniel Walker
On Mon, 2007-07-30 at 11:22 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > + /* > > +* If our rcu_read_lock_nesting went negative, likely > > +* something is wrong.. > > +*/ > > + WARN_ON(current->rcu_read_lock_nesting < 0); > > have you actually

Re: [PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-30 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > + /* > + * If our rcu_read_lock_nesting went negative, likely > + * something is wrong.. > + */ > + WARN_ON(current->rcu_read_lock_nesting < 0); have you actually caught any rcu locking problem this way? Double unlocks should

Re: [PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-30 Thread Ingo Molnar
* Daniel Walker [EMAIL PROTECTED] wrote: + /* + * If our rcu_read_lock_nesting went negative, likely + * something is wrong.. + */ + WARN_ON(current-rcu_read_lock_nesting 0); have you actually caught any rcu locking problem this way? Double unlocks should be caught

Re: [PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-30 Thread Daniel Walker
On Mon, 2007-07-30 at 11:22 +0200, Ingo Molnar wrote: * Daniel Walker [EMAIL PROTECTED] wrote: + /* +* If our rcu_read_lock_nesting went negative, likely +* something is wrong.. +*/ + WARN_ON(current-rcu_read_lock_nesting 0); have you actually caught any rcu

Re: [PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-29 Thread Paul E. McKenney
On Sun, Jul 29, 2007 at 07:45:35PM -0700, Daniel Walker wrote: > Simple WARN_ON to catch any underflow in rcu_read_lock_nesting. > > Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> Acked-by: Paul E. McKenney <[EMAIL PROTECTED]> > --- > kernel/rcupreempt.c |6 ++ > 1 file changed, 6

[PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-29 Thread Daniel Walker
Simple WARN_ON to catch any underflow in rcu_read_lock_nesting. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- kernel/rcupreempt.c |6 ++ 1 file changed, 6 insertions(+) Index: linux-2.6.22/kernel/rcupreempt.c ===

[PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-29 Thread Daniel Walker
Simple WARN_ON to catch any underflow in rcu_read_lock_nesting. Signed-off-by: Daniel Walker [EMAIL PROTECTED] --- kernel/rcupreempt.c |6 ++ 1 file changed, 6 insertions(+) Index: linux-2.6.22/kernel/rcupreempt.c === ---

Re: [PATCH -rt 1/9] preempt rcu: check for underflow

2007-07-29 Thread Paul E. McKenney
On Sun, Jul 29, 2007 at 07:45:35PM -0700, Daniel Walker wrote: Simple WARN_ON to catch any underflow in rcu_read_lock_nesting. Signed-off-by: Daniel Walker [EMAIL PROTECTED] Acked-by: Paul E. McKenney [EMAIL PROTECTED] --- kernel/rcupreempt.c |6 ++ 1 file changed, 6