Re: [PATCH -tip 12/32] sched: Simplify the core pick loop for optimized case

2020-11-25 Thread Peter Zijlstra
On Tue, Nov 24, 2020 at 12:04:30PM -0500, Joel Fernandes wrote: > Hi Peter, > > On Tue, Nov 24, 2020 at 01:04:38PM +0100, Peter Zijlstra wrote: > > On Tue, Nov 17, 2020 at 06:19:42PM -0500, Joel Fernandes (Google) wrote: > > > + /* > > > + * Optimize for common case where this CPU has no cookies

Re: [PATCH -tip 12/32] sched: Simplify the core pick loop for optimized case

2020-11-24 Thread Joel Fernandes
Hi Peter, On Tue, Nov 24, 2020 at 01:04:38PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 06:19:42PM -0500, Joel Fernandes (Google) wrote: > > + /* > > +* Optimize for common case where this CPU has no cookies > > +* and there are no cookied tasks running on siblings. > > +

Re: [PATCH -tip 12/32] sched: Simplify the core pick loop for optimized case

2020-11-24 Thread Peter Zijlstra
On Tue, Nov 17, 2020 at 06:19:42PM -0500, Joel Fernandes (Google) wrote: > + /* > + * Optimize for common case where this CPU has no cookies > + * and there are no cookied tasks running on siblings. > + */ > + if (!need_sync) { > + for_each_class(class) { > +

[PATCH -tip 12/32] sched: Simplify the core pick loop for optimized case

2020-11-17 Thread Joel Fernandes (Google)
The core pick loop grew a lot of warts over time to support optimizations. Turns out that that directly doing a class pick before entering the core-wide pick is better for readability. Make the changes. Since this is a relatively new patch, make it a separate patch so that it is easier to revert