Re: [PATCH 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build

[Alexandre Torgue]

Hi,

On 9/20/19 7:38 AM, Christophe Roullier wrote:

This patch fix the following warning:

warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
   int val, ret;

Signed-off-by: Christophe Roullier 
---


Acked-by: Alexandre TORGUE 


  drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c 
b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
index 7e6619868cc1..167a5e99960a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
@@ -184,7 +184,7 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data 
*plat_dat)
  {
struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
u32 reg = dwmac->mode_reg;
-   int val, ret;
+   int val;
  
  	switch (plat_dat->interface) {

case PHY_INTERFACE_MODE_MII:
@@ -220,8 +220,8 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data 
*plat_dat)
}
  
  	/* Need to update PMCCLRR (clear register) */

-   ret = regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
-  dwmac->ops->syscfg_eth_mask);
+   regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
+dwmac->ops->syscfg_eth_mask);
  
  	/* Update PMCSETR (set register) */

return regmap_update_bits(dwmac->regmap, reg,

[PATCH 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build

[Christophe Roullier]

This patch fix the following warning:

warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
  int val, ret;

Signed-off-by: Christophe Roullier 
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c 
b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
index 7e6619868cc1..167a5e99960a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
@@ -184,7 +184,7 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data 
*plat_dat)
 {
struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
u32 reg = dwmac->mode_reg;
-   int val, ret;
+   int val;
 
switch (plat_dat->interface) {
case PHY_INTERFACE_MODE_MII:
@@ -220,8 +220,8 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data 
*plat_dat)
}
 
/* Need to update PMCCLRR (clear register) */
-   ret = regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
-  dwmac->ops->syscfg_eth_mask);
+   regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
+dwmac->ops->syscfg_eth_mask);
 
/* Update PMCSETR (set register) */
return regmap_update_bits(dwmac->regmap, reg,
-- 
2.17.1