Re: [PATCH 0/2] UIO support for dfl devices

[Xu Yilun]

On Fri, Oct 16, 2020 at 09:40:03AM -0700, Tom Rix wrote:
> 
> On 10/15/20 11:02 PM, Xu Yilun wrote:
> > This patchset supports some dfl device drivers written in userspace.
> >
> > The usage is like:
> >
> >  # echo dfl_dev.1 > /sys/bus/dfl/drivers//unbind
> >  # echo dfl-uio-pdev > /sys/bus/dfl/devices/dfl_dev.1/driver_override
> >  # echo dfl_dev.1 > /sys/bus/dfl/drivers_probe
> >
> >
> > Xu Yilun (2):
> >   fpga: dfl: add driver_override support
> >   fpga: dfl: add the userspace I/O device support for DFL devices
> >
> >  Documentation/ABI/testing/sysfs-bus-dfl | 28 +--
> >  drivers/fpga/Kconfig| 10 
> >  drivers/fpga/Makefile   |  1 +
> >  drivers/fpga/dfl-uio-pdev.c | 83 
> > +
> >  drivers/fpga/dfl.c  | 54 -
> >  include/linux/dfl.h |  2 +
> >  6 files changed, 173 insertions(+), 5 deletions(-)
> >  create mode 100644 drivers/fpga/dfl-uio-pdev.c
> 
> This is a neat new feature.
> 
> Should something be added to Documentation/fpga/dfl.rst ?

Yes, I could add the Doc.

> 
> Overall, patchset looks good.
> 
> Tom

Re: [PATCH 0/2] UIO support for dfl devices

[Tom Rix]

On 10/15/20 11:02 PM, Xu Yilun wrote:
> This patchset supports some dfl device drivers written in userspace.
>
> The usage is like:
>
>  # echo dfl_dev.1 > /sys/bus/dfl/drivers//unbind
>  # echo dfl-uio-pdev > /sys/bus/dfl/devices/dfl_dev.1/driver_override
>  # echo dfl_dev.1 > /sys/bus/dfl/drivers_probe
>
>
> Xu Yilun (2):
>   fpga: dfl: add driver_override support
>   fpga: dfl: add the userspace I/O device support for DFL devices
>
>  Documentation/ABI/testing/sysfs-bus-dfl | 28 +--
>  drivers/fpga/Kconfig| 10 
>  drivers/fpga/Makefile   |  1 +
>  drivers/fpga/dfl-uio-pdev.c | 83 
> +
>  drivers/fpga/dfl.c  | 54 -
>  include/linux/dfl.h |  2 +
>  6 files changed, 173 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/fpga/dfl-uio-pdev.c

This is a neat new feature.

Should something be added to Documentation/fpga/dfl.rst ?

Overall, patchset looks good.

Tom

[PATCH 0/2] UIO support for dfl devices

[Xu Yilun]

This patchset supports some dfl device drivers written in userspace.

The usage is like:

 # echo dfl_dev.1 > /sys/bus/dfl/drivers//unbind
 # echo dfl-uio-pdev > /sys/bus/dfl/devices/dfl_dev.1/driver_override
 # echo dfl_dev.1 > /sys/bus/dfl/drivers_probe


Xu Yilun (2):
  fpga: dfl: add driver_override support
  fpga: dfl: add the userspace I/O device support for DFL devices

 Documentation/ABI/testing/sysfs-bus-dfl | 28 +--
 drivers/fpga/Kconfig| 10 
 drivers/fpga/Makefile   |  1 +
 drivers/fpga/dfl-uio-pdev.c | 83 +
 drivers/fpga/dfl.c  | 54 -
 include/linux/dfl.h |  2 +
 6 files changed, 173 insertions(+), 5 deletions(-)
 create mode 100644 drivers/fpga/dfl-uio-pdev.c

-- 
2.7.4