Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-11 Thread Gwendal Grignou
On Fri, Mar 8, 2019 at 11:30 AM Rajat Jain wrote: > > On Fri, Mar 8, 2019 at 12:57 AM Hans de Goede wrote: > > > > Hi, > > > > On 08-03-19 01:04, Srinivas Pandruvada wrote: > > > On Thu, 2019-03-07 at 15:07 -0800, Rajat Jain wrote: > > >> Hello, > > >> > > >> On Thu, Mar 7, 2019 at 12:37 PM Hans

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-08 Thread Rajat Jain
On Fri, Mar 8, 2019 at 12:57 AM Hans de Goede wrote: > > Hi, > > On 08-03-19 01:04, Srinivas Pandruvada wrote: > > On Thu, 2019-03-07 at 15:07 -0800, Rajat Jain wrote: > >> Hello, > >> > >> On Thu, Mar 7, 2019 at 12:37 PM Hans de Goede > >> wrote: > >>> > >>> Hi, > >>> > >>> On 07-03-19 21:27,

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-08 Thread Hans de Goede
Hi, On 08-03-19 01:04, Srinivas Pandruvada wrote: On Thu, 2019-03-07 at 15:07 -0800, Rajat Jain wrote: Hello, On Thu, Mar 7, 2019 at 12:37 PM Hans de Goede wrote: Hi, On 07-03-19 21:27, Gwendal Grignou wrote: Srinivas, I am looking at problem on a laptop machine that suspends to S01x,

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-07 Thread Srinivas Pandruvada
On Thu, 2019-03-07 at 15:07 -0800, Rajat Jain wrote: > Hello, > > On Thu, Mar 7, 2019 at 12:37 PM Hans de Goede > wrote: > > > > Hi, > > > > On 07-03-19 21:27, Gwendal Grignou wrote: > > > Srinivas, > > > > > > I am looking at problem on a laptop machine that suspends to > > > S01x, but > > >

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-07 Thread Rajat Jain
Hello, On Thu, Mar 7, 2019 at 12:37 PM Hans de Goede wrote: > > Hi, > > On 07-03-19 21:27, Gwendal Grignou wrote: > > Srinivas, > > > > I am looking at problem on a laptop machine that suspends to S01x, but > > link_management is set to max_performance, because the machine is > > connected to a

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-07 Thread Hans de Goede
Hi, On 07-03-19 21:27, Gwendal Grignou wrote: Srinivas, I am looking at problem on a laptop machine that suspends to S01x, but link_management is set to max_performance, because the machine is connected to a charger. What is setting it to max_performance when charging? I assume chrome-os is

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-07 Thread Gwendal Grignou
Srinivas, I am looking at problem on a laptop machine that suspends to S01x, but link_management is set to max_performance, because the machine is connected to a charger. Given DVLSP must be set before the laptop suspends ["""One of the requirement for modern x86 system to enter lowest power mode

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Tejun Heo
On Mon, Jul 30, 2018 at 05:26:45PM +0200, Hans de Goede wrote: > Hi, > > On 30-07-18 17:22, Tejun Heo wrote: > >On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote: > >>Hi Tejan, > >> > >>On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: > >>>Some minor fixes to be

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Tejun Heo
On Mon, Jul 30, 2018 at 05:26:45PM +0200, Hans de Goede wrote: > Hi, > > On 30-07-18 17:22, Tejun Heo wrote: > >On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote: > >>Hi Tejan, > >> > >>On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: > >>>Some minor fixes to be

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Hans de Goede
Hi, On 30-07-18 17:22, Tejun Heo wrote: On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote: Hi Tejan, On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: Some minor fixes to be able to correctly set devslp register to optimize power. Srinivas Pandruvada (2):

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Hans de Goede
Hi, On 30-07-18 17:22, Tejun Heo wrote: On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote: Hi Tejan, On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: Some minor fixes to be able to correctly set devslp register to optimize power. Srinivas Pandruvada (2):

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Tejun Heo
On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote: > Hi Tejan, > > On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: > > Some minor fixes to be able to correctly set devslp register > > to optimize power. > > > > Srinivas Pandruvada (2): > > ata: libahci: Correct

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Tejun Heo
On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote: > Hi Tejan, > > On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: > > Some minor fixes to be able to correctly set devslp register > > to optimize power. > > > > Srinivas Pandruvada (2): > > ata: libahci: Correct

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Srinivas Pandruvada
Hi Tejan, On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: > Some minor fixes to be able to correctly set devslp register > to optimize power. > > Srinivas Pandruvada (2): > ata: libahci: Correct setting of DEVSLP register > ata: libahci: Allow reconfigure of DEVSLP register >

Re: [PATCH 0/2] ata: libahci: devslp fixes

2018-07-30 Thread Srinivas Pandruvada
Hi Tejan, On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote: > Some minor fixes to be able to correctly set devslp register > to optimize power. > > Srinivas Pandruvada (2): > ata: libahci: Correct setting of DEVSLP register > ata: libahci: Allow reconfigure of DEVSLP register >

[PATCH 0/2] ata: libahci: devslp fixes

2018-07-02 Thread Srinivas Pandruvada
Some minor fixes to be able to correctly set devslp register to optimize power. Srinivas Pandruvada (2): ata: libahci: Correct setting of DEVSLP register ata: libahci: Allow reconfigure of DEVSLP register drivers/ata/libahci.c | 20 1 file changed, 12 insertions(+), 8

[PATCH 0/2] ata: libahci: devslp fixes

2018-07-02 Thread Srinivas Pandruvada
Some minor fixes to be able to correctly set devslp register to optimize power. Srinivas Pandruvada (2): ata: libahci: Correct setting of DEVSLP register ata: libahci: Allow reconfigure of DEVSLP register drivers/ata/libahci.c | 20 1 file changed, 12 insertions(+), 8