Re: [PATCH 0/2] kthread: make struct kthread kmalloc'ed

2016-10-28 Thread Thomas Gleixner
On Fri, 28 Oct 2016, Oleg Nesterov wrote: > On 10/26, Thomas Gleixner wrote: > > > Be careful with anonymous unions. There are a few pitfalls with older > > compilers. That's why I said make it a proper union and fixup the 5 usage > > sites. > > Ah. Then I'd prefer to do this later or in a

Re: [PATCH 0/2] kthread: make struct kthread kmalloc'ed

2016-10-28 Thread Thomas Gleixner
On Fri, 28 Oct 2016, Oleg Nesterov wrote: > On 10/26, Thomas Gleixner wrote: > > > Be careful with anonymous unions. There are a few pitfalls with older > > compilers. That's why I said make it a proper union and fixup the 5 usage > > sites. > > Ah. Then I'd prefer to do this later or in a

[PATCH 0/2] kthread: make struct kthread kmalloc'ed

2016-10-28 Thread Oleg Nesterov
Sorry for delay, I was distracted... On 10/26, Thomas Gleixner wrote: > > On Wed, 26 Oct 2016, Oleg Nesterov wrote: > > On 10/26, Thomas Gleixner wrote: > > > > > > On Wed, 26 Oct 2016, Oleg Nesterov wrote: > > > > +static inline void set_kthread_struct(void *kthread) > > > > +{ > > > > +

[PATCH 0/2] kthread: make struct kthread kmalloc'ed

2016-10-28 Thread Oleg Nesterov
Sorry for delay, I was distracted... On 10/26, Thomas Gleixner wrote: > > On Wed, 26 Oct 2016, Oleg Nesterov wrote: > > On 10/26, Thomas Gleixner wrote: > > > > > > On Wed, 26 Oct 2016, Oleg Nesterov wrote: > > > > +static inline void set_kthread_struct(void *kthread) > > > > +{ > > > > +