Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 18:50:32 -0700 "Joel Fernandes (Google)" wrote: > > -0 [000] ...1 0.00: initcall_level: level=console > > -0 [000] ...1 0.00: initcall_start: > > func=con_init+0x0/0x224 > > -0 [000] ...1 0.00: initcall_finish: > >

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 18:50:32 -0700 "Joel Fernandes (Google)" wrote: > > -0 [000] ...1 0.00: initcall_level: level=console > > -0 [000] ...1 0.00: initcall_start: > > func=con_init+0x0/0x224 > > -0 [000] ...1 0.00: initcall_finish: > > func=con_init+0x0/0x224

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Joel Fernandes (Google)
Hi Steve, On Fri, Mar 23, 2018 at 8:02 AM, Steven Rostedt wrote: > A while ago we had a boot tracer. But it was eventually removed: > commit 30dbb20e68e6f ("tracing: Remove boot tracer"). > > The rational was because there is already a initcall_debug boot option > that

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Joel Fernandes (Google)
Hi Steve, On Fri, Mar 23, 2018 at 8:02 AM, Steven Rostedt wrote: > A while ago we had a boot tracer. But it was eventually removed: > commit 30dbb20e68e6f ("tracing: Remove boot tracer"). > > The rational was because there is already a initcall_debug boot option > that causes printk()s of all

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 10:42:42 +0200 Peter Zijlstra wrote: > On Fri, Mar 23, 2018 at 04:04:41PM -0400, Steven Rostedt wrote: > > I would even argue that we remove the printks and use the trace events > > instead. There's already an option to make trace events be sent to > >

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Steven Rostedt
On Mon, 26 Mar 2018 10:42:42 +0200 Peter Zijlstra wrote: > On Fri, Mar 23, 2018 at 04:04:41PM -0400, Steven Rostedt wrote: > > I would even argue that we remove the printks and use the trace events > > instead. There's already an option to make trace events be sent to > > printk(). I could have

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Peter Zijlstra
On Fri, Mar 23, 2018 at 04:04:41PM -0400, Steven Rostedt wrote: > I would even argue that we remove the printks and use the trace events > instead. There's already an option to make trace events be sent to > printk(). I could have initcall_debug enable the trace events and send > them to printk.

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-26 Thread Peter Zijlstra
On Fri, Mar 23, 2018 at 04:04:41PM -0400, Steven Rostedt wrote: > I would even argue that we remove the printks and use the trace events > instead. There's already an option to make trace events be sent to > printk(). I could have initcall_debug enable the trace events and send > them to printk.

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-23 Thread Steven Rostedt
On Fri, 23 Mar 2018 12:50:16 -0700 Andrew Morton wrote: > On Fri, 23 Mar 2018 11:02:41 -0400 Steven Rostedt wrote: > > > A while ago we had a boot tracer. But it was eventually removed: > > commit 30dbb20e68e6f ("tracing: Remove boot tracer"). >

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-23 Thread Steven Rostedt
On Fri, 23 Mar 2018 12:50:16 -0700 Andrew Morton wrote: > On Fri, 23 Mar 2018 11:02:41 -0400 Steven Rostedt wrote: > > > A while ago we had a boot tracer. But it was eventually removed: > > commit 30dbb20e68e6f ("tracing: Remove boot tracer"). > > > > The rational was because there is

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-23 Thread Andrew Morton
On Fri, 23 Mar 2018 11:02:41 -0400 Steven Rostedt wrote: > A while ago we had a boot tracer. But it was eventually removed: > commit 30dbb20e68e6f ("tracing: Remove boot tracer"). > > The rational was because there is already a initcall_debug boot option > that causes

Re: [PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-23 Thread Andrew Morton
On Fri, 23 Mar 2018 11:02:41 -0400 Steven Rostedt wrote: > A while ago we had a boot tracer. But it was eventually removed: > commit 30dbb20e68e6f ("tracing: Remove boot tracer"). > > The rational was because there is already a initcall_debug boot option > that causes printk()s of all the

[PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-23 Thread Steven Rostedt
A while ago we had a boot tracer. But it was eventually removed: commit 30dbb20e68e6f ("tracing: Remove boot tracer"). The rational was because there is already a initcall_debug boot option that causes printk()s of all the initcall functions. The problem with the initcall_debug option is that

[PATCH 0/3] [RFC] init, tracing: Add initcall trace events

2018-03-23 Thread Steven Rostedt
A while ago we had a boot tracer. But it was eventually removed: commit 30dbb20e68e6f ("tracing: Remove boot tracer"). The rational was because there is already a initcall_debug boot option that causes printk()s of all the initcall functions. The problem with the initcall_debug option is that