Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Laszlo Papp
On Wed, Jan 8, 2014 at 5:22 PM, Lee Jones wrote: > On Wed, 08 Jan 2014, Laszlo Papp wrote: > >> In other words, I really do not know what format you prefer for design >> review. >> >> Apparently, not as previously requested, so please tell me what format >> one _should_ submit design reviews in.

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Lee Jones
On Wed, 08 Jan 2014, Laszlo Papp wrote: > In other words, I really do not know what format you prefer for design review. > > Apparently, not as previously requested, so please tell me what format > one _should_ submit design reviews in. > > I personally still think that submitting "pseudo-code"

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Laszlo Papp
In other words, I really do not know what format you prefer for design review. Apparently, not as previously requested, so please tell me what format one _should_ submit design reviews in. I personally still think that submitting "pseudo-code" is a good way of it if it is clearly marked so like

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Laszlo Papp
As the cover page wrote, this was *not* meant to be a good code because I wanted to get design feedback. I have asked that before, too, and you claimed to send some code representing the idea. I have just done that. I find it weird to get design feedback _after_ doing all the coding. Anyway, if

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Laszlo Papp
As the cover page wrote, this was *not* meant to be a good code because I wanted to get design feedback. I have asked that before, too, and you claimed to send some code representing the idea. I have just done that. I find it weird to get design feedback _after_ doing all the coding. Anyway, if

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Laszlo Papp
In other words, I really do not know what format you prefer for design review. Apparently, not as previously requested, so please tell me what format one _should_ submit design reviews in. I personally still think that submitting pseudo-code is a good way of it if it is clearly marked so like in

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Lee Jones
On Wed, 08 Jan 2014, Laszlo Papp wrote: In other words, I really do not know what format you prefer for design review. Apparently, not as previously requested, so please tell me what format one _should_ submit design reviews in. I personally still think that submitting pseudo-code is a

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-08 Thread Laszlo Papp
On Wed, Jan 8, 2014 at 5:22 PM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 08 Jan 2014, Laszlo Papp wrote: In other words, I really do not know what format you prefer for design review. Apparently, not as previously requested, so please tell me what format one _should_ submit design

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-07 Thread Lee Jones
Don't send private, off-list emails for poking or anything else related to upstreamming patches. > Important text here later. It is now just an attempt to get some feedback > about > the design of the new features. This set has only been compilation tested, and > has many errors with

Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2014-01-07 Thread Lee Jones
Don't send private, off-list emails for poking or anything else related to upstreamming patches. Important text here later. It is now just an attempt to get some feedback about the design of the new features. This set has only been compilation tested, and has many errors with checkpatch.pl,

[PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2013-12-23 Thread Laszlo Papp
Important text here later. It is now just an attempt to get some feedback about the design of the new features. This set has only been compilation tested, and has many errors with checkpatch.pl, et al. Really, the point is only to get feedback about the direction, as there has been a lot of paid

[PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

2013-12-23 Thread Laszlo Papp
Important text here later. It is now just an attempt to get some feedback about the design of the new features. This set has only been compilation tested, and has many errors with checkpatch.pl, et al. Really, the point is only to get feedback about the direction, as there has been a lot of paid