Re: [PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-26 Thread Michel Lespinasse
On Mon, Nov 26, 2012 at 5:16 PM, Sasha Levin wrote: > I've built today's -next, and got the following BUG pretty quickly (2-3 > hours): > > [ 1556.479284] BUG: unable to handle kernel paging request at 00412000 > [ 1556.480036] IP: [] validate_mm+0x34/0x130 > [ 1556.480036] PGD 31739067

Re: [PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-26 Thread Sasha Levin
On 11/12/2012 03:54 PM, Sasha Levin wrote: > On 11/12/2012 06:51 AM, Michel Lespinasse wrote: >> Using the trinity fuzzer, Sasha Levin uncovered a case where >> rb_subtree_gap wasn't correctly updated. >> >> Digging into this, the root cause was that vma insertions and removals >> require both an

Re: [PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-26 Thread Sasha Levin
On 11/12/2012 03:54 PM, Sasha Levin wrote: On 11/12/2012 06:51 AM, Michel Lespinasse wrote: Using the trinity fuzzer, Sasha Levin uncovered a case where rb_subtree_gap wasn't correctly updated. Digging into this, the root cause was that vma insertions and removals require both an rbtree

Re: [PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-26 Thread Michel Lespinasse
On Mon, Nov 26, 2012 at 5:16 PM, Sasha Levin levinsasha...@gmail.com wrote: I've built today's -next, and got the following BUG pretty quickly (2-3 hours): [ 1556.479284] BUG: unable to handle kernel paging request at 00412000 [ 1556.480036] IP: [81238184]

Re: [PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-12 Thread Sasha Levin
On 11/12/2012 06:51 AM, Michel Lespinasse wrote: > Using the trinity fuzzer, Sasha Levin uncovered a case where > rb_subtree_gap wasn't correctly updated. > > Digging into this, the root cause was that vma insertions and removals > require both an rbtree insert or erase operation (which may

[PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-12 Thread Michel Lespinasse
Using the trinity fuzzer, Sasha Levin uncovered a case where rb_subtree_gap wasn't correctly updated. Digging into this, the root cause was that vma insertions and removals require both an rbtree insert or erase operation (which may trigger tree rotations), and an update of the next vma's gap

[PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-12 Thread Michel Lespinasse
Using the trinity fuzzer, Sasha Levin uncovered a case where rb_subtree_gap wasn't correctly updated. Digging into this, the root cause was that vma insertions and removals require both an rbtree insert or erase operation (which may trigger tree rotations), and an update of the next vma's gap

Re: [PATCH 0/3] fix missing rb_subtree_gap updates on vma insert/erase

2012-11-12 Thread Sasha Levin
On 11/12/2012 06:51 AM, Michel Lespinasse wrote: Using the trinity fuzzer, Sasha Levin uncovered a case where rb_subtree_gap wasn't correctly updated. Digging into this, the root cause was that vma insertions and removals require both an rbtree insert or erase operation (which may trigger