RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 30 October 2015 13:32, Bjorn wrote:
> On Fri, Oct 30, 2015 at 09:00:20AM +, Phil Edworthy wrote:
> > Hi Bjorn,
> >
> > On 30 October 2015 07:24, Phil wrote:
> > > On 30 October 2015 07:19, Phil wrote
> > > > On 29 October 2015 23:03, Bjorn wrote:
> > > > > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > > > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > > > > Hi Wolfram,
> > > > > > >
> > > > > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for
> the
> > > > > Salvator-X
> > > > > > > > board on
> > > > > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,
> > > rcar-
> > > > > 3.0.2
> > > > > > > > tag along
> > > > > > > > > with some patches from colleagues. I hadn't noticed this 
> > > > > > > > > patch:
> > > > > > > >
> > > > > > > > Thanks! Any plans for pushing this upstream? We will have the 
> > > > > > > > build
> > > error
> > > > > > > > otherwise...
> > > > > > > After some digging, that patch won't be accepted upstream. I'm
> looking
> > > into
> > > > > how the
> > > > > > > driver can be modified so it doesn't need to call this, but I 
> > > > > > > don't expect
> a
> > > > small
> > > > > or
> > > > > > > imminent fix.
> > > > > >
> > > > > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > > > > prevent having a final release with a build error.
> > > > >
> > > > > I'm thinking I should drop my pci/host-rcar branch until we
> > > > > have a fix for this.  It currently contains:
> > > > >
> > > > >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> > > > >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> > > > >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct
> hw_pci
> > > > >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> > > > >
> > > > > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > > > > so we really don't have much time to sort this out.
> > > > The simple thing is to re-add Geert's patch to stop this driver being 
> > > > built for
> > > > arm64.
> > > Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/
> > It's worth mentioning that Geert's patch stops both the rcar-pcie driver 
> > and the
> > rcar-pci-gen2 driver from being built on arm64 due to build failures for 
> > both of
> > them. The rcar-pci-gen2 driver is not for R-Car Gen3 devices, and so should 
> > not
> > be built for arm64. The rcar-pcie driver will be used on R-Car Gen3 devices.
> >
> > So if we don't use Geert's patch, I need to fix the rcar-pcie driver so it 
> > doesn't
> > use pci_ioremap_io(), _and_ fix Kconfig so that the rcar-pci-gen2 driver 
> > doesn't
> > get built on arm64.
> > Let's just use Geert's patch for now.
> 
> OK, I re-added Geert's patch.  I split it into two, one for
> rcar-pci-gen2 and another for rcar-pcie, to help me keep things
> straight.  If I understand correctly,
> 
>   - rcar-pci-gen2 depends on the ARM-specific pci_sys_data, and I
> don't have anything queued to address that.
Correct, but you don't need anything other than Geert's patch to
ensure it's not built for arm64.

>   - rcar-pcie depended on the ARM-specific pci_sys_data and
> pci_ioremap_io().  Your patches remove the pci_sys_data
> dependency, and it sounds like future changes will remove the
> pci_ioremap_io() dependency.
That's correct, hopefully I'll have a patch shortly.
Thanks for taking care of this.

 
> The result is in my pci/host-rcar branch:
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-rcar
I haven't tested this yet, but I have looked them over and they look ok.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 30 October 2015 13:32, Bjorn wrote:
> On Fri, Oct 30, 2015 at 09:00:20AM +, Phil Edworthy wrote:
> > Hi Bjorn,
> >
> > On 30 October 2015 07:24, Phil wrote:
> > > On 30 October 2015 07:19, Phil wrote
> > > > On 29 October 2015 23:03, Bjorn wrote:
> > > > > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > > > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > > > > Hi Wolfram,
> > > > > > >
> > > > > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for
> the
> > > > > Salvator-X
> > > > > > > > board on
> > > > > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,
> > > rcar-
> > > > > 3.0.2
> > > > > > > > tag along
> > > > > > > > > with some patches from colleagues. I hadn't noticed this 
> > > > > > > > > patch:
> > > > > > > >
> > > > > > > > Thanks! Any plans for pushing this upstream? We will have the 
> > > > > > > > build
> > > error
> > > > > > > > otherwise...
> > > > > > > After some digging, that patch won't be accepted upstream. I'm
> looking
> > > into
> > > > > how the
> > > > > > > driver can be modified so it doesn't need to call this, but I 
> > > > > > > don't expect
> a
> > > > small
> > > > > or
> > > > > > > imminent fix.
> > > > > >
> > > > > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > > > > prevent having a final release with a build error.
> > > > >
> > > > > I'm thinking I should drop my pci/host-rcar branch until we
> > > > > have a fix for this.  It currently contains:
> > > > >
> > > > >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> > > > >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> > > > >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct
> hw_pci
> > > > >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> > > > >
> > > > > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > > > > so we really don't have much time to sort this out.
> > > > The simple thing is to re-add Geert's patch to stop this driver being 
> > > > built for
> > > > arm64.
> > > Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/
> > It's worth mentioning that Geert's patch stops both the rcar-pcie driver 
> > and the
> > rcar-pci-gen2 driver from being built on arm64 due to build failures for 
> > both of
> > them. The rcar-pci-gen2 driver is not for R-Car Gen3 devices, and so should 
> > not
> > be built for arm64. The rcar-pcie driver will be used on R-Car Gen3 devices.
> >
> > So if we don't use Geert's patch, I need to fix the rcar-pcie driver so it 
> > doesn't
> > use pci_ioremap_io(), _and_ fix Kconfig so that the rcar-pci-gen2 driver 
> > doesn't
> > get built on arm64.
> > Let's just use Geert's patch for now.
> 
> OK, I re-added Geert's patch.  I split it into two, one for
> rcar-pci-gen2 and another for rcar-pcie, to help me keep things
> straight.  If I understand correctly,
> 
>   - rcar-pci-gen2 depends on the ARM-specific pci_sys_data, and I
> don't have anything queued to address that.
Correct, but you don't need anything other than Geert's patch to
ensure it's not built for arm64.

>   - rcar-pcie depended on the ARM-specific pci_sys_data and
> pci_ioremap_io().  Your patches remove the pci_sys_data
> dependency, and it sounds like future changes will remove the
> pci_ioremap_io() dependency.
That's correct, hopefully I'll have a patch shortly.
Thanks for taking care of this.

 
> The result is in my pci/host-rcar branch:
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-rcar
I haven't tested this yet, but I have looked them over and they look ok.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

On Fri, Oct 30, 2015 at 09:00:20AM +, Phil Edworthy wrote:
> Hi Bjorn,
> 
> On 30 October 2015 07:24, Phil wrote:
> > On 30 October 2015 07:19, Phil wrote
> > > On 29 October 2015 23:03, Bjorn wrote:
> > > > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > > > Hi Wolfram,
> > > > > >
> > > > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for 
> > > > > > > > the
> > > > Salvator-X
> > > > > > > board on
> > > > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,
> > rcar-
> > > > 3.0.2
> > > > > > > tag along
> > > > > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > > > > >
> > > > > > > Thanks! Any plans for pushing this upstream? We will have the 
> > > > > > > build
> > error
> > > > > > > otherwise...
> > > > > > After some digging, that patch won't be accepted upstream. I'm 
> > > > > > looking
> > into
> > > > how the
> > > > > > driver can be modified so it doesn't need to call this, but I don't 
> > > > > > expect a
> > > small
> > > > or
> > > > > > imminent fix.
> > > > >
> > > > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > > > prevent having a final release with a build error.
> > > >
> > > > I'm thinking I should drop my pci/host-rcar branch until we
> > > > have a fix for this.  It currently contains:
> > > >
> > > >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> > > >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> > > >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct 
> > > > hw_pci
> > > >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> > > >
> > > > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > > > so we really don't have much time to sort this out.
> > > The simple thing is to re-add Geert's patch to stop this driver being 
> > > built for
> > > arm64.
> > Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/
> It's worth mentioning that Geert's patch stops both the rcar-pcie driver and 
> the
> rcar-pci-gen2 driver from being built on arm64 due to build failures for both 
> of
> them. The rcar-pci-gen2 driver is not for R-Car Gen3 devices, and so should 
> not
> be built for arm64. The rcar-pcie driver will be used on R-Car Gen3 devices.
> 
> So if we don't use Geert's patch, I need to fix the rcar-pcie driver so it 
> doesn't
> use pci_ioremap_io(), _and_ fix Kconfig so that the rcar-pci-gen2 driver 
> doesn't
> get built on arm64. 
> Let's just use Geert's patch for now.

OK, I re-added Geert's patch.  I split it into two, one for
rcar-pci-gen2 and another for rcar-pcie, to help me keep things
straight.  If I understand correctly,

  - rcar-pci-gen2 depends on the ARM-specific pci_sys_data, and I
don't have anything queued to address that.

  - rcar-pcie depended on the ARM-specific pci_sys_data and
pci_ioremap_io().  Your patches remove the pci_sys_data
dependency, and it sounds like future changes will remove the
pci_ioremap_io() dependency.

The result is in my pci/host-rcar branch:
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-rcar

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

> Hopefully, Geert's patch will be applied to avoid build errors in both the
> rcar-pcie and rcar-pci-gen2 (internal USB bridge) drivers. Meanwhile I'll fix
> the rcar-pcie driver properly for arm64.

Thanks for taking care.

> > What MSI problem?
> I was told that rcar pcie on v4.3-rc5 had an issue with MSI.

Okay, we'll see. I only have remote access to a Koelsch board, but my
own Salvator. And a USB3 PCIE card. That would be my primary test setup.

> > And can't you send the DTS patches as RFC so I can add some testing?
> Sure, though what tree? As I mentioned above, next doesn't have
> shmobile arm64 yet.

I use renesas-drivers:

git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git 
renesas-drivers-2015-10-27-v4.3-rc7

Thanks,

   Wolfram



signature.asc
Description: Digital signature

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Wolfram,

On 29 October 2015 18:48, Wolfram wrote:
> On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > Hi Wolfram,
> >
> > On 29 October 2015 16:40, Wolfram wrote:
> > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> Salvator-X
> > > board on
> > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > rcar-
> 3.0.2
> > > tag along
> > > > with some patches from colleagues. I hadn't noticed this patch:
> > >
> > > Thanks! Any plans for pushing this upstream? We will have the build error
> > > otherwise...
> > After some digging, that patch won't be accepted upstream. I'm looking into
> how the
> > driver can be modified so it doesn't need to call this, but I don't expect 
> > a small
> or
> > imminent fix.
> 
> Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> prevent having a final release with a build error.
Hopefully, Geert's patch will be applied to avoid build errors in both the
rcar-pcie and rcar-pci-gen2 (internal USB bridge) drivers. Meanwhile I'll fix
the rcar-pcie driver properly for arm64.


> > > > > Any news if this is really HW related?
> > > > I found out that the PCIe controller HW only supports 32-bit AXI bus
> addresses,
> > > so it
> > > > works fine if you limit the available memory. The driver will need some 
> > > > work
> to
> > > use
> > > > the IPMMU at some point.
> > >
> > > Ah, okay.
> > >
> > > Can you send the dts patches, too? I checked the BSP this time, but to
> > > no avail...
> > I will once I sort out the arm64 IO resources problem and the MSI problem.
> 
> What MSI problem?
I was told that rcar pcie on v4.3-rc5 had an issue with MSI. I've since checked
That both v4.3-rc7 and next work ok out of the box on the Koelsch board.
There are some problems with next (mstp related), but it doesn't stop the
board booting and being able to test pcie. Since shmobile arm64 is not in
next yet, I have not checked this.
 
> And can't you send the DTS patches as RFC so I can add some testing?
Sure, though what tree? As I mentioned above, next doesn't have
shmobile arm64 yet.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 30 October 2015 07:24, Phil wrote:
> On 30 October 2015 07:19, Phil wrote
> > On 29 October 2015 23:03, Bjorn wrote:
> > > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > > Hi Wolfram,
> > > > >
> > > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> > > Salvator-X
> > > > > > board on
> > > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,
> rcar-
> > > 3.0.2
> > > > > > tag along
> > > > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > > > >
> > > > > > Thanks! Any plans for pushing this upstream? We will have the build
> error
> > > > > > otherwise...
> > > > > After some digging, that patch won't be accepted upstream. I'm looking
> into
> > > how the
> > > > > driver can be modified so it doesn't need to call this, but I don't 
> > > > > expect a
> > small
> > > or
> > > > > imminent fix.
> > > >
> > > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > > prevent having a final release with a build error.
> > >
> > > I'm thinking I should drop my pci/host-rcar branch until we
> > > have a fix for this.  It currently contains:
> > >
> > >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> > >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> > >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
> > >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> > >
> > > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > > so we really don't have much time to sort this out.
> > The simple thing is to re-add Geert's patch to stop this driver being built 
> > for
> > arm64.
> Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/
It's worth mentioning that Geert's patch stops both the rcar-pcie driver and the
rcar-pci-gen2 driver from being built on arm64 due to build failures for both of
them. The rcar-pci-gen2 driver is not for R-Car Gen3 devices, and so should not
be built for arm64. The rcar-pcie driver will be used on R-Car Gen3 devices.

So if we don't use Geert's patch, I need to fix the rcar-pcie driver so it 
doesn't
use pci_ioremap_io(), _and_ fix Kconfig so that the rcar-pci-gen2 driver doesn't
get built on arm64. 
Let's just use Geert's patch for now.

Btw, I saw no build breakages on next as SHMOBILE is currently not included in
arm64.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 30 October 2015 07:19, Phil wrote
> On 29 October 2015 23:03, Bjorn wrote:
> > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > Hi Wolfram,
> > > >
> > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> > Salvator-X
> > > > > board on
> > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > > > rcar-
> > 3.0.2
> > > > > tag along
> > > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > > >
> > > > > Thanks! Any plans for pushing this upstream? We will have the build 
> > > > > error
> > > > > otherwise...
> > > > After some digging, that patch won't be accepted upstream. I'm looking 
> > > > into
> > how the
> > > > driver can be modified so it doesn't need to call this, but I don't 
> > > > expect a
> small
> > or
> > > > imminent fix.
> > >
> > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > prevent having a final release with a build error.
> >
> > I'm thinking I should drop my pci/host-rcar branch until we
> > have a fix for this.  It currently contains:
> >
> >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
> >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> >
> > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > so we really don't have much time to sort this out.
> The simple thing is to re-add Geert's patch to stop this driver being built 
> for
> arm64.
Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 29 October 2015 23:03, Bjorn wrote:
> On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > Hi Wolfram,
> > >
> > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> Salvator-X
> > > > board on
> > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > > rcar-
> 3.0.2
> > > > tag along
> > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > >
> > > > Thanks! Any plans for pushing this upstream? We will have the build 
> > > > error
> > > > otherwise...
> > > After some digging, that patch won't be accepted upstream. I'm looking 
> > > into
> how the
> > > driver can be modified so it doesn't need to call this, but I don't 
> > > expect a small
> or
> > > imminent fix.
> >
> > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > prevent having a final release with a build error.
> 
> I'm thinking I should drop my pci/host-rcar branch until we
> have a fix for this.  It currently contains:
> 
>   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
>   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
>   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
>   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> 
> Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> so we really don't have much time to sort this out.
The simple thing is to re-add Geert's patch to stop this driver being built for 
arm64.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 29 October 2015 23:03, Bjorn wrote:
> On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > Hi Wolfram,
> > >
> > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> Salvator-X
> > > > board on
> > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > > rcar-
> 3.0.2
> > > > tag along
> > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > >
> > > > Thanks! Any plans for pushing this upstream? We will have the build 
> > > > error
> > > > otherwise...
> > > After some digging, that patch won't be accepted upstream. I'm looking 
> > > into
> how the
> > > driver can be modified so it doesn't need to call this, but I don't 
> > > expect a small
> or
> > > imminent fix.
> >
> > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > prevent having a final release with a build error.
> 
> I'm thinking I should drop my pci/host-rcar branch until we
> have a fix for this.  It currently contains:
> 
>   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
>   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
>   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
>   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> 
> Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> so we really don't have much time to sort this out.
The simple thing is to re-add Geert's patch to stop this driver being built for 
arm64.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 30 October 2015 07:24, Phil wrote:
> On 30 October 2015 07:19, Phil wrote
> > On 29 October 2015 23:03, Bjorn wrote:
> > > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > > Hi Wolfram,
> > > > >
> > > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> > > Salvator-X
> > > > > > board on
> > > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,
> rcar-
> > > 3.0.2
> > > > > > tag along
> > > > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > > > >
> > > > > > Thanks! Any plans for pushing this upstream? We will have the build
> error
> > > > > > otherwise...
> > > > > After some digging, that patch won't be accepted upstream. I'm looking
> into
> > > how the
> > > > > driver can be modified so it doesn't need to call this, but I don't 
> > > > > expect a
> > small
> > > or
> > > > > imminent fix.
> > > >
> > > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > > prevent having a final release with a build error.
> > >
> > > I'm thinking I should drop my pci/host-rcar branch until we
> > > have a fix for this.  It currently contains:
> > >
> > >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> > >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> > >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
> > >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> > >
> > > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > > so we really don't have much time to sort this out.
> > The simple thing is to re-add Geert's patch to stop this driver being built 
> > for
> > arm64.
> Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/
It's worth mentioning that Geert's patch stops both the rcar-pcie driver and the
rcar-pci-gen2 driver from being built on arm64 due to build failures for both of
them. The rcar-pci-gen2 driver is not for R-Car Gen3 devices, and so should not
be built for arm64. The rcar-pcie driver will be used on R-Car Gen3 devices.

So if we don't use Geert's patch, I need to fix the rcar-pcie driver so it 
doesn't
use pci_ioremap_io(), _and_ fix Kconfig so that the rcar-pci-gen2 driver doesn't
get built on arm64. 
Let's just use Geert's patch for now.

Btw, I saw no build breakages on next as SHMOBILE is currently not included in
arm64.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 30 October 2015 07:19, Phil wrote
> On 29 October 2015 23:03, Bjorn wrote:
> > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > Hi Wolfram,
> > > >
> > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> > Salvator-X
> > > > > board on
> > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > > > rcar-
> > 3.0.2
> > > > > tag along
> > > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > > >
> > > > > Thanks! Any plans for pushing this upstream? We will have the build 
> > > > > error
> > > > > otherwise...
> > > > After some digging, that patch won't be accepted upstream. I'm looking 
> > > > into
> > how the
> > > > driver can be modified so it doesn't need to call this, but I don't 
> > > > expect a
> small
> > or
> > > > imminent fix.
> > >
> > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > prevent having a final release with a build error.
> >
> > I'm thinking I should drop my pci/host-rcar branch until we
> > have a fix for this.  It currently contains:
> >
> >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
> >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> >
> > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > so we really don't have much time to sort this out.
> The simple thing is to re-add Geert's patch to stop this driver being built 
> for
> arm64.
Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Wolfram,

On 29 October 2015 18:48, Wolfram wrote:
> On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > Hi Wolfram,
> >
> > On 29 October 2015 16:40, Wolfram wrote:
> > > > Ouch, my bad. I have been working with our out-of-tree BSP for the
> Salvator-X
> > > board on
> > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > rcar-
> 3.0.2
> > > tag along
> > > > with some patches from colleagues. I hadn't noticed this patch:
> > >
> > > Thanks! Any plans for pushing this upstream? We will have the build error
> > > otherwise...
> > After some digging, that patch won't be accepted upstream. I'm looking into
> how the
> > driver can be modified so it doesn't need to call this, but I don't expect 
> > a small
> or
> > imminent fix.
> 
> Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> prevent having a final release with a build error.
Hopefully, Geert's patch will be applied to avoid build errors in both the
rcar-pcie and rcar-pci-gen2 (internal USB bridge) drivers. Meanwhile I'll fix
the rcar-pcie driver properly for arm64.


> > > > > Any news if this is really HW related?
> > > > I found out that the PCIe controller HW only supports 32-bit AXI bus
> addresses,
> > > so it
> > > > works fine if you limit the available memory. The driver will need some 
> > > > work
> to
> > > use
> > > > the IPMMU at some point.
> > >
> > > Ah, okay.
> > >
> > > Can you send the dts patches, too? I checked the BSP this time, but to
> > > no avail...
> > I will once I sort out the arm64 IO resources problem and the MSI problem.
> 
> What MSI problem?
I was told that rcar pcie on v4.3-rc5 had an issue with MSI. I've since checked
That both v4.3-rc7 and next work ok out of the box on the Koelsch board.
There are some problems with next (mstp related), but it doesn't stop the
board booting and being able to test pcie. Since shmobile arm64 is not in
next yet, I have not checked this.
 
> And can't you send the DTS patches as RFC so I can add some testing?
Sure, though what tree? As I mentioned above, next doesn't have
shmobile arm64 yet.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

> Hopefully, Geert's patch will be applied to avoid build errors in both the
> rcar-pcie and rcar-pci-gen2 (internal USB bridge) drivers. Meanwhile I'll fix
> the rcar-pcie driver properly for arm64.

Thanks for taking care.

> > What MSI problem?
> I was told that rcar pcie on v4.3-rc5 had an issue with MSI.

Okay, we'll see. I only have remote access to a Koelsch board, but my
own Salvator. And a USB3 PCIE card. That would be my primary test setup.

> > And can't you send the DTS patches as RFC so I can add some testing?
> Sure, though what tree? As I mentioned above, next doesn't have
> shmobile arm64 yet.

I use renesas-drivers:

git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git 
renesas-drivers-2015-10-27-v4.3-rc7

Thanks,

   Wolfram



signature.asc
Description: Digital signature

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

On Fri, Oct 30, 2015 at 09:00:20AM +, Phil Edworthy wrote:
> Hi Bjorn,
> 
> On 30 October 2015 07:24, Phil wrote:
> > On 30 October 2015 07:19, Phil wrote
> > > On 29 October 2015 23:03, Bjorn wrote:
> > > > On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> > > > > On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > > > > > Hi Wolfram,
> > > > > >
> > > > > > On 29 October 2015 16:40, Wolfram wrote:
> > > > > > > > Ouch, my bad. I have been working with our out-of-tree BSP for 
> > > > > > > > the
> > > > Salvator-X
> > > > > > > board on
> > > > > > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,
> > rcar-
> > > > 3.0.2
> > > > > > > tag along
> > > > > > > > with some patches from colleagues. I hadn't noticed this patch:
> > > > > > >
> > > > > > > Thanks! Any plans for pushing this upstream? We will have the 
> > > > > > > build
> > error
> > > > > > > otherwise...
> > > > > > After some digging, that patch won't be accepted upstream. I'm 
> > > > > > looking
> > into
> > > > how the
> > > > > > driver can be modified so it doesn't need to call this, but I don't 
> > > > > > expect a
> > > small
> > > > or
> > > > > > imminent fix.
> > > > >
> > > > > Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> > > > > prevent having a final release with a build error.
> > > >
> > > > I'm thinking I should drop my pci/host-rcar branch until we
> > > > have a fix for this.  It currently contains:
> > > >
> > > >   9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
> > > >   7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
> > > >   4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct 
> > > > hw_pci
> > > >   ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources
> > > >
> > > > Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
> > > > so we really don't have much time to sort this out.
> > > The simple thing is to re-add Geert's patch to stop this driver being 
> > > built for
> > > arm64.
> > Btw, it's this one: https://patchwork.ozlabs.org/patch/512040/
> It's worth mentioning that Geert's patch stops both the rcar-pcie driver and 
> the
> rcar-pci-gen2 driver from being built on arm64 due to build failures for both 
> of
> them. The rcar-pci-gen2 driver is not for R-Car Gen3 devices, and so should 
> not
> be built for arm64. The rcar-pcie driver will be used on R-Car Gen3 devices.
> 
> So if we don't use Geert's patch, I need to fix the rcar-pcie driver so it 
> doesn't
> use pci_ioremap_io(), _and_ fix Kconfig so that the rcar-pci-gen2 driver 
> doesn't
> get built on arm64. 
> Let's just use Geert's patch for now.

OK, I re-added Geert's patch.  I split it into two, one for
rcar-pci-gen2 and another for rcar-pcie, to help me keep things
straight.  If I understand correctly,

  - rcar-pci-gen2 depends on the ARM-specific pci_sys_data, and I
don't have anything queued to address that.

  - rcar-pcie depended on the ARM-specific pci_sys_data and
pci_ioremap_io().  Your patches remove the pci_sys_data
dependency, and it sounds like future changes will remove the
pci_ioremap_io() dependency.

The result is in my pci/host-rcar branch:
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-rcar

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

[-cc Nobuhiro (bouncing)]

On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > Hi Wolfram,
> > 
> > On 29 October 2015 16:40, Wolfram wrote:
> > > > Ouch, my bad. I have been working with our out-of-tree BSP for the 
> > > > Salvator-X
> > > board on
> > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > rcar-3.0.2
> > > tag along
> > > > with some patches from colleagues. I hadn't noticed this patch:
> > > 
> > > Thanks! Any plans for pushing this upstream? We will have the build error
> > > otherwise...
> > After some digging, that patch won't be accepted upstream. I'm looking into 
> > how the
> > driver can be modified so it doesn't need to call this, but I don't expect 
> > a small or
> > imminent fix.
> 
> Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> prevent having a final release with a build error.

I'm thinking I should drop my pci/host-rcar branch until we
have a fix for this.  It currently contains:

  9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
  7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
  4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
  ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources

Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
so we really don't have much time to sort this out.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> Hi Wolfram,
> 
> On 29 October 2015 16:40, Wolfram wrote:
> > > Ouch, my bad. I have been working with our out-of-tree BSP for the 
> > > Salvator-X
> > board on
> > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > rcar-3.0.2
> > tag along
> > > with some patches from colleagues. I hadn't noticed this patch:
> > 
> > Thanks! Any plans for pushing this upstream? We will have the build error
> > otherwise...
> After some digging, that patch won't be accepted upstream. I'm looking into 
> how the
> driver can be modified so it doesn't need to call this, but I don't expect a 
> small or
> imminent fix.

Yes, I'd think so, too. However, a fix for 4.4 would be needed to
prevent having a final release with a build error.

> > > > Any news if this is really HW related?
> > > I found out that the PCIe controller HW only supports 32-bit AXI bus 
> > > addresses,
> > so it
> > > works fine if you limit the available memory. The driver will need some 
> > > work to
> > use
> > > the IPMMU at some point.
> > 
> > Ah, okay.
> > 
> > Can you send the dts patches, too? I checked the BSP this time, but to
> > no avail...
> I will once I sort out the arm64 IO resources problem and the MSI problem.

What MSI problem?

And can't you send the DTS patches as RFC so I can add some testing?



signature.asc
Description: Digital signature

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Wolfram,

On 29 October 2015 16:40, Wolfram wrote:
> > Ouch, my bad. I have been working with our out-of-tree BSP for the 
> > Salvator-X
> board on
> > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > rcar-3.0.2
> tag along
> > with some patches from colleagues. I hadn't noticed this patch:
> 
> Thanks! Any plans for pushing this upstream? We will have the build error
> otherwise...
After some digging, that patch won't be accepted upstream. I'm looking into how 
the
driver can be modified so it doesn't need to call this, but I don't expect a 
small or
imminent fix.

> > > Any news if this is really HW related?
> > I found out that the PCIe controller HW only supports 32-bit AXI bus 
> > addresses,
> so it
> > works fine if you limit the available memory. The driver will need some 
> > work to
> use
> > the IPMMU at some point.
> 
> Ah, okay.
> 
> Can you send the dts patches, too? I checked the BSP this time, but to
> no avail...
I will once I sort out the arm64 IO resources problem and the MSI problem.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

> Ouch, my bad. I have been working with our out-of-tree BSP for the Salvator-X 
> board on
> http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> rcar-3.0.2 tag along
> with some patches from colleagues. I hadn't noticed this patch:

Thanks! Any plans for pushing this upstream? We will have the build error
otherwise...

> > Any news if this is really HW related?
> I found out that the PCIe controller HW only supports 32-bit AXI bus 
> addresses, so it
> works fine if you limit the available memory. The driver will need some work 
> to use
> the IPMMU at some point.

Ah, okay.

Can you send the dts patches, too? I checked the BSP this time, but to
no avail...



signature.asc
Description: Digital signature

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Wolfram,

On 29 October 2015 12:38, Wolfram wrote:
> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> 
> > I've tested these on ARM (Koelsch board), and it works fine.
> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> 
> I wanted to test these patches on arm64 as well, but even after merging
> pci-next, I still get:
> 
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_setup':
> drivers/pci/host/pcie-rcar.c:380:4: error: implicit declaration of function
> 'pci_ioremap_io' [-Werror=implicit-function-declaration]
> 
> So, what do I miss?
Ouch, my bad. I have been working with our out-of-tree BSP for the Salvator-X 
board on
http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  rcar-3.0.2 
tag along
with some patches from colleagues. I hadn't noticed this patch:

>From 913ff73dcf19bb57b0a7ad69e51105560d69fa9b Mon Sep 17 00:00:00 2001
From: Harunobu Kurokawa 
Date: Thu, 24 Sep 2015 22:55:58 +0900
Subject: [PATCH 03/15] arm64: PCI(e) arch support for ioremap function

Refered the followings patch:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/269206.html

Signed-off-by: Harunobu Kurokawa 
---
 arch/arm64/include/asm/io.h |2 ++
 arch/arm64/mm/ioremap.c |   13 +
 2 files changed, 15 insertions(+)

diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
index 44be1e0..cea3651 100644
--- a/arch/arm64/include/asm/io.h
+++ b/arch/arm64/include/asm/io.h
@@ -149,6 +149,8 @@ static inline u64 __raw_readq(const volatile void __iomem 
*addr)
 #define IO_SPACE_LIMIT (PCI_IO_SIZE - 1)
 #define PCI_IOBASE ((void __iomem *)PCI_IO_START)
 
+extern int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr);
+
 /*
  * String version of I/O memory access operations.
  */
diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
index 01e88c8..34f09a6 100644
--- a/arch/arm64/mm/ioremap.c
+++ b/arch/arm64/mm/ioremap.c
@@ -104,6 +104,19 @@ void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t 
size)
 }
 EXPORT_SYMBOL(ioremap_cache);
 
+#ifdef CONFIG_PCI
+int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr)
+{
+   BUG_ON(offset + SZ_64K > IO_SPACE_LIMIT);
+
+   return ioremap_page_range((unsigned long)PCI_IOBASE + offset,
+ (unsigned long)PCI_IOBASE + offset + SZ_64K,
+ phys_addr,
+ __pgprot(PROT_NORMAL_NC));
+}
+EXPORT_SYMBOL_GPL(pci_ioremap_io);
+#endif
+
 /*
  * Must be called after early_fixmap_init
  */
-- 
1.7.9.5

Additionally, I have found out that MSI on R-Car PCIe upstream is broken. You 
can
workaround this by reverting f075915ac0b11847fcfc8c4d55526a317e71c4d1 and
f075915ac0b11847fcfc8c4d55526a317e71c4d1 until we fix this.


> > with inbound PCI accesses. I am reasonably sure that this problem is 
> > hardware
> > related.
> 
> Any news if this is really HW related?
I found out that the PCIe controller HW only supports 32-bit AXI bus addresses, 
so it
works fine if you limit the available memory. The driver will need some work to 
use
the IPMMU at some point.

Thanks
Phil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

> Fixes and changes to get PCIe working on ARM64 with mulitple instances.

> I've tested these on ARM (Koelsch board), and it works fine.
> I've also tested on ARM64 (Salvator-X board), but I currently have an issue

I wanted to test these patches on arm64 as well, but even after merging
pci-next, I still get:

drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_setup':
drivers/pci/host/pcie-rcar.c:380:4: error: implicit declaration of function 
'pci_ioremap_io' [-Werror=implicit-function-declaration]

So, what do I miss?

> with inbound PCI accesses. I am reasonably sure that this problem is hardware
> related.

Any news if this is really HW related?

Thanks,

   Wolfram



signature.asc
Description: Digital signature

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

> Fixes and changes to get PCIe working on ARM64 with mulitple instances.

> I've tested these on ARM (Koelsch board), and it works fine.
> I've also tested on ARM64 (Salvator-X board), but I currently have an issue

I wanted to test these patches on arm64 as well, but even after merging
pci-next, I still get:

drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_setup':
drivers/pci/host/pcie-rcar.c:380:4: error: implicit declaration of function 
'pci_ioremap_io' [-Werror=implicit-function-declaration]

So, what do I miss?

> with inbound PCI accesses. I am reasonably sure that this problem is hardware
> related.

Any news if this is really HW related?

Thanks,

   Wolfram



signature.asc
Description: Digital signature

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Wolfram,

On 29 October 2015 12:38, Wolfram wrote:
> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> 
> > I've tested these on ARM (Koelsch board), and it works fine.
> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> 
> I wanted to test these patches on arm64 as well, but even after merging
> pci-next, I still get:
> 
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_setup':
> drivers/pci/host/pcie-rcar.c:380:4: error: implicit declaration of function
> 'pci_ioremap_io' [-Werror=implicit-function-declaration]
> 
> So, what do I miss?
Ouch, my bad. I have been working with our out-of-tree BSP for the Salvator-X 
board on
http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  rcar-3.0.2 
tag along
with some patches from colleagues. I hadn't noticed this patch:

>From 913ff73dcf19bb57b0a7ad69e51105560d69fa9b Mon Sep 17 00:00:00 2001
From: Harunobu Kurokawa 
Date: Thu, 24 Sep 2015 22:55:58 +0900
Subject: [PATCH 03/15] arm64: PCI(e) arch support for ioremap function

Refered the followings patch:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/269206.html

Signed-off-by: Harunobu Kurokawa 
---
 arch/arm64/include/asm/io.h |2 ++
 arch/arm64/mm/ioremap.c |   13 +
 2 files changed, 15 insertions(+)

diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
index 44be1e0..cea3651 100644
--- a/arch/arm64/include/asm/io.h
+++ b/arch/arm64/include/asm/io.h
@@ -149,6 +149,8 @@ static inline u64 __raw_readq(const volatile void __iomem 
*addr)
 #define IO_SPACE_LIMIT (PCI_IO_SIZE - 1)
 #define PCI_IOBASE ((void __iomem *)PCI_IO_START)
 
+extern int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr);
+
 /*
  * String version of I/O memory access operations.
  */
diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
index 01e88c8..34f09a6 100644
--- a/arch/arm64/mm/ioremap.c
+++ b/arch/arm64/mm/ioremap.c
@@ -104,6 +104,19 @@ void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t 
size)
 }
 EXPORT_SYMBOL(ioremap_cache);
 
+#ifdef CONFIG_PCI
+int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr)
+{
+   BUG_ON(offset + SZ_64K > IO_SPACE_LIMIT);
+
+   return ioremap_page_range((unsigned long)PCI_IOBASE + offset,
+ (unsigned long)PCI_IOBASE + offset + SZ_64K,
+ phys_addr,
+ __pgprot(PROT_NORMAL_NC));
+}
+EXPORT_SYMBOL_GPL(pci_ioremap_io);
+#endif
+
 /*
  * Must be called after early_fixmap_init
  */
-- 
1.7.9.5

Additionally, I have found out that MSI on R-Car PCIe upstream is broken. You 
can
workaround this by reverting f075915ac0b11847fcfc8c4d55526a317e71c4d1 and
f075915ac0b11847fcfc8c4d55526a317e71c4d1 until we fix this.


> > with inbound PCI accesses. I am reasonably sure that this problem is 
> > hardware
> > related.
> 
> Any news if this is really HW related?
I found out that the PCIe controller HW only supports 32-bit AXI bus addresses, 
so it
works fine if you limit the available memory. The driver will need some work to 
use
the IPMMU at some point.

Thanks
Phil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Wolfram,

On 29 October 2015 16:40, Wolfram wrote:
> > Ouch, my bad. I have been working with our out-of-tree BSP for the 
> > Salvator-X
> board on
> > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > rcar-3.0.2
> tag along
> > with some patches from colleagues. I hadn't noticed this patch:
> 
> Thanks! Any plans for pushing this upstream? We will have the build error
> otherwise...
After some digging, that patch won't be accepted upstream. I'm looking into how 
the
driver can be modified so it doesn't need to call this, but I don't expect a 
small or
imminent fix.

> > > Any news if this is really HW related?
> > I found out that the PCIe controller HW only supports 32-bit AXI bus 
> > addresses,
> so it
> > works fine if you limit the available memory. The driver will need some 
> > work to
> use
> > the IPMMU at some point.
> 
> Ah, okay.
> 
> Can you send the dts patches, too? I checked the BSP this time, but to
> no avail...
I will once I sort out the arm64 IO resources problem and the MSI problem.

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> Hi Wolfram,
> 
> On 29 October 2015 16:40, Wolfram wrote:
> > > Ouch, my bad. I have been working with our out-of-tree BSP for the 
> > > Salvator-X
> > board on
> > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > rcar-3.0.2
> > tag along
> > > with some patches from colleagues. I hadn't noticed this patch:
> > 
> > Thanks! Any plans for pushing this upstream? We will have the build error
> > otherwise...
> After some digging, that patch won't be accepted upstream. I'm looking into 
> how the
> driver can be modified so it doesn't need to call this, but I don't expect a 
> small or
> imminent fix.

Yes, I'd think so, too. However, a fix for 4.4 would be needed to
prevent having a final release with a build error.

> > > > Any news if this is really HW related?
> > > I found out that the PCIe controller HW only supports 32-bit AXI bus 
> > > addresses,
> > so it
> > > works fine if you limit the available memory. The driver will need some 
> > > work to
> > use
> > > the IPMMU at some point.
> > 
> > Ah, okay.
> > 
> > Can you send the dts patches, too? I checked the BSP this time, but to
> > no avail...
> I will once I sort out the arm64 IO resources problem and the MSI problem.

What MSI problem?

And can't you send the DTS patches as RFC so I can add some testing?



signature.asc
Description: Digital signature

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

[-cc Nobuhiro (bouncing)]

On Thu, Oct 29, 2015 at 07:48:00PM +0100, Wolfram Sang wrote:
> On Thu, Oct 29, 2015 at 04:44:06PM +, Phil Edworthy wrote:
> > Hi Wolfram,
> > 
> > On 29 October 2015 16:40, Wolfram wrote:
> > > > Ouch, my bad. I have been working with our out-of-tree BSP for the 
> > > > Salvator-X
> > > board on
> > > > http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> > > > rcar-3.0.2
> > > tag along
> > > > with some patches from colleagues. I hadn't noticed this patch:
> > > 
> > > Thanks! Any plans for pushing this upstream? We will have the build error
> > > otherwise...
> > After some digging, that patch won't be accepted upstream. I'm looking into 
> > how the
> > driver can be modified so it doesn't need to call this, but I don't expect 
> > a small or
> > imminent fix.
> 
> Yes, I'd think so, too. However, a fix for 4.4 would be needed to
> prevent having a final release with a build error.

I'm thinking I should drop my pci/host-rcar branch until we
have a fix for this.  It currently contains:

  9ac724f20774 PCI: rcar: Fix I/O offset for multiple host bridges
  7d75b413f5c6 PCI: rcar: Set root bus nr to that provided in DT
  4c22eab88c68 PCI: rcar: Remove dependency on ARM-specific struct hw_pci
  ef18d2e55ea0 PCI: rcar: Make PCI aware of the I/O resources

Is that right?  Last I heard, Linus expects to release v4.3 on Sunday,
so we really don't have much time to sort this out.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Wolfram Sang]

> Ouch, my bad. I have been working with our out-of-tree BSP for the Salvator-X 
> board on
> http://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git,  
> rcar-3.0.2 tag along
> with some patches from colleagues. I hadn't noticed this patch:

Thanks! Any plans for pushing this upstream? We will have the build error
otherwise...

> > Any news if this is really HW related?
> I found out that the PCIe controller HW only supports 32-bit AXI bus 
> addresses, so it
> works fine if you limit the available memory. The driver will need some work 
> to use
> the IPMMU at some point.

Ah, okay.

Can you send the dts patches, too? I checked the BSP this time, but to
no avail...



signature.asc
Description: Digital signature

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 20 October 2015 13:50, Bjorn wrote:
> On Tue, Oct 20, 2015 at 08:00:10AM +, Phil Edworthy wrote:
> > Hi Geert,
> >
> > On 20 October 2015 08:37, Geert wrote:
> > > On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman 
> wrote:
> > > > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> > > >> [+cc Geert]
> > > >>
> > > >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > > >> > Fixes and changes to get PCIe working on ARM64 with mulitple
> instances.
> > > >> >
> > > >> > I've tested these on ARM (Koelsch board), and it works fine.
> > > >> > I've also tested on ARM64 (Salvator-X board), but I currently have an
> issue
> > > >> > with inbound PCI accesses. I am reasonably sure that this problem is
> > > hardware
> > > >> > related.
> > > >> >
> > > >> > Phil Edworthy (4):
> > > >> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> > > >> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> > > >> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> > > >> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> > > >>
> > > >> I applied these with Simon's ack to pci/host-rcar for v4.4.
> > > >>
> > > >> Note that these are on top of Geert's patch to make rcar build only
> > > >> for ARM, which is probably not necessary after you remove the struct
> > > >> hw_pci dependency.  I can drop Geert's patch if you want.
> > > >
> > > > I'm happy with that if Geert is.
> > >
> > > Iff the driver compiles/works on arm64 now, my patch should/must be
> > > dropped/reverted.
> > Yes, the driver works on the ARM64 Salvator-X board.
> 
> I dropped Geert's patch and redid the merges to my "next" branch, so
> rcar should build for both ARM and ARM64.
Thanks for sorting that out.
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

On Tue, Oct 20, 2015 at 08:00:10AM +, Phil Edworthy wrote:
> Hi Geert,
> 
> On 20 October 2015 08:37, Geert wrote:
> > On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman  wrote:
> > > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> > >> [+cc Geert]
> > >>
> > >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > >> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> > >> >
> > >> > I've tested these on ARM (Koelsch board), and it works fine.
> > >> > I've also tested on ARM64 (Salvator-X board), but I currently have an 
> > >> > issue
> > >> > with inbound PCI accesses. I am reasonably sure that this problem is
> > hardware
> > >> > related.
> > >> >
> > >> > Phil Edworthy (4):
> > >> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> > >> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> > >> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> > >> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> > >>
> > >> I applied these with Simon's ack to pci/host-rcar for v4.4.
> > >>
> > >> Note that these are on top of Geert's patch to make rcar build only
> > >> for ARM, which is probably not necessary after you remove the struct
> > >> hw_pci dependency.  I can drop Geert's patch if you want.
> > >
> > > I'm happy with that if Geert is.
> > 
> > Iff the driver compiles/works on arm64 now, my patch should/must be
> > dropped/reverted.
> Yes, the driver works on the ARM64 Salvator-X board. 

I dropped Geert's patch and redid the merges to my "next" branch, so
rcar should build for both ARM and ARM64.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Geert,

On 20 October 2015 08:37, Geert wrote:
> On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman  wrote:
> > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> >> [+cc Geert]
> >>
> >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> >> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> >> >
> >> > I've tested these on ARM (Koelsch board), and it works fine.
> >> > I've also tested on ARM64 (Salvator-X board), but I currently have an 
> >> > issue
> >> > with inbound PCI accesses. I am reasonably sure that this problem is
> hardware
> >> > related.
> >> >
> >> > Phil Edworthy (4):
> >> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> >> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> >> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> >> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> >>
> >> I applied these with Simon's ack to pci/host-rcar for v4.4.
> >>
> >> Note that these are on top of Geert's patch to make rcar build only
> >> for ARM, which is probably not necessary after you remove the struct
> >> hw_pci dependency.  I can drop Geert's patch if you want.
> >
> > I'm happy with that if Geert is.
> 
> Iff the driver compiles/works on arm64 now, my patch should/must be
> dropped/reverted.
Yes, the driver works on the ARM64 Salvator-X board. 

Thanks
Phil
N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Geert Uytterhoeven]

On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman  wrote:
> On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
>> [+cc Geert]
>>
>> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
>> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
>> >
>> > I've tested these on ARM (Koelsch board), and it works fine.
>> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
>> > with inbound PCI accesses. I am reasonably sure that this problem is 
>> > hardware
>> > related.
>> >
>> > Phil Edworthy (4):
>> >   PCI: rcar-pcie: Make PCI aware of the IO resources
>> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
>> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
>> >   PCI: rcar-pcie: Fix IO offset for multiple instances
>>
>> I applied these with Simon's ack to pci/host-rcar for v4.4.
>>
>> Note that these are on top of Geert's patch to make rcar build only
>> for ARM, which is probably not necessary after you remove the struct
>> hw_pci dependency.  I can drop Geert's patch if you want.
>
> I'm happy with that if Geert is.

Iff the driver compiles/works on arm64 now, my patch should/must be
dropped/reverted.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Geert,

On 20 October 2015 08:37, Geert wrote:
> On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman  wrote:
> > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> >> [+cc Geert]
> >>
> >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> >> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> >> >
> >> > I've tested these on ARM (Koelsch board), and it works fine.
> >> > I've also tested on ARM64 (Salvator-X board), but I currently have an 
> >> > issue
> >> > with inbound PCI accesses. I am reasonably sure that this problem is
> hardware
> >> > related.
> >> >
> >> > Phil Edworthy (4):
> >> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> >> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> >> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> >> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> >>
> >> I applied these with Simon's ack to pci/host-rcar for v4.4.
> >>
> >> Note that these are on top of Geert's patch to make rcar build only
> >> for ARM, which is probably not necessary after you remove the struct
> >> hw_pci dependency.  I can drop Geert's patch if you want.
> >
> > I'm happy with that if Geert is.
> 
> Iff the driver compiles/works on arm64 now, my patch should/must be
> dropped/reverted.
Yes, the driver works on the ARM64 Salvator-X board. 

Thanks
Phil
N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

On Tue, Oct 20, 2015 at 08:00:10AM +, Phil Edworthy wrote:
> Hi Geert,
> 
> On 20 October 2015 08:37, Geert wrote:
> > On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman  wrote:
> > > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> > >> [+cc Geert]
> > >>
> > >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > >> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> > >> >
> > >> > I've tested these on ARM (Koelsch board), and it works fine.
> > >> > I've also tested on ARM64 (Salvator-X board), but I currently have an 
> > >> > issue
> > >> > with inbound PCI accesses. I am reasonably sure that this problem is
> > hardware
> > >> > related.
> > >> >
> > >> > Phil Edworthy (4):
> > >> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> > >> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> > >> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> > >> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> > >>
> > >> I applied these with Simon's ack to pci/host-rcar for v4.4.
> > >>
> > >> Note that these are on top of Geert's patch to make rcar build only
> > >> for ARM, which is probably not necessary after you remove the struct
> > >> hw_pci dependency.  I can drop Geert's patch if you want.
> > >
> > > I'm happy with that if Geert is.
> > 
> > Iff the driver compiles/works on arm64 now, my patch should/must be
> > dropped/reverted.
> Yes, the driver works on the ARM64 Salvator-X board. 

I dropped Geert's patch and redid the merges to my "next" branch, so
rcar should build for both ARM and ARM64.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Geert Uytterhoeven]

On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman  wrote:
> On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
>> [+cc Geert]
>>
>> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
>> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
>> >
>> > I've tested these on ARM (Koelsch board), and it works fine.
>> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
>> > with inbound PCI accesses. I am reasonably sure that this problem is 
>> > hardware
>> > related.
>> >
>> > Phil Edworthy (4):
>> >   PCI: rcar-pcie: Make PCI aware of the IO resources
>> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
>> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
>> >   PCI: rcar-pcie: Fix IO offset for multiple instances
>>
>> I applied these with Simon's ack to pci/host-rcar for v4.4.
>>
>> Note that these are on top of Geert's patch to make rcar build only
>> for ARM, which is probably not necessary after you remove the struct
>> hw_pci dependency.  I can drop Geert's patch if you want.
>
> I'm happy with that if Geert is.

Iff the driver compiles/works on arm64 now, my patch should/must be
dropped/reverted.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Hi Bjorn,

On 20 October 2015 13:50, Bjorn wrote:
> On Tue, Oct 20, 2015 at 08:00:10AM +, Phil Edworthy wrote:
> > Hi Geert,
> >
> > On 20 October 2015 08:37, Geert wrote:
> > > On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman 
> wrote:
> > > > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> > > >> [+cc Geert]
> > > >>
> > > >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > > >> > Fixes and changes to get PCIe working on ARM64 with mulitple
> instances.
> > > >> >
> > > >> > I've tested these on ARM (Koelsch board), and it works fine.
> > > >> > I've also tested on ARM64 (Salvator-X board), but I currently have an
> issue
> > > >> > with inbound PCI accesses. I am reasonably sure that this problem is
> > > hardware
> > > >> > related.
> > > >> >
> > > >> > Phil Edworthy (4):
> > > >> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> > > >> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> > > >> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> > > >> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> > > >>
> > > >> I applied these with Simon's ack to pci/host-rcar for v4.4.
> > > >>
> > > >> Note that these are on top of Geert's patch to make rcar build only
> > > >> for ARM, which is probably not necessary after you remove the struct
> > > >> hw_pci dependency.  I can drop Geert's patch if you want.
> > > >
> > > > I'm happy with that if Geert is.
> > >
> > > Iff the driver compiles/works on arm64 now, my patch should/must be
> > > dropped/reverted.
> > Yes, the driver works on the ARM64 Salvator-X board.
> 
> I dropped Geert's patch and redid the merges to my "next" branch, so
> rcar should build for both ARM and ARM64.
Thanks for sorting that out.
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Simon Horman]

On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> [+cc Geert]
> 
> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> > 
> > I've tested these on ARM (Koelsch board), and it works fine.
> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> > with inbound PCI accesses. I am reasonably sure that this problem is 
> > hardware
> > related.
> > 
> > Phil Edworthy (4):
> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> 
> I applied these with Simon's ack to pci/host-rcar for v4.4.
> 
> Note that these are on top of Geert's patch to make rcar build only
> for ARM, which is probably not necessary after you remove the struct
> hw_pci dependency.  I can drop Geert's patch if you want.

I'm happy with that if Geert is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

[+cc Geert]

On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> 
> I've tested these on ARM (Koelsch board), and it works fine.
> I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> with inbound PCI accesses. I am reasonably sure that this problem is hardware
> related.
> 
> Phil Edworthy (4):
>   PCI: rcar-pcie: Make PCI aware of the IO resources
>   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
>   PCI: rcar-pcie: Set root bus nr to that provided in DT
>   PCI: rcar-pcie: Fix IO offset for multiple instances

I applied these with Simon's ack to pci/host-rcar for v4.4.

Note that these are on top of Geert's patch to make rcar build only
for ARM, which is probably not necessary after you remove the struct
hw_pci dependency.  I can drop Geert's patch if you want.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

[+cc Geert]

On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> 
> I've tested these on ARM (Koelsch board), and it works fine.
> I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> with inbound PCI accesses. I am reasonably sure that this problem is hardware
> related.
> 
> Phil Edworthy (4):
>   PCI: rcar-pcie: Make PCI aware of the IO resources
>   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
>   PCI: rcar-pcie: Set root bus nr to that provided in DT
>   PCI: rcar-pcie: Fix IO offset for multiple instances

I applied these with Simon's ack to pci/host-rcar for v4.4.

Note that these are on top of Geert's patch to make rcar build only
for ARM, which is probably not necessary after you remove the struct
hw_pci dependency.  I can drop Geert's patch if you want.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Simon Horman]

On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> [+cc Geert]
> 
> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> > 
> > I've tested these on ARM (Koelsch board), and it works fine.
> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> > with inbound PCI accesses. I am reasonably sure that this problem is 
> > hardware
> > related.
> > 
> > Phil Edworthy (4):
> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> 
> I applied these with Simon's ack to pci/host-rcar for v4.4.
> 
> Note that these are on top of Geert's patch to make rcar build only
> for ARM, which is probably not necessary after you remove the struct
> hw_pci dependency.  I can drop Geert's patch if you want.

I'm happy with that if Geert is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Simon Horman]

On Fri, Oct 16, 2015 at 04:34:43PM -0500, Bjorn Helgaas wrote:
> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> > 
> > I've tested these on ARM (Koelsch board), and it works fine.
> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> > with inbound PCI accesses. I am reasonably sure that this problem is 
> > hardware
> > related.
> > 
> > Phil Edworthy (4):
> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> 
> This all looks pretty reasonable to me, but I'm waiting for an ack from
> Simon before merging it.

Acked-by: Simon Horman 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Simon Horman]

On Fri, Oct 16, 2015 at 04:34:43PM -0500, Bjorn Helgaas wrote:
> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> > Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> > 
> > I've tested these on ARM (Koelsch board), and it works fine.
> > I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> > with inbound PCI accesses. I am reasonably sure that this problem is 
> > hardware
> > related.
> > 
> > Phil Edworthy (4):
> >   PCI: rcar-pcie: Make PCI aware of the IO resources
> >   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
> >   PCI: rcar-pcie: Set root bus nr to that provided in DT
> >   PCI: rcar-pcie: Fix IO offset for multiple instances
> 
> This all looks pretty reasonable to me, but I'm waiting for an ack from
> Simon before merging it.

Acked-by: Simon Horman 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> 
> I've tested these on ARM (Koelsch board), and it works fine.
> I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> with inbound PCI accesses. I am reasonably sure that this problem is hardware
> related.
> 
> Phil Edworthy (4):
>   PCI: rcar-pcie: Make PCI aware of the IO resources
>   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
>   PCI: rcar-pcie: Set root bus nr to that provided in DT
>   PCI: rcar-pcie: Fix IO offset for multiple instances

This all looks pretty reasonable to me, but I'm waiting for an ack from
Simon before merging it.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Bjorn Helgaas]

On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wrote:
> Fixes and changes to get PCIe working on ARM64 with mulitple instances.
> 
> I've tested these on ARM (Koelsch board), and it works fine.
> I've also tested on ARM64 (Salvator-X board), but I currently have an issue
> with inbound PCI accesses. I am reasonably sure that this problem is hardware
> related.
> 
> Phil Edworthy (4):
>   PCI: rcar-pcie: Make PCI aware of the IO resources
>   PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
>   PCI: rcar-pcie: Set root bus nr to that provided in DT
>   PCI: rcar-pcie: Fix IO offset for multiple instances

This all looks pretty reasonable to me, but I'm waiting for an ack from
Simon before merging it.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Fixes and changes to get PCIe working on ARM64 with mulitple instances.

I've tested these on ARM (Koelsch board), and it works fine.
I've also tested on ARM64 (Salvator-X board), but I currently have an issue
with inbound PCI accesses. I am reasonably sure that this problem is hardware
related.

Phil Edworthy (4):
  PCI: rcar-pcie: Make PCI aware of the IO resources
  PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
  PCI: rcar-pcie: Set root bus nr to that provided in DT
  PCI: rcar-pcie: Fix IO offset for multiple instances

 drivers/pci/host/pcie-rcar.c | 86 
 1 file changed, 55 insertions(+), 31 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 0/4] PCI: rcar: Add support for ARM64 and multiple instances

[Phil Edworthy]

Fixes and changes to get PCIe working on ARM64 with mulitple instances.

I've tested these on ARM (Koelsch board), and it works fine.
I've also tested on ARM64 (Salvator-X board), but I currently have an issue
with inbound PCI accesses. I am reasonably sure that this problem is hardware
related.

Phil Edworthy (4):
  PCI: rcar-pcie: Make PCI aware of the IO resources
  PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
  PCI: rcar-pcie: Set root bus nr to that provided in DT
  PCI: rcar-pcie: Fix IO offset for multiple instances

 drivers/pci/host/pcie-rcar.c | 86 
 1 file changed, 55 insertions(+), 31 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/