Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Doug Anderson
Hi, On Mon, Oct 26, 2015 at 4:49 PM, Doug Anderson wrote: > One note: the "full" PHY reset is actually not in the register map of > the PHY. It is amazingly enough in the CRU (clock reset unit). So if > we actually exposed the "full" reset through the PHY framework, the > PHY would then turn

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Doug Anderson
Rob, On Mon, Oct 26, 2015 at 4:05 PM, Rob Herring wrote: >>> A DT reset controller seems like a bit of an overkill here. I think this >>> would be much more simple if we just add a phy reset hook to the phy >>> subsystem. >> >> Adding a reset hook in the PHY subsystem does seem like a reasonable

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Rob Herring
On Sat, Oct 24, 2015 at 4:22 PM, Doug Anderson wrote: > Rob, > > On Sat, Oct 24, 2015 at 11:10 AM, Rob Herring wrote: >> On 10/23/2015 01:28 PM, Douglas Anderson wrote: >>> The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 >>> has a hardware errata that causes everything to

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Rob Herring
On Sat, Oct 24, 2015 at 4:22 PM, Doug Anderson wrote: > Rob, > > On Sat, Oct 24, 2015 at 11:10 AM, Rob Herring wrote: >> On 10/23/2015 01:28 PM, Douglas Anderson wrote: >>> The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 >>> has a

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Doug Anderson
Rob, On Mon, Oct 26, 2015 at 4:05 PM, Rob Herring wrote: >>> A DT reset controller seems like a bit of an overkill here. I think this >>> would be much more simple if we just add a phy reset hook to the phy >>> subsystem. >> >> Adding a reset hook in the PHY subsystem does seem

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Doug Anderson
Hi, On Mon, Oct 26, 2015 at 4:49 PM, Doug Anderson wrote: > One note: the "full" PHY reset is actually not in the register map of > the PHY. It is amazingly enough in the CRU (clock reset unit). So if > we actually exposed the "full" reset through the PHY framework, the

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-24 Thread Doug Anderson
Rob, On Sat, Oct 24, 2015 at 11:10 AM, Rob Herring wrote: > On 10/23/2015 01:28 PM, Douglas Anderson wrote: >> The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 >> has a hardware errata that causes everything to get confused when we get >> a remote wakeup. It appears that

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-24 Thread Rob Herring
On 10/23/2015 01:28 PM, Douglas Anderson wrote: > The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 > has a hardware errata that causes everything to get confused when we get > a remote wakeup. It appears that the "port reset" bit that's in the USB > phy (located in the

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-24 Thread Heiko Stübner
Am Freitag, 23. Oktober 2015, 11:28:07 schrieb Douglas Anderson: > The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 > has a hardware errata that causes everything to get confused when we get > a remote wakeup. It appears that the "port reset" bit that's in the USB > phy

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-24 Thread Rob Herring
On 10/23/2015 01:28 PM, Douglas Anderson wrote: > The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 > has a hardware errata that causes everything to get confused when we get > a remote wakeup. It appears that the "port reset" bit that's in the USB > phy (located in the

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-24 Thread Doug Anderson
Rob, On Sat, Oct 24, 2015 at 11:10 AM, Rob Herring wrote: > On 10/23/2015 01:28 PM, Douglas Anderson wrote: >> The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 >> has a hardware errata that causes everything to get confused when we get >> a remote wakeup.

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-24 Thread Heiko Stübner
Am Freitag, 23. Oktober 2015, 11:28:07 schrieb Douglas Anderson: > The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 > has a hardware errata that causes everything to get confused when we get > a remote wakeup. It appears that the "port reset" bit that's in the USB > phy

[PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-23 Thread Douglas Anderson
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. It appears that the "port reset" bit that's in the USB phy (located in the rk3288 GRF) fixes things up and appears safe to do. This

[PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-23 Thread Douglas Anderson
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. It appears that the "port reset" bit that's in the USB phy (located in the rk3288 GRF) fixes things up and appears safe to do. This