Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

Linus Walleij writes: > On Thu, Dec 10, 2015 at 6:31 PM, Robert Jarzmik > wrote: >> Linus Walleij writes: >> - the GPDR (gpio direction register) shared access bothers me a bit >>> >>> How is it shared and between what users? >> >> It's shared between the pin controller and the gpio

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

On Thu, Dec 10, 2015 at 6:31 PM, Robert Jarzmik wrote: > Linus Walleij writes: > >>>- the GPDR (gpio direction register) shared access bothers me a bit >> >> How is it shared and between what users? > > It's shared between the pin controller and the gpio controller. OK then it may be one of

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

On Thu, Dec 10, 2015 at 6:31 PM, Robert Jarzmik wrote: > Linus Walleij writes: > >>>- the GPDR (gpio direction register) shared access bothers me a bit >> >> How is it shared and between what users? > > It's shared between the pin controller

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

Linus Walleij writes: > On Thu, Dec 10, 2015 at 6:31 PM, Robert Jarzmik > wrote: >> Linus Walleij writes: >> - the GPDR (gpio direction register) shared access bothers me a bit >>> >>> How is it shared and

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

Linus Walleij writes: >>- the GPDR (gpio direction register) shared access bothers me a bit > > How is it shared and between what users? It's shared between the pin controller and the gpio controller. The odd thing with the pxa architecture is that the GPDR bit selects between 2 different

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

On Thu, Dec 10, 2015 at 8:28 AM, Robert Jarzmik wrote: > Linus Walleij writes: > >> On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik >> wrote: >> >>> Hi Linus, Alexandre and Haojian, >>> >>> This serie aims at several cleanups and improvements in the pxa gpio >>> driver, to >> >> I have

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

Linus Walleij writes: >>- the GPDR (gpio direction register) shared access bothers me a bit > > How is it shared and between what users? It's shared between the pin controller and the gpio controller. The odd thing with the pxa architecture is that the GPDR bit

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

On Thu, Dec 10, 2015 at 8:28 AM, Robert Jarzmik wrote: > Linus Walleij writes: > >> On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik >> wrote: >> >>> Hi Linus, Alexandre and Haojian, >>> >>> This serie aims at several

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

Linus Walleij writes: > On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik > wrote: > >> Hi Linus, Alexandre and Haojian, >> >> This serie aims at several cleanups and improvements in the pxa gpio driver, >> to > > I have concerns about this series. > > I am worried that joining the banks into

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik wrote: > Hi Linus, Alexandre and Haojian, > > This serie aims at several cleanups and improvements in the pxa gpio driver, > to I have concerns about this series. I am worried that joining the banks into one gpio_chip makes it impossible for

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik wrote: > Hi Linus, Alexandre and Haojian, > > This serie aims at several cleanups and improvements in the pxa gpio driver, > to I have concerns about this series. I am worried that joining the banks into one gpio_chip

Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

Linus Walleij writes: > On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik > wrote: > >> Hi Linus, Alexandre and Haojian, >> >> This serie aims at several cleanups and improvements in the pxa gpio driver, >> to > > I have concerns about this

[PATCH 0/4] gpio: pxa: integrate with pincontrol

Hi Linus, Alexandre and Haojian, This serie aims at several cleanups and improvements in the pxa gpio driver, to support integration with pin control. Amongst the changes, the main points are : - removal of as many global variables as possible - use of devm_*() function when applicable - use

[PATCH 0/4] gpio: pxa: integrate with pincontrol

Hi Linus, Alexandre and Haojian, This serie aims at several cleanups and improvements in the pxa gpio driver, to support integration with pin control. Amongst the changes, the main points are : - removal of as many global variables as possible - use of devm_*() function when applicable - use