Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-03-08 Thread Kalle Valo
Marc Zyngier writes: > On 08/03/2019 08:26, Kalle Valo wrote: >> Marc Zyngier writes: >> >>> dt-bindings/marvell-8xxx: Allow wake-up interrupt to be placed in a >>> separate node >>> mwifiex: Fetch wake-up interrupt from 'wake-up' subnode when it exists >>> mwifiex: Flag wake-up

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-03-08 Thread Marc Zyngier
On 08/03/2019 08:26, Kalle Valo wrote: > Marc Zyngier writes: > >> For quite some time, I wondered why the PCI mwifiex device built in my >> Chromebook was unable to use the good old legacy interrupts. But as MSIs >> were working fine, I never really bothered investigating. I finally had a >>

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-03-08 Thread Kalle Valo
Marc Zyngier writes: > For quite some time, I wondered why the PCI mwifiex device built in my > Chromebook was unable to use the good old legacy interrupts. But as MSIs > were working fine, I never really bothered investigating. I finally had a > look, and the result isn't very pretty. > > On

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-28 Thread Rafael J. Wysocki
On Thu, Feb 28, 2019 at 3:29 AM Brian Norris wrote: > > Hi Rafael, > > On Wed, Feb 27, 2019 at 3:04 PM Rafael J. Wysocki wrote: > > On Wed, Feb 27, 2019 at 9:58 PM Brian Norris > > wrote: > > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > > > So I'd argue that we should

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Brian Norris
Hi Rafael, On Wed, Feb 27, 2019 at 3:04 PM Rafael J. Wysocki wrote: > On Wed, Feb 27, 2019 at 9:58 PM Brian Norris wrote: > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > > So I'd argue that we should add an optional 'wake-gpio' DT property > > > instead to the generic

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Rafael J. Wysocki
On Wed, Feb 27, 2019 at 9:58 PM Brian Norris wrote: > > Hi Ard, > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > On Wed, 27 Feb 2019 at 11:02, Marc Zyngier wrote: > > > On 26/02/2019 23:28, Brian Norris wrote: > > > > You're not the first person to notice this. All the

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Brian Norris
Hi Ard, On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > On Wed, 27 Feb 2019 at 11:02, Marc Zyngier wrote: > > On 26/02/2019 23:28, Brian Norris wrote: > > > You're not the first person to notice this. All the motivations are not > > > necessarily painted clearly in their cover

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Brian Norris
Hi Marc, On Wed, Feb 27, 2019 at 10:02:16AM +, Marc Zyngier wrote: > On 26/02/2019 23:28, Brian Norris wrote: > > On Sun, Feb 24, 2019 at 02:04:22PM +, Marc Zyngier wrote: > >> Note how the interrupt is part of the properties directly attached to the > >> PCI node. And yet, this interrupt

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Ard Biesheuvel
On Wed, 27 Feb 2019 at 11:02, Marc Zyngier wrote: > > + Lorenzo > > Hi Brian, > > On 26/02/2019 23:28, Brian Norris wrote: > > + others > > > > Hi Marc, > > > > Thanks for the series. I have a few bits of history to add to this, and > > some comments. > > > > On Sun, Feb 24, 2019 at 02:04:22PM

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Marc Zyngier
+ Lorenzo Hi Brian, On 26/02/2019 23:28, Brian Norris wrote: > + others > > Hi Marc, > > Thanks for the series. I have a few bits of history to add to this, and > some comments. > > On Sun, Feb 24, 2019 at 02:04:22PM +, Marc Zyngier wrote: >> For quite some time, I wondered why the PCI

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Marc Zyngier
On 26/02/2019 23:44, Brian Norris wrote: > Hi, > > On Tue, Feb 26, 2019 at 05:14:00PM +, Marc Zyngier wrote: >> On 26/02/2019 16:21, Ard Biesheuvel wrote: >>> On Mon, 25 Feb 2019 at 15:53, Marc Zyngier wrote: It outlines one thing: If you have to interpret per-device PCI properties

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-26 Thread Brian Norris
Hi, On Tue, Feb 26, 2019 at 05:14:00PM +, Marc Zyngier wrote: > On 26/02/2019 16:21, Ard Biesheuvel wrote: > > On Mon, 25 Feb 2019 at 15:53, Marc Zyngier wrote: > >> It outlines one thing: If you have to interpret per-device PCI > >> properties from DT, you're in for serious trouble. I

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-26 Thread Brian Norris
+ others Hi Marc, Thanks for the series. I have a few bits of history to add to this, and some comments. On Sun, Feb 24, 2019 at 02:04:22PM +, Marc Zyngier wrote: > For quite some time, I wondered why the PCI mwifiex device built in my > Chromebook was unable to use the good old legacy

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-26 Thread Marc Zyngier
On 26/02/2019 16:21, Ard Biesheuvel wrote: > On Mon, 25 Feb 2019 at 15:53, Marc Zyngier wrote: >> >> Hi Ard, >> >> On 25/02/2019 12:45, Ard Biesheuvel wrote: >>> On Sun, 24 Feb 2019 at 15:08, Marc Zyngier wrote: For quite some time, I wondered why the PCI mwifiex device built in my

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-26 Thread Ard Biesheuvel
On Mon, 25 Feb 2019 at 15:53, Marc Zyngier wrote: > > Hi Ard, > > On 25/02/2019 12:45, Ard Biesheuvel wrote: > > On Sun, 24 Feb 2019 at 15:08, Marc Zyngier wrote: > >> > >> For quite some time, I wondered why the PCI mwifiex device built in my > >> Chromebook was unable to use the good old

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-25 Thread Marc Zyngier
Hi Ard, On 25/02/2019 12:45, Ard Biesheuvel wrote: > On Sun, 24 Feb 2019 at 15:08, Marc Zyngier wrote: >> >> For quite some time, I wondered why the PCI mwifiex device built in my >> Chromebook was unable to use the good old legacy interrupts. But as MSIs >> were working fine, I never really

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-25 Thread Ard Biesheuvel
On Sun, 24 Feb 2019 at 15:08, Marc Zyngier wrote: > > For quite some time, I wondered why the PCI mwifiex device built in my > Chromebook was unable to use the good old legacy interrupts. But as MSIs > were working fine, I never really bothered investigating. I finally had a > look, and the

[PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-24 Thread Marc Zyngier
For quite some time, I wondered why the PCI mwifiex device built in my Chromebook was unable to use the good old legacy interrupts. But as MSIs were working fine, I never really bothered investigating. I finally had a look, and the result isn't very pretty. On this machine (rk3399-based kevin),