Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-17 Thread Christian Brauner
On May 17, 2019 9:13:26 AM GMT+02:00, David Howells wrote: >Christian Brauner wrote: > >> If you still prefer to have cloexec flags >> for the 4 new syscalls then yes, >> if they could at least all have the same name >> (FSMOUNT_CLOEXEC?) that would be good. > >They don't all have the same value

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-17 Thread Miklos Szeredi
On Fri, May 17, 2019 at 9:13 AM David Howells wrote: > > Christian Brauner wrote: > > > If you still prefer to have cloexec flags > > for the 4 new syscalls then yes, > > if they could at least all have the same name > > (FSMOUNT_CLOEXEC?) that would be good. > > They don't all have the same

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-17 Thread David Howells
Christian Brauner wrote: > If you still prefer to have cloexec flags > for the 4 new syscalls then yes, > if they could at least all have the same name > (FSMOUNT_CLOEXEC?) that would be good. They don't all have the same value (see OPEN_TREE_CLOEXEC). Note that I also don't want to blindly

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-17 Thread Christian Brauner
On May 16, 2019 6:50:22 PM GMT+02:00, Al Viro wrote: >[linux-abi cc'd] > >On Thu, May 16, 2019 at 06:31:52PM +0200, Christian Brauner wrote: >> On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote: >> > On Thu, May 16, 2019 at 12:52:04PM +0100, David Howells wrote: >> > > >> > > Hi Linus, Al,

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-17 Thread Christian Brauner
On May 16, 2019 10:23:31 PM GMT+02:00, "Dmitry V. Levin" wrote: >[looks like linux-abi is a typo, Cc'ed linux-api instead] > >On Thu, May 16, 2019 at 05:50:22PM +0100, Al Viro wrote: >> [linux-abi cc'd] >> >> On Thu, May 16, 2019 at 06:31:52PM +0200, Christian Brauner wrote: >> > On Thu, May

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Dmitry V. Levin
[looks like linux-abi is a typo, Cc'ed linux-api instead] On Thu, May 16, 2019 at 05:50:22PM +0100, Al Viro wrote: > [linux-abi cc'd] > > On Thu, May 16, 2019 at 06:31:52PM +0200, Christian Brauner wrote: > > On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote: > > > On Thu, May 16, 2019 at

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Alexey Dobriyan
> unshare(CLONE_FILES); > /* we don't want anything past stderr here */ > close_range(3, ~0U); > execve(); Yes please. nextfd(2) https://lkml.org/lkml/2012/4/1/71 fdmap(2) https://marc.info/?t=15062836696=1=4 I like fdmap more.

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Christian Brauner
On May 16, 2019 6:50:22 PM GMT+02:00, Al Viro wrote: >[linux-abi cc'd] > >On Thu, May 16, 2019 at 06:31:52PM +0200, Christian Brauner wrote: >> On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote: >> > On Thu, May 16, 2019 at 12:52:04PM +0100, David Howells wrote: >> > > >> > > Hi Linus, Al,

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Al Viro
[linux-abi cc'd] On Thu, May 16, 2019 at 06:31:52PM +0200, Christian Brauner wrote: > On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote: > > On Thu, May 16, 2019 at 12:52:04PM +0100, David Howells wrote: > > > > > > Hi Linus, Al, > > > > > > Here are some patches that make changes to the

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Christian Brauner
On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote: > On Thu, May 16, 2019 at 12:52:04PM +0100, David Howells wrote: > > > > Hi Linus, Al, > > > > Here are some patches that make changes to the mount API UAPI and two of > > them really need applying, before -rc1 - if they're going to be

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Al Viro
On Thu, May 16, 2019 at 05:22:59PM +0100, Al Viro wrote: > On Thu, May 16, 2019 at 12:52:04PM +0100, David Howells wrote: > > > > Hi Linus, Al, > > > > Here are some patches that make changes to the mount API UAPI and two of > > them really need applying, before -rc1 - if they're going to be

Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread Al Viro
On Thu, May 16, 2019 at 12:52:04PM +0100, David Howells wrote: > > Hi Linus, Al, > > Here are some patches that make changes to the mount API UAPI and two of > them really need applying, before -rc1 - if they're going to be applied at > all. I'm fine with 2--4, but I'm not convinced that

[PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]

2019-05-16 Thread David Howells
Hi Linus, Al, Here are some patches that make changes to the mount API UAPI and two of them really need applying, before -rc1 - if they're going to be applied at all. The following changes are made: (1) Make the file descriptors returned by open_tree(), fsopen(), fspick() and fsmount()