Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-02 Thread Ingo Molnar
* 平松雅巳 / HIRAMATU,MASAMI wrote: > > sure, np you can use my ack > > I'm also OK for this patch. I just concern that is OK for Adrian too? > Since this ensures all the copied code should be dead copy (not modified > anymore), > if we want a different

RE: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-02 Thread 平松雅巳 / HIRAMATU,MASAMI
> From: Jiri Olsa [mailto:jo...@redhat.com] > > On Tue, Sep 01, 2015 at 04:57:16PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter escreveu: > > > On 01/09/15 11:54, Ingo Molnar wrote: > > > > > > > > * Adrian Hunter

RE: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-02 Thread 平松雅巳 / HIRAMATU,MASAMI
> From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo Molnar > > > > sure, np you can use my ack > > > > I'm also OK for this patch. I just concern that is OK for Adrian too? > > Since this ensures all the copied code should be dead copy (not modified > > anymore), > > if we

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter escreveu: > On 01/09/15 11:54, Ingo Molnar wrote: > > > > * Adrian Hunter wrote: > > > >> Hi > >> > >> perf tools has a copy of the x86 instruction decoder for decoding > >> Intel PT. [...] > > > > So that's the

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Ingo Molnar
* Adrian Hunter wrote: > Hi > > perf tools has a copy of the x86 instruction decoder for decoding > Intel PT. [...] So that's the arch/x86/lib/insn.c instruction length decoder that the kernel uses for kprobes et al - and the two versions already forked slightly:

RE: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread 平松雅巳 / HIRAMATU,MASAMI
> From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo Molnar > > > * Adrian Hunter wrote: > > > Hi > > > > perf tools has a copy of the x86 instruction decoder for decoding > > Intel PT. [...] > > So that's the arch/x86/lib/insn.c instruction

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Adrian Hunter
On 01/09/15 14:38, 平松雅巳 / HIRAMATU,MASAMI wrote: >> From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo >> Molnar >> >> >> * Adrian Hunter wrote: >> >>> Hi >>> >>> perf tools has a copy of the x86 instruction decoder for decoding >>> Intel PT. [...]

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Adrian Hunter
On 01/09/15 11:54, Ingo Molnar wrote: > > * Adrian Hunter wrote: > >> Hi >> >> perf tools has a copy of the x86 instruction decoder for decoding >> Intel PT. [...] > > So that's the arch/x86/lib/insn.c instruction length decoder that the kernel > uses > for kprobes

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Ingo Molnar
* Adrian Hunter wrote: > > Agreed, what I concern is that someone finds a bug and fixes one of them > > and > > another is not fixed. > > > > I'll see the forked version and check if it can be merged into the kernel. > > Ever since Linus complained about perf tools

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Jiri Olsa
On Tue, Sep 01, 2015 at 04:57:16PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter escreveu: > > On 01/09/15 11:54, Ingo Molnar wrote: > > > > > > * Adrian Hunter wrote: > > > > > >> Hi > > >> > > >> perf tools has a copy

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2015 at 03:59:16PM +0200, Jiri Olsa escreveu: > On Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter wrote: > > On 01/09/15 11:54, Ingo Molnar wrote: > > > it would be nice to add a diff check to the perf build, and (non-fatally) > > > warn > > > during the build if the two

RE: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread 平松雅巳 / HIRAMATU,MASAMI
> From: Adrian Hunter [mailto:adrian.hun...@intel.com] > > On 01/09/15 14:38, 平松雅巳 / HIRAMATU,MASAMI wrote: > >> From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo > >> Molnar > >> > >> > >> * Adrian Hunter wrote: > >> > >>> Hi > >>> > >>> perf

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter escreveu: > On 01/09/15 11:54, Ingo Molnar wrote: > > * Adrian Hunter wrote: > >> perf tools has a copy of the x86 instruction decoder for decoding > >> Intel PT. [...] > > So that's the arch/x86/lib/insn.c

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-09-01 Thread Jiri Olsa
On Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter wrote: > On 01/09/15 11:54, Ingo Molnar wrote: > > > > * Adrian Hunter wrote: > > > >> Hi > >> > >> perf tools has a copy of the x86 instruction decoder for decoding > >> Intel PT. [...] > > > > So that's the

Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-08-31 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 31, 2015 at 04:58:38PM +0300, Adrian Hunter escreveu: > Hi > > perf tools has a copy of the x86 instruction decoder for decoding > Intel PT. This patch set adds a perf tools test to use it to > test new instructions. Subsequent patches add a few new x86 > instructions, or very

[PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions

2015-08-31 Thread Adrian Hunter
Hi perf tools has a copy of the x86 instruction decoder for decoding Intel PT. This patch set adds a perf tools test to use it to test new instructions. Subsequent patches add a few new x86 instructions, or very slightly modify them in the case of MPX. Those changes affect both perf tools and