Re: [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor
On 6/18/19 11:47 AM, Michael Neuling wrote: > On Tue, 2019-06-18 at 08:01 +0200, Christophe Leroy wrote: >> >> Le 18/06/2019 à 06:27, Ravi Bangoria a écrit : >>> patch 1-3: Code refactor >>> patch 4: Speedup disabling breakpoint >>> patch 5: Fix length calculation for unaligned targets >> >> While you are playing with hw breakpoints, did you have a look at >> https://github.com/linuxppc/issues/issues/38 ? > > Agreed and also: > > https://github.com/linuxppc/issues/issues/170 > > https://github.com/linuxppc/issues/issues/128 > Yes, I'm aware of those. Will have a look at them.
Re: [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor
On Tue, 2019-06-18 at 08:01 +0200, Christophe Leroy wrote: > > Le 18/06/2019 à 06:27, Ravi Bangoria a écrit : > > patch 1-3: Code refactor > > patch 4: Speedup disabling breakpoint > > patch 5: Fix length calculation for unaligned targets > > While you are playing with hw breakpoints, did you have a look at > https://github.com/linuxppc/issues/issues/38 ? Agreed and also: https://github.com/linuxppc/issues/issues/170 https://github.com/linuxppc/issues/issues/128 Mikey
Re: [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor
Le 18/06/2019 à 06:27, Ravi Bangoria a écrit : patch 1-3: Code refactor patch 4: Speedup disabling breakpoint patch 5: Fix length calculation for unaligned targets While you are playing with hw breakpoints, did you have a look at https://github.com/linuxppc/issues/issues/38 ? Christophe Ravi Bangoria (5): Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Powerpc/hw-breakpoint: Refactor hw_breakpoint_arch_parse() Powerpc/hw-breakpoint: Refactor set_dawr() Powerpc/hw-breakpoint: Optimize disable path Powerpc/Watchpoint: Fix length calculation for unaligned target arch/powerpc/include/asm/hw_breakpoint.h | 10 ++-- arch/powerpc/kernel/hw_breakpoint.c | 56 -- arch/powerpc/kernel/process.c| 61 +++- arch/powerpc/kernel/ptrace.c | 2 +- 4 files changed, 86 insertions(+), 43 deletions(-)
[PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor
patch 1-3: Code refactor patch 4: Speedup disabling breakpoint patch 5: Fix length calculation for unaligned targets Ravi Bangoria (5): Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Powerpc/hw-breakpoint: Refactor hw_breakpoint_arch_parse() Powerpc/hw-breakpoint: Refactor set_dawr() Powerpc/hw-breakpoint: Optimize disable path Powerpc/Watchpoint: Fix length calculation for unaligned target arch/powerpc/include/asm/hw_breakpoint.h | 10 ++-- arch/powerpc/kernel/hw_breakpoint.c | 56 -- arch/powerpc/kernel/process.c| 61 +++- arch/powerpc/kernel/ptrace.c | 2 +- 4 files changed, 86 insertions(+), 43 deletions(-) -- 2.20.1
