Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Marcel, Sorry about the late reply. I got side-tracked with other things. On Tue, May 08, 2018 at 10:03:57PM +0200, Marcel Holtmann wrote: > Hi Johan, > > >> I have one concern, though. While providing raw data by > >> default is fine generally, it is a problem with device > >>

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Marcel, Sorry about the late reply. I got side-tracked with other things. On Tue, May 08, 2018 at 10:03:57PM +0200, Marcel Holtmann wrote: > Hi Johan, > > >> I have one concern, though. While providing raw data by > >> default is fine generally, it is a problem with device > >>

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, >> I have one concern, though. While providing raw data by >> default is fine generally, it is a problem with device >> auto-discovery. I think there should be some IOCTL from >> the start, that can be used to inform userspace about >> the raw protocol being used

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, >> I have one concern, though. While providing raw data by >> default is fine generally, it is a problem with device >> auto-discovery. I think there should be some IOCTL from >> the start, that can be used to inform userspace about >> the raw protocol being used

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, May 08, 2018 at 09:49:36AM +0200, Marcel Holtmann wrote: > Hi Johan, > > I have one concern, though. While providing raw data by > default is fine generally, it is a problem with device > auto-discovery. I think there should be some IOCTL from > the start, that can be

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, May 08, 2018 at 09:49:36AM +0200, Marcel Holtmann wrote: > Hi Johan, > > I have one concern, though. While providing raw data by > default is fine generally, it is a problem with device > auto-discovery. I think there should be some IOCTL from > the start, that can be

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, I have one concern, though. While providing raw data by default is fine generally, it is a problem with device auto-discovery. I think there should be some IOCTL from the start, that can be used to inform userspace about the raw protocol being used (i.e.

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, I have one concern, though. While providing raw data by default is fine generally, it is a problem with device auto-discovery. I think there should be some IOCTL from the start, that can be used to inform userspace about the raw protocol being used (i.e.

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Mon, May 07, 2018 at 09:06:44PM +0200, Marcel Holtmann wrote: > >> I have one concern, though. While providing raw data by > >> default is fine generally, it is a problem with device > >> auto-discovery. I think there should be some IOCTL from > >> the start, that can be used to inform

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Mon, May 07, 2018 at 09:06:44PM +0200, Marcel Holtmann wrote: > >> I have one concern, though. While providing raw data by > >> default is fine generally, it is a problem with device > >> auto-discovery. I think there should be some IOCTL from > >> the start, that can be used to inform

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, >>> This series adds a new subsystem for GNSS receivers (e.g. GPS >>> receivers). >>> >>> While GNSS receivers are typically accessed using a UART interface they >>> often also support other I/O interfaces such as I2C, SPI and USB, while >>> yet other devices use iomem or even some

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, >>> This series adds a new subsystem for GNSS receivers (e.g. GPS >>> receivers). >>> >>> While GNSS receivers are typically accessed using a UART interface they >>> often also support other I/O interfaces such as I2C, SPI and USB, while >>> yet other devices use iomem or even some

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Fri, May 04, 2018 at 03:27:41PM +0200, Sebastian Reichel wrote: > Hi Johan, > > On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > > > While GNSS receivers are typically accessed using a UART

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Fri, May 04, 2018 at 03:27:41PM +0200, Sebastian Reichel wrote: > Hi Johan, > > On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > > > While GNSS receivers are typically accessed using a UART

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Pavel, (*) I have those in mind: Nokia N900: The phone has GPS integrated into the modem and uses ISI encapsulated data. The protocol has been reverse engineered and it should be possible to write a kernel driver for handling the GPS packets and dumping the raw

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Pavel, (*) I have those in mind: Nokia N900: The phone has GPS integrated into the modem and uses ISI encapsulated data. The protocol has been reverse engineered and it should be possible to write a kernel driver for handling the GPS packets and dumping the raw

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > > > (*) I have those in mind: > > > > > > Nokia N900: The phone has GPS integrated into the modem and uses > > > ISI encapsulated data. The protocol has been reverse engineered > > > and it should be possible to write a kernel driver for handling > > > the GPS packets and dumping the raw

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > > > (*) I have those in mind: > > > > > > Nokia N900: The phone has GPS integrated into the modem and uses > > > ISI encapsulated data. The protocol has been reverse engineered > > > and it should be possible to write a kernel driver for handling > > > the GPS packets and dumping the raw

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi, On Fri, May 04, 2018 at 10:03:15PM +0200, Pavel Machek wrote: > > > Finally, note that documentation (including kerneldoc) remains to be > > > written, but hopefully this will not hinder review given that the > > > current interfaces are fairly self-describing. > > > > Great work. I like

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi, On Fri, May 04, 2018 at 10:03:15PM +0200, Pavel Machek wrote: > > > Finally, note that documentation (including kerneldoc) remains to be > > > written, but hopefully this will not hinder review given that the > > > current interfaces are fairly self-describing. > > > > Great work. I like

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > > Finally, note that documentation (including kerneldoc) remains to be > > written, but hopefully this will not hinder review given that the > > current interfaces are fairly self-describing. > > Great work. I like your design decisions. I have quite a few devices > with have non-serial

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > > Finally, note that documentation (including kerneldoc) remains to be > > written, but hopefully this will not hinder review given that the > > current interfaces are fairly self-describing. > > Great work. I like your design decisions. I have quite a few devices > with have non-serial

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). > > While GNSS receivers are typically accessed using a UART interface they > often also support other I/O interfaces such as I2C, SPI and USB,

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). > > While GNSS receivers are typically accessed using a UART interface they > often also support other I/O interfaces such as I2C, SPI and USB,

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Thu, Apr 26, 2018 at 12:10:02PM +0200, H. Nikolaus Schaller wrote: > > Am 25.04.2018 um 10:11 schrieb Johan Hovold : > > > > On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote: > > > >>> Am 24.04.2018 um 19:50 schrieb Johan Hovold : > >>

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Thu, Apr 26, 2018 at 12:10:02PM +0200, H. Nikolaus Schaller wrote: > > Am 25.04.2018 um 10:11 schrieb Johan Hovold : > > > > On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote: > > > >>> Am 24.04.2018 um 19:50 schrieb Johan Hovold : > >> You could have simply reused what

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, > Am 25.04.2018 um 10:11 schrieb Johan Hovold : > > On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote: > >>> Am 24.04.2018 um 19:50 schrieb Johan Hovold : > >>> I think it should be done the other way round (if I understand you

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, > Am 25.04.2018 um 10:11 schrieb Johan Hovold : > > On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote: > >>> Am 24.04.2018 um 19:50 schrieb Johan Hovold : > >>> I think it should be done the other way round (if I understand you >>> correctly), that is, by adding

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Wed, Apr 25, 2018 at 10:48:19AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > YEAH > > Thanks so much for doing this, great work! Thanks! > > This all

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Wed, Apr 25, 2018 at 10:48:19AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > YEAH > > Thanks so much for doing this, great work! Thanks! > > This all

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). YEAH Thanks so much for doing this, great work! > While GNSS receivers are typically accessed using a UART interface they > often also support other

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 06:34:51PM +0200, Johan Hovold wrote: > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). YEAH Thanks so much for doing this, great work! > While GNSS receivers are typically accessed using a UART interface they > often also support other

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote: > > Am 24.04.2018 um 19:50 schrieb Johan Hovold : > > I think it should be done the other way round (if I understand you > > correctly), that is, by adding support for configurations were WAKEUP is > > left

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 09:44:08PM +0200, H. Nikolaus Schaller wrote: > > Am 24.04.2018 um 19:50 schrieb Johan Hovold : > > I think it should be done the other way round (if I understand you > > correctly), that is, by adding support for configurations were WAKEUP is > > left not connected to

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 10:59:48PM +0200, Andreas Kemnade wrote: > On Tue, 24 Apr 2018 22:13:19 +0200 > Pavel Machek wrote: > > > Hi! > > > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > > receivers). > > > > Actually... I'd just call it GPS subsystem.

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 10:59:48PM +0200, Andreas Kemnade wrote: > On Tue, 24 Apr 2018 22:13:19 +0200 > Pavel Machek wrote: > > > Hi! > > > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > > receivers). > > > > Actually... I'd just call it GPS subsystem. Yes, GPS is a

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 10:13:19PM +0200, Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar interface, >

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 10:13:19PM +0200, Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar interface, >

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Wed, Apr 25, 2018 at 08:26:59AM +0200, Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > > > While GNSS receivers are typically accessed using a UART interface they > > often also support other I/O interfaces such as I2C, SPI and

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Wed, Apr 25, 2018 at 08:26:59AM +0200, Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > > > While GNSS receivers are typically accessed using a UART interface they > > often also support other I/O interfaces such as I2C, SPI and

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Pavel, >> This series adds a new subsystem for GNSS receivers (e.g. GPS >> receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar interface, > right? We'd like to QZSS to use similar interface, too… GNSS is

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Pavel, >> This series adds a new subsystem for GNSS receivers (e.g. GPS >> receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar interface, > right? We'd like to QZSS to use similar interface, too… GNSS is

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). > > While GNSS receivers are typically accessed using a UART interface they > often also support other I/O interfaces such as I2C, SPI and USB, while > yet other devices use iomem or even some form of

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). > > While GNSS receivers are typically accessed using a UART interface they > often also support other I/O interfaces such as I2C, SPI and USB, while > yet other devices use iomem or even some form of

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, 24 Apr 2018 22:13:19 +0200 Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, 24 Apr 2018 22:13:19 +0200 Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar interface, > right?

Re: [PATCH 0/7] gnss: add new GNSS subsystem

> As proof-of-concept I have implemented drivers for receivers based on > two common GNSS chipsets (SiRFstar and u-blox), but due to lack of > hardware these have so far only been tested using mockup devices and a > USB-serial-based GPS device (using out-of-tree code). [ Let me know if > you've

Re: [PATCH 0/7] gnss: add new GNSS subsystem

> As proof-of-concept I have implemented drivers for receivers based on > two common GNSS chipsets (SiRFstar and u-blox), but due to lack of > hardware these have so far only been tested using mockup devices and a > USB-serial-based GPS device (using out-of-tree code). [ Let me know if > you've

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). Actually... I'd just call it GPS subsystem. Yes, GPS is a bit misleading, but so is GNSS. We'd like Loran to use similar interface, right? We'd like to QZSS to use similar interface, too...

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi! > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). Actually... I'd just call it GPS subsystem. Yes, GPS is a bit misleading, but so is GNSS. We'd like Loran to use similar interface, right? We'd like to QZSS to use similar interface, too...

Re: [PATCH 0/7] gnss: add new GNSS subsystem

> Am 24.04.2018 um 19:50 schrieb Johan Hovold : > > On Tue, Apr 24, 2018 at 07:40:00PM +0200, H. Nikolaus Schaller wrote: >> Hi Johan, >> >>> Am 24.04.2018 um 18:34 schrieb Johan Hovold : > >>> As proof-of-concept I have implemented drivers for receivers

Re: [PATCH 0/7] gnss: add new GNSS subsystem

> Am 24.04.2018 um 19:50 schrieb Johan Hovold : > > On Tue, Apr 24, 2018 at 07:40:00PM +0200, H. Nikolaus Schaller wrote: >> Hi Johan, >> >>> Am 24.04.2018 um 18:34 schrieb Johan Hovold : > >>> As proof-of-concept I have implemented drivers for receivers based on >>> two common GNSS chipsets

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 07:40:00PM +0200, H. Nikolaus Schaller wrote: > Hi Johan, > > > Am 24.04.2018 um 18:34 schrieb Johan Hovold : > > As proof-of-concept I have implemented drivers for receivers based on > > two common GNSS chipsets (SiRFstar and u-blox), but due to lack of

Re: [PATCH 0/7] gnss: add new GNSS subsystem

On Tue, Apr 24, 2018 at 07:40:00PM +0200, H. Nikolaus Schaller wrote: > Hi Johan, > > > Am 24.04.2018 um 18:34 schrieb Johan Hovold : > > As proof-of-concept I have implemented drivers for receivers based on > > two common GNSS chipsets (SiRFstar and u-blox), but due to lack of > > hardware

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, > Am 24.04.2018 um 18:34 schrieb Johan Hovold : > > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). Great! > > While GNSS receivers are typically accessed using a UART interface they > often also support other I/O interfaces such as I2C,

Re: [PATCH 0/7] gnss: add new GNSS subsystem

Hi Johan, > Am 24.04.2018 um 18:34 schrieb Johan Hovold : > > This series adds a new subsystem for GNSS receivers (e.g. GPS > receivers). Great! > > While GNSS receivers are typically accessed using a UART interface they > often also support other I/O interfaces such as I2C, SPI and USB,

[PATCH 0/7] gnss: add new GNSS subsystem

This series adds a new subsystem for GNSS receivers (e.g. GPS receivers). While GNSS receivers are typically accessed using a UART interface they often also support other I/O interfaces such as I2C, SPI and USB, while yet other devices use iomem or even some form of remote-processor messaging

[PATCH 0/7] gnss: add new GNSS subsystem

This series adds a new subsystem for GNSS receivers (e.g. GPS receivers). While GNSS receivers are typically accessed using a UART interface they often also support other I/O interfaces such as I2C, SPI and USB, while yet other devices use iomem or even some form of remote-processor messaging