Re: [PATCH 0/7] uprobes: register/unregister bugfixes
On 10/01, Srikar Dronamraju wrote: > > > This is on top of "[PATCH 0/3] uprobes: mprotect fixes" series, > > which is still waiting for review... > > > > Did you mean [PATCH 0/4] uprobes: remove is_swbp_at_addr() from > register/unregister? Yes, sorry for confusion, > I have already reviewed and acked "[PATCH 0/3] uprobes: mprotect fixes" > series". Yes, and I already added your acks, thanks. > Got distracted by the register/unregister bug that we were discussing > offline. Yes. 2-6 try to fix the bugs I found by the code inspection, but I do not think they can fix that bug, I guess there is yet another problem we need to fix. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] uprobes: register/unregister bugfixes
> This is on top of "[PATCH 0/3] uprobes: mprotect fixes" series, > which is still waiting for review... > Did you mean [PATCH 0/4] uprobes: remove is_swbp_at_addr() from register/unregister? I have already reviewed and acked "[PATCH 0/3] uprobes: mprotect fixes" series". Got distracted by the register/unregister bug that we were discussing offline. Reviewing and testing both the pending series. -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] uprobes: register/unregister bugfixes
This is on top of [PATCH 0/3] uprobes: mprotect fixes series, which is still waiting for review... Did you mean [PATCH 0/4] uprobes: remove is_swbp_at_addr() from register/unregister? I have already reviewed and acked [PATCH 0/3] uprobes: mprotect fixes series. Got distracted by the register/unregister bug that we were discussing offline. Reviewing and testing both the pending series. -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] uprobes: register/unregister bugfixes
On 10/01, Srikar Dronamraju wrote: This is on top of [PATCH 0/3] uprobes: mprotect fixes series, which is still waiting for review... Did you mean [PATCH 0/4] uprobes: remove is_swbp_at_addr() from register/unregister? Yes, sorry for confusion, I have already reviewed and acked [PATCH 0/3] uprobes: mprotect fixes series. Yes, and I already added your acks, thanks. Got distracted by the register/unregister bug that we were discussing offline. Yes. 2-6 try to fix the bugs I found by the code inspection, but I do not think they can fix that bug, I guess there is yet another problem we need to fix. Oleg. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] uprobes: register/unregister bugfixes
Forgot to mention, This is on top of "[PATCH 0/3] uprobes: mprotect fixes" series, which is still waiting for review... On 09/30, Oleg Nesterov wrote: > > Hello. > > Misc bugfixes, mostly register/unregister related. > > Note: 4/7 and especially 6/7 are the really ugly (but hopefully > temporary) hacks. We already discussed this, we should inspect > the original insn in uprobe_register(). But this is not easy, and > we need something simple to fix (some of) the bugs right now. > > Even 7/7 is ugly. Imho UPROBE_SKIP_SSTEP should die as well but > this is another story. > > Oleg. > > arch/x86/kernel/uprobes.c | 16 +-- > include/linux/uprobes.h | 10 > kernel/events/uprobes.c | 107 +++- > 3 files changed, 77 insertions(+), 56 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/7] uprobes: register/unregister bugfixes
Hello. Misc bugfixes, mostly register/unregister related. Note: 4/7 and especially 6/7 are the really ugly (but hopefully temporary) hacks. We already discussed this, we should inspect the original insn in uprobe_register(). But this is not easy, and we need something simple to fix (some of) the bugs right now. Even 7/7 is ugly. Imho UPROBE_SKIP_SSTEP should die as well but this is another story. Oleg. arch/x86/kernel/uprobes.c | 16 +-- include/linux/uprobes.h | 10 kernel/events/uprobes.c | 107 +++- 3 files changed, 77 insertions(+), 56 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/7] uprobes: register/unregister bugfixes
Hello. Misc bugfixes, mostly register/unregister related. Note: 4/7 and especially 6/7 are the really ugly (but hopefully temporary) hacks. We already discussed this, we should inspect the original insn in uprobe_register(). But this is not easy, and we need something simple to fix (some of) the bugs right now. Even 7/7 is ugly. Imho UPROBE_SKIP_SSTEP should die as well but this is another story. Oleg. arch/x86/kernel/uprobes.c | 16 +-- include/linux/uprobes.h | 10 kernel/events/uprobes.c | 107 +++- 3 files changed, 77 insertions(+), 56 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] uprobes: register/unregister bugfixes
Forgot to mention, This is on top of [PATCH 0/3] uprobes: mprotect fixes series, which is still waiting for review... On 09/30, Oleg Nesterov wrote: Hello. Misc bugfixes, mostly register/unregister related. Note: 4/7 and especially 6/7 are the really ugly (but hopefully temporary) hacks. We already discussed this, we should inspect the original insn in uprobe_register(). But this is not easy, and we need something simple to fix (some of) the bugs right now. Even 7/7 is ugly. Imho UPROBE_SKIP_SSTEP should die as well but this is another story. Oleg. arch/x86/kernel/uprobes.c | 16 +-- include/linux/uprobes.h | 10 kernel/events/uprobes.c | 107 +++- 3 files changed, 77 insertions(+), 56 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
