Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-12 Thread Nicolin Chen
On Mon, Dec 04, 2017 at 12:46:33PM -0800, Nicolin Chen wrote: > Nicolin Chen (10): > ASoC: fsl_ssi: Remove unused struct device > ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi > ASoC: fsl_ssi: Cache pdev->dev pointer > ASoC: fsl_ssi: Refine all comments > ASoC: fsl_ssi: Rename

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-12 Thread Nicolin Chen
On Mon, Dec 04, 2017 at 12:46:33PM -0800, Nicolin Chen wrote: > Nicolin Chen (10): > ASoC: fsl_ssi: Remove unused struct device > ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi > ASoC: fsl_ssi: Cache pdev->dev pointer > ASoC: fsl_ssi: Refine all comments > ASoC: fsl_ssi: Rename

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Nicolin Chen
On Wed, Dec 06, 2017 at 02:01:32AM +0100, Maciej S. Szmigiero wrote: > >>> ==Verification== > >>> Theoretically, it only needs code review, build and sanity tests. I > >>> have done build and sanity tests on an i.MX 6 platform by building > >>> using imx_v6_v7_defconfig and testing with I2S

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Nicolin Chen
On Wed, Dec 06, 2017 at 02:01:32AM +0100, Maciej S. Szmigiero wrote: > >>> ==Verification== > >>> Theoretically, it only needs code review, build and sanity tests. I > >>> have done build and sanity tests on an i.MX 6 platform by building > >>> using imx_v6_v7_defconfig and testing with I2S

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Maciej S. Szmigiero
On 05.12.2017 20:33, Nicolin Chen wrote: > On Tue, Dec 05, 2017 at 02:01:17PM +0100, Maciej S. Szmigiero wrote: > >>> ==Verification== >>> Theoretically, it only needs code review, build and sanity tests. I >>> have done build and sanity tests on an i.MX 6 platform by building >>> using

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Maciej S. Szmigiero
On 05.12.2017 20:33, Nicolin Chen wrote: > On Tue, Dec 05, 2017 at 02:01:17PM +0100, Maciej S. Szmigiero wrote: > >>> ==Verification== >>> Theoretically, it only needs code review, build and sanity tests. I >>> have done build and sanity tests on an i.MX 6 platform by building >>> using

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Nicolin Chen
On Tue, Dec 05, 2017 at 02:01:17PM +0100, Maciej S. Szmigiero wrote: > > ==Verification== > > Theoretically, it only needs code review, build and sanity tests. I > > have done build and sanity tests on an i.MX 6 platform by building > > using imx_v6_v7_defconfig and testing with I2S slave/master

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Nicolin Chen
On Tue, Dec 05, 2017 at 02:01:17PM +0100, Maciej S. Szmigiero wrote: > > ==Verification== > > Theoretically, it only needs code review, build and sanity tests. I > > have done build and sanity tests on an i.MX 6 platform by building > > using imx_v6_v7_defconfig and testing with I2S slave/master

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Maciej S. Szmigiero
Hi Nicolin, On 04.12.2017 21:46, Nicolin Chen wrote: > ==Background== > The fsl_ssi driver was designed for PPC originally and then it has > been updated to support different modes for i.MX Series, including > SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different > contributors for

Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-05 Thread Maciej S. Szmigiero
Hi Nicolin, On 04.12.2017 21:46, Nicolin Chen wrote: > ==Background== > The fsl_ssi driver was designed for PPC originally and then it has > been updated to support different modes for i.MX Series, including > SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different > contributors for

[PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-04 Thread Nicolin Chen
==Background== The fsl_ssi driver was designed for PPC originally and then it has been updated to support different modes for i.MX Series, including SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different contributors for different use cases in different coding styles. Additionally, in

[PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-04 Thread Nicolin Chen
==Background== The fsl_ssi driver was designed for PPC originally and then it has been updated to support different modes for i.MX Series, including SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different contributors for different use cases in different coding styles. Additionally, in