Re: [PATCH 00/10] steal tasks to improve CPU utilization

2019-01-04 Thread Shijith Thotton
On 22-Oct-18 8:40 PM, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-11-05 Thread Steven Sistare
On 11/2/2018 7:39 PM, Subhra Mazumdar wrote: > On 10/22/18 7:59 AM, Steve Sistare wrote: >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a bitmap of overloaded CPUs to

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-11-05 Thread Steven Sistare
On 11/2/2018 7:39 PM, Subhra Mazumdar wrote: > On 10/22/18 7:59 AM, Steve Sistare wrote: >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a bitmap of overloaded CPUs to

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-11-02 Thread Subhra Mazumdar
On 10/22/18 7:59 AM, Steve Sistare wrote: When a CPU has no more CFS tasks to run, and idle_balance() fails to find a task, then attempt to steal a task from an overloaded CPU in the same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently identify candidates. To minimize search

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-11-02 Thread Subhra Mazumdar
On 10/22/18 7:59 AM, Steve Sistare wrote: When a CPU has no more CFS tasks to run, and idle_balance() fails to find a task, then attempt to steal a task from an overloaded CPU in the same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently identify candidates. To minimize search

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-11-01 Thread Steven Sistare
On 10/22/2018 10:59 AM, Steve Sistare wrote: > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-11-01 Thread Steven Sistare
On 10/22/2018 10:59 AM, Steve Sistare wrote: > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify candidates. To minimize

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-31 Thread Steven Sistare
Thanks very much to everyone who has commented on my patch series. Here are the issues to be addressed in V2 of the series, and the person that suggested it, or raised the issue that led to it. Changes for V2: * Remove stray patch 10 hunk from patch 5 (Valentin) * Fix "warning: label out

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-31 Thread Steven Sistare
Thanks very much to everyone who has commented on my patch series. Here are the issues to be addressed in V2 of the series, and the person that suggested it, or raised the issue that led to it. Changes for V2: * Remove stray patch 10 hunk from patch 5 (Valentin) * Fix "warning: label out

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 8:43 AM, Vincent Guittot wrote: > On Thu, 25 Oct 2018 at 13:29, Steven Sistare > wrote: >> >> On 10/25/2018 3:50 AM, Vincent Guittot wrote: >>> Hi Steve, >>> >>> On Mon, 22 Oct 2018 at 17:10, Steve Sistare >>> wrote: When a CPU has no more CFS tasks to run, and

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 8:43 AM, Vincent Guittot wrote: > On Thu, 25 Oct 2018 at 13:29, Steven Sistare > wrote: >> >> On 10/25/2018 3:50 AM, Vincent Guittot wrote: >>> Hi Steve, >>> >>> On Mon, 22 Oct 2018 at 17:10, Steve Sistare >>> wrote: When a CPU has no more CFS tasks to run, and

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
On Thu, 25 Oct 2018 at 13:29, Steven Sistare wrote: > > On 10/25/2018 3:50 AM, Vincent Guittot wrote: > > Hi Steve, > > > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare > > wrote: > >> > >> When a CPU has no more CFS tasks to run, and idle_balance() fails to > >> find a task, then attempt to

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
On Thu, 25 Oct 2018 at 13:29, Steven Sistare wrote: > > On 10/25/2018 3:50 AM, Vincent Guittot wrote: > > Hi Steve, > > > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare > > wrote: > >> > >> When a CPU has no more CFS tasks to run, and idle_balance() fails to > >> find a task, then attempt to

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 7:31 AM, Valentin Schneider wrote: > > On 24/10/2018 20:27, Steven Sistare wrote: > [...] >> Hi Valentin, >> >> Asymmetric systems could maintain a separate bitmap for misfits; set a bit >> when a CPU goes on CPU, clear it going off. When a fast CPU goes new idle, >> it would

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 7:31 AM, Valentin Schneider wrote: > > On 24/10/2018 20:27, Steven Sistare wrote: > [...] >> Hi Valentin, >> >> Asymmetric systems could maintain a separate bitmap for misfits; set a bit >> when a CPU goes on CPU, clear it going off. When a fast CPU goes new idle, >> it would

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Valentin Schneider
On 24/10/2018 20:27, Steven Sistare wrote: [...] > Hi Valentin, > > Asymmetric systems could maintain a separate bitmap for misfits; set a bit > when a CPU goes on CPU, clear it going off. When a fast CPU goes new idle, > it would first search the misfits mask, then search cfs_overload_cpus.

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Valentin Schneider
On 24/10/2018 20:27, Steven Sistare wrote: [...] > Hi Valentin, > > Asymmetric systems could maintain a separate bitmap for misfits; set a bit > when a CPU goes on CPU, clear it going off. When a fast CPU goes new idle, > it would first search the misfits mask, then search cfs_overload_cpus.

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 3:50 AM, Vincent Guittot wrote: > Hi Steve, > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare wrote: >> >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 3:50 AM, Vincent Guittot wrote: > Hi Steve, > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare wrote: >> >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
Hi Steve, On Mon, 22 Oct 2018 at 17:10, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
Hi Steve, On Mon, 22 Oct 2018 at 17:10, Steve Sistare wrote: > > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-24 Thread Steven Sistare
On 10/24/2018 11:34 AM, Valentin Schneider wrote: > Hi, > > On 22/10/2018 20:07, Steven Sistare wrote: >> On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > [...] >> >> We could delete idle_balance() and use stealing exclusively for handling >> new idle. For each sd level, stealing would look for an

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-24 Thread Steven Sistare
On 10/24/2018 11:34 AM, Valentin Schneider wrote: > Hi, > > On 22/10/2018 20:07, Steven Sistare wrote: >> On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > [...] >> >> We could delete idle_balance() and use stealing exclusively for handling >> new idle. For each sd level, stealing would look for an

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-24 Thread Valentin Schneider
Hi, On 22/10/2018 20:07, Steven Sistare wrote: > On 10/22/2018 1:04 PM, Peter Zijlstra wrote: [...] > > We could delete idle_balance() and use stealing exclusively for handling > new idle. For each sd level, stealing would look for an overloaded CPU > in the overloaded bitmap(s) that overlap

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-24 Thread Valentin Schneider
Hi, On 22/10/2018 20:07, Steven Sistare wrote: > On 10/22/2018 1:04 PM, Peter Zijlstra wrote: [...] > > We could delete idle_balance() and use stealing exclusively for handling > new idle. For each sd level, stealing would look for an overloaded CPU > in the overloaded bitmap(s) that overlap

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Peter Zijlstra
On Mon, Oct 22, 2018 at 03:07:10PM -0400, Steven Sistare wrote: > On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > > On Mon, Oct 22, 2018 at 07:59:31AM -0700, Steve Sistare wrote: > >> When a CPU has no more CFS tasks to run, and idle_balance() fails to > >> find a task, then attempt to steal a task

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Peter Zijlstra
On Mon, Oct 22, 2018 at 03:07:10PM -0400, Steven Sistare wrote: > On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > > On Mon, Oct 22, 2018 at 07:59:31AM -0700, Steve Sistare wrote: > >> When a CPU has no more CFS tasks to run, and idle_balance() fails to > >> find a task, then attempt to steal a task

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Steven Sistare
On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > On Mon, Oct 22, 2018 at 07:59:31AM -0700, Steve Sistare wrote: >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a bitmap of

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Steven Sistare
On 10/22/2018 1:04 PM, Peter Zijlstra wrote: > On Mon, Oct 22, 2018 at 07:59:31AM -0700, Steve Sistare wrote: >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a bitmap of

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Peter Zijlstra
On Mon, Oct 22, 2018 at 07:59:31AM -0700, Steve Sistare wrote: > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Peter Zijlstra
On Mon, Oct 22, 2018 at 07:59:31AM -0700, Steve Sistare wrote: > When a CPU has no more CFS tasks to run, and idle_balance() fails to > find a task, then attempt to steal a task from an overloaded CPU in the > same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently > identify

[PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Steve Sistare
When a CPU has no more CFS tasks to run, and idle_balance() fails to find a task, then attempt to steal a task from an overloaded CPU in the same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently identify candidates. To minimize search time, steal the first migratable task that is

[PATCH 00/10] steal tasks to improve CPU utilization

2018-10-22 Thread Steve Sistare
When a CPU has no more CFS tasks to run, and idle_balance() fails to find a task, then attempt to steal a task from an overloaded CPU in the same LLC. Maintain and use a bitmap of overloaded CPUs to efficiently identify candidates. To minimize search time, steal the first migratable task that is