Re: [PATCH 00/17] clean up readlinks

2016-09-28 Thread Miklos Szeredi
On Wed, Sep 28, 2016 at 4:17 AM, Al Viro wrote: > Symlink traversal is a much hotter path than readlink() would ever be. > What's more, we do have jumps on normal symlink traversal - after all, > absolute symlinks are exactly that; it's "jump to root, then traverse > the

Re: [PATCH 00/17] clean up readlinks

2016-09-27 Thread Al Viro
On Tue, Sep 27, 2016 at 11:38:33AM +0200, Miklos Szeredi wrote: > > I have no problem with "let's get rid of generic_readlink" - not > > that > > it bought us much, but sure, if you want to have decision made based upon > > the combination of flags, let's do it. Just make NULL ->readlink

Re: [PATCH 00/17] clean up readlinks

2016-09-27 Thread Miklos Szeredi
On Tue, Sep 27, 2016 at 5:10 AM, Al Viro wrote: > On Mon, Sep 12, 2016 at 09:29:02PM +0200, Miklos Szeredi wrote: >> The first patch is actually a bug fix, but I put it into this bunch for >> simplicity... >> >> The rest are really cleanups as well as minor bugfixes that

Re: [PATCH 00/17] clean up readlinks

2016-09-26 Thread Al Viro
On Mon, Sep 12, 2016 at 09:29:02PM +0200, Miklos Szeredi wrote: > The first patch is actually a bug fix, but I put it into this bunch for > simplicity... > > The rest are really cleanups as well as minor bugfixes that are byproducts > of the cleanups. > > This series builds on the fact that

[PATCH 00/17] clean up readlinks

2016-09-12 Thread Miklos Szeredi
The first patch is actually a bug fix, but I put it into this bunch for simplicity... The rest are really cleanups as well as minor bugfixes that are byproducts of the cleanups. This series builds on the fact that i_op.readlink is already set to generic_readlink() in 43/50 of the cases. And of