Re: [PATCH 00/22] Remove deprecated create_workqueue instances

[Doug Ledford]

On 8/15/2016 1:57 PM, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
> 
> Bhaktipriya Shridhar (22):
>   IB/sa : Remove deprecated create_singlethread_workqueue
>   IB/mad: Remove deprecated create_singlethread_workqueue
>   IB/multicast: Remove deprecated create_singlethread_workqueue
>   IB/ucma: Remove deprecated create_singlethread_workqueue
>   IB/cma: Remove deprecated create_singlethread_workqueue
>   IB/addr: Remove deprecated create_singlethread_workqueue
>   IB/iwcm: Remove deprecated create_singlethread_workqueue
>   iw_cxgb3: Remove deprecated create_singlethread_workqueue
>   IB/qib: Remove deprecated create_singlethread_workqueue
>   iw_cxgb4: Remove deprecated create_singlethread_workqueue
>   IB/mthca: Remove deprecated create_singlethread_workqueue
>   i40iw_main: Remove deprecated create_singlethread_workqueue
>   i40iw_cm: Remove deprecated create_singlethread_workqueue
>   IB/mlx5: Remove deprecated create_singlethread_workqueue
>   IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
>   IB/mlx4: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
>   IB/nes: Remove deprecated create_singlethread_workqueue
>   IB/ipoib: Remove deprecated create_singlethread_workqueue
>   IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
> 
>  drivers/infiniband/core/addr.c | 2 +-
>  drivers/infiniband/core/cma.c  | 2 +-
>  drivers/infiniband/core/iwcm.c | 2 +-
>  drivers/infiniband/core/mad.c  | 2 +-
>  drivers/infiniband/core/multicast.c| 2 +-
>  drivers/infiniband/core/sa_query.c | 2 +-
>  drivers/infiniband/core/ucma.c | 3 ++-
>  drivers/infiniband/hw/cxgb3/iwch_cm.c  | 2 +-
>  drivers/infiniband/hw/cxgb4/cm.c   | 2 +-
>  drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +--
>  drivers/infiniband/hw/i40iw/i40iw_main.c   | 2 +-
>  drivers/infiniband/hw/mlx4/alias_GUID.c| 2 +-
>  drivers/infiniband/hw/mlx4/mad.c   | 4 ++--
>  drivers/infiniband/hw/mlx4/main.c  | 2 +-
>  drivers/infiniband/hw/mlx4/mcg.c   | 4 ++--
>  drivers/infiniband/hw/mlx5/mr.c| 2 +-
>  drivers/infiniband/hw/mlx5/odp.c   | 4 ++--
>  drivers/infiniband/hw/mthca/mthca_catas.c  | 2 +-
>  drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
>  drivers/infiniband/hw/qib/qib_init.c   | 4 ++--
>  drivers/infiniband/ulp/ipoib/ipoib_main.c  | 3 ++-
>  drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
>  22 files changed, 33 insertions(+), 28 deletions(-)
> 
> --
> 2.1.4
> 

The commit message of patch 20/22 was not matching what you actually
did.  I fixed that up (the commit message, the patch was right), then
series applied.

-- 
Doug Ledford 
GPG Key ID: 0E572FDD



signature.asc
Description: OpenPGP digital signature

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

[Doug Ledford]

On 8/15/2016 1:57 PM, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
> 
> Bhaktipriya Shridhar (22):
>   IB/sa : Remove deprecated create_singlethread_workqueue
>   IB/mad: Remove deprecated create_singlethread_workqueue
>   IB/multicast: Remove deprecated create_singlethread_workqueue
>   IB/ucma: Remove deprecated create_singlethread_workqueue
>   IB/cma: Remove deprecated create_singlethread_workqueue
>   IB/addr: Remove deprecated create_singlethread_workqueue
>   IB/iwcm: Remove deprecated create_singlethread_workqueue
>   iw_cxgb3: Remove deprecated create_singlethread_workqueue
>   IB/qib: Remove deprecated create_singlethread_workqueue
>   iw_cxgb4: Remove deprecated create_singlethread_workqueue
>   IB/mthca: Remove deprecated create_singlethread_workqueue
>   i40iw_main: Remove deprecated create_singlethread_workqueue
>   i40iw_cm: Remove deprecated create_singlethread_workqueue
>   IB/mlx5: Remove deprecated create_singlethread_workqueue
>   IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
>   IB/mlx4: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
>   IB/nes: Remove deprecated create_singlethread_workqueue
>   IB/ipoib: Remove deprecated create_singlethread_workqueue
>   IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
> 
>  drivers/infiniband/core/addr.c | 2 +-
>  drivers/infiniband/core/cma.c  | 2 +-
>  drivers/infiniband/core/iwcm.c | 2 +-
>  drivers/infiniband/core/mad.c  | 2 +-
>  drivers/infiniband/core/multicast.c| 2 +-
>  drivers/infiniband/core/sa_query.c | 2 +-
>  drivers/infiniband/core/ucma.c | 3 ++-
>  drivers/infiniband/hw/cxgb3/iwch_cm.c  | 2 +-
>  drivers/infiniband/hw/cxgb4/cm.c   | 2 +-
>  drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +--
>  drivers/infiniband/hw/i40iw/i40iw_main.c   | 2 +-
>  drivers/infiniband/hw/mlx4/alias_GUID.c| 2 +-
>  drivers/infiniband/hw/mlx4/mad.c   | 4 ++--
>  drivers/infiniband/hw/mlx4/main.c  | 2 +-
>  drivers/infiniband/hw/mlx4/mcg.c   | 4 ++--
>  drivers/infiniband/hw/mlx5/mr.c| 2 +-
>  drivers/infiniband/hw/mlx5/odp.c   | 4 ++--
>  drivers/infiniband/hw/mthca/mthca_catas.c  | 2 +-
>  drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
>  drivers/infiniband/hw/qib/qib_init.c   | 4 ++--
>  drivers/infiniband/ulp/ipoib/ipoib_main.c  | 3 ++-
>  drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
>  22 files changed, 33 insertions(+), 28 deletions(-)
> 
> --
> 2.1.4
> 

The commit message of patch 20/22 was not matching what you actually
did.  I fixed that up (the commit message, the patch was right), then
series applied.

-- 
Doug Ledford 
GPG Key ID: 0E572FDD



signature.asc
Description: OpenPGP digital signature

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

[Leon Romanovsky]

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
> 
> Bhaktipriya Shridhar (22):
>   IB/sa : Remove deprecated create_singlethread_workqueue
>   IB/mad: Remove deprecated create_singlethread_workqueue
>   IB/multicast: Remove deprecated create_singlethread_workqueue
>   IB/ucma: Remove deprecated create_singlethread_workqueue
>   IB/cma: Remove deprecated create_singlethread_workqueue
>   IB/addr: Remove deprecated create_singlethread_workqueue
>   IB/iwcm: Remove deprecated create_singlethread_workqueue
>   iw_cxgb3: Remove deprecated create_singlethread_workqueue
>   IB/qib: Remove deprecated create_singlethread_workqueue
>   iw_cxgb4: Remove deprecated create_singlethread_workqueue
>   IB/mthca: Remove deprecated create_singlethread_workqueue
>   i40iw_main: Remove deprecated create_singlethread_workqueue
>   i40iw_cm: Remove deprecated create_singlethread_workqueue
>   IB/mlx5: Remove deprecated create_singlethread_workqueue
>   IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
>   IB/mlx4: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
>   IB/nes: Remove deprecated create_singlethread_workqueue
>   IB/ipoib: Remove deprecated create_singlethread_workqueue
>   IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

Thank you for doing it in one patch set, it is much easier to review.


signature.asc
Description: PGP signature

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

[Leon Romanovsky]

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
> 
> Bhaktipriya Shridhar (22):
>   IB/sa : Remove deprecated create_singlethread_workqueue
>   IB/mad: Remove deprecated create_singlethread_workqueue
>   IB/multicast: Remove deprecated create_singlethread_workqueue
>   IB/ucma: Remove deprecated create_singlethread_workqueue
>   IB/cma: Remove deprecated create_singlethread_workqueue
>   IB/addr: Remove deprecated create_singlethread_workqueue
>   IB/iwcm: Remove deprecated create_singlethread_workqueue
>   iw_cxgb3: Remove deprecated create_singlethread_workqueue
>   IB/qib: Remove deprecated create_singlethread_workqueue
>   iw_cxgb4: Remove deprecated create_singlethread_workqueue
>   IB/mthca: Remove deprecated create_singlethread_workqueue
>   i40iw_main: Remove deprecated create_singlethread_workqueue
>   i40iw_cm: Remove deprecated create_singlethread_workqueue
>   IB/mlx5: Remove deprecated create_singlethread_workqueue
>   IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
>   IB/mlx4: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
>   IB/nes: Remove deprecated create_singlethread_workqueue
>   IB/ipoib: Remove deprecated create_singlethread_workqueue
>   IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
>   IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

Thank you for doing it in one patch set, it is much easier to review.


signature.asc
Description: PGP signature

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

[Tejun Heo]

Hello,

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.

Patches generally look good to me.  The only thing is that there seem
to be several patches where ordering doesn't seem necessary, at least
judging from the patch descriptions.  It'd be great to clarify those.

Thanks.

-- 
tejun

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

[Tejun Heo]

Hello,

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.

Patches generally look good to me.  The only thing is that there seem
to be several patches where ordering doesn't seem necessary, at least
judging from the patch descriptions.  It'd be great to clarify those.

Thanks.

-- 
tejun

[PATCH 00/22] Remove deprecated create_workqueue instances

[Bhaktipriya Shridhar]

This patch set removes the instances of deprecated
create_singlethread_workqueue (scheduled for removal) in
drivers/infiniband by making the appropriate conversions.

Bhaktipriya Shridhar (22):
  IB/sa : Remove deprecated create_singlethread_workqueue
  IB/mad: Remove deprecated create_singlethread_workqueue
  IB/multicast: Remove deprecated create_singlethread_workqueue
  IB/ucma: Remove deprecated create_singlethread_workqueue
  IB/cma: Remove deprecated create_singlethread_workqueue
  IB/addr: Remove deprecated create_singlethread_workqueue
  IB/iwcm: Remove deprecated create_singlethread_workqueue
  iw_cxgb3: Remove deprecated create_singlethread_workqueue
  IB/qib: Remove deprecated create_singlethread_workqueue
  iw_cxgb4: Remove deprecated create_singlethread_workqueue
  IB/mthca: Remove deprecated create_singlethread_workqueue
  i40iw_main: Remove deprecated create_singlethread_workqueue
  i40iw_cm: Remove deprecated create_singlethread_workqueue
  IB/mlx5: Remove deprecated create_singlethread_workqueue
  IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
  IB/mlx4: Remove deprecated create_singlethread_workqueue
  IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
  IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
  IB/nes: Remove deprecated create_singlethread_workqueue
  IB/ipoib: Remove deprecated create_singlethread_workqueue
  IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
  IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

 drivers/infiniband/core/addr.c | 2 +-
 drivers/infiniband/core/cma.c  | 2 +-
 drivers/infiniband/core/iwcm.c | 2 +-
 drivers/infiniband/core/mad.c  | 2 +-
 drivers/infiniband/core/multicast.c| 2 +-
 drivers/infiniband/core/sa_query.c | 2 +-
 drivers/infiniband/core/ucma.c | 3 ++-
 drivers/infiniband/hw/cxgb3/iwch_cm.c  | 2 +-
 drivers/infiniband/hw/cxgb4/cm.c   | 2 +-
 drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +--
 drivers/infiniband/hw/i40iw/i40iw_main.c   | 2 +-
 drivers/infiniband/hw/mlx4/alias_GUID.c| 2 +-
 drivers/infiniband/hw/mlx4/mad.c   | 4 ++--
 drivers/infiniband/hw/mlx4/main.c  | 2 +-
 drivers/infiniband/hw/mlx4/mcg.c   | 4 ++--
 drivers/infiniband/hw/mlx5/mr.c| 2 +-
 drivers/infiniband/hw/mlx5/odp.c   | 4 ++--
 drivers/infiniband/hw/mthca/mthca_catas.c  | 2 +-
 drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
 drivers/infiniband/hw/qib/qib_init.c   | 4 ++--
 drivers/infiniband/ulp/ipoib/ipoib_main.c  | 3 ++-
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
 22 files changed, 33 insertions(+), 28 deletions(-)

--
2.1.4

[PATCH 00/22] Remove deprecated create_workqueue instances

[Bhaktipriya Shridhar]

This patch set removes the instances of deprecated
create_singlethread_workqueue (scheduled for removal) in
drivers/infiniband by making the appropriate conversions.

Bhaktipriya Shridhar (22):
  IB/sa : Remove deprecated create_singlethread_workqueue
  IB/mad: Remove deprecated create_singlethread_workqueue
  IB/multicast: Remove deprecated create_singlethread_workqueue
  IB/ucma: Remove deprecated create_singlethread_workqueue
  IB/cma: Remove deprecated create_singlethread_workqueue
  IB/addr: Remove deprecated create_singlethread_workqueue
  IB/iwcm: Remove deprecated create_singlethread_workqueue
  iw_cxgb3: Remove deprecated create_singlethread_workqueue
  IB/qib: Remove deprecated create_singlethread_workqueue
  iw_cxgb4: Remove deprecated create_singlethread_workqueue
  IB/mthca: Remove deprecated create_singlethread_workqueue
  i40iw_main: Remove deprecated create_singlethread_workqueue
  i40iw_cm: Remove deprecated create_singlethread_workqueue
  IB/mlx5: Remove deprecated create_singlethread_workqueue
  IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
  IB/mlx4: Remove deprecated create_singlethread_workqueue
  IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
  IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
  IB/nes: Remove deprecated create_singlethread_workqueue
  IB/ipoib: Remove deprecated create_singlethread_workqueue
  IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
  IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

 drivers/infiniband/core/addr.c | 2 +-
 drivers/infiniband/core/cma.c  | 2 +-
 drivers/infiniband/core/iwcm.c | 2 +-
 drivers/infiniband/core/mad.c  | 2 +-
 drivers/infiniband/core/multicast.c| 2 +-
 drivers/infiniband/core/sa_query.c | 2 +-
 drivers/infiniband/core/ucma.c | 3 ++-
 drivers/infiniband/hw/cxgb3/iwch_cm.c  | 2 +-
 drivers/infiniband/hw/cxgb4/cm.c   | 2 +-
 drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +--
 drivers/infiniband/hw/i40iw/i40iw_main.c   | 2 +-
 drivers/infiniband/hw/mlx4/alias_GUID.c| 2 +-
 drivers/infiniband/hw/mlx4/mad.c   | 4 ++--
 drivers/infiniband/hw/mlx4/main.c  | 2 +-
 drivers/infiniband/hw/mlx4/mcg.c   | 4 ++--
 drivers/infiniband/hw/mlx5/mr.c| 2 +-
 drivers/infiniband/hw/mlx5/odp.c   | 4 ++--
 drivers/infiniband/hw/mthca/mthca_catas.c  | 2 +-
 drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
 drivers/infiniband/hw/qib/qib_init.c   | 4 ++--
 drivers/infiniband/ulp/ipoib/ipoib_main.c  | 3 ++-
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
 22 files changed, 33 insertions(+), 28 deletions(-)

--
2.1.4