Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Greg, On Sun, Dec 13, 2015 at 7:43 AM, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2015 at 10:09:24AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 19, 2015 at 7:38 PM, Geert Uytterhoeven >> wrote: >> > This patch series adds support to the Renesas SCI serial driver for >> > - the

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Greg, On Sun, Dec 13, 2015 at 7:43 AM, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2015 at 10:09:24AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 19, 2015 at 7:38 PM, Geert Uytterhoeven >> wrote: >> > This patch series adds support to

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Fri, Nov 20, 2015 at 10:09:24AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 19, 2015 at 7:38 PM, Geert Uytterhoeven > wrote: > > This patch series adds support to the Renesas SCI serial driver for > > - the optional external clock on (H)SCI(F) and some SCIFA, where this > > pin can

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Fri, Nov 20, 2015 at 10:09:24AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 19, 2015 at 7:38 PM, Geert Uytterhoeven > wrote: > > This patch series adds support to the Renesas SCI serial driver for > > - the optional external clock on (H)SCI(F) and some SCIFA,

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Thu, Nov 19, 2015 at 07:38:39PM +0100, Geert Uytterhoeven wrote: > Hi, > > This patch series adds support to the Renesas SCI serial driver for > - the optional external clock on (H)SCI(F) and some SCIFA, where this > pin can serve as a clock input, > - the optional clock sources

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Thu, Nov 19, 2015 at 07:38:39PM +0100, Geert Uytterhoeven wrote: > Hi, > > This patch series adds support to the Renesas SCI serial driver for > - the optional external clock on (H)SCI(F) and some SCIFA, where this > pin can serve as a clock input, > - the optional clock sources

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Fri, Nov 20, 2015 at 3:50 PM, Laurent Pinchart wrote: > On Friday 20 November 2015 10:07:31 Geert Uytterhoeven wrote: >> On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: >> > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: >> >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Geert, On Friday 20 November 2015 10:07:31 Geert Uytterhoeven wrote: > On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: > > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: > >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > >>> Could you briefly explain (and

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Thu, Nov 19, 2015 at 7:38 PM, Geert Uytterhoeven wrote: > This patch series adds support to the Renesas SCI serial driver for > - the optional external clock on (H)SCI(F) and some SCIFA, where this > pin can serve as a clock input, > - the optional clock sources for the Baud Rate

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Laurent, On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: >> > Could you briefly explain (and even better in a source code comment) how >> > you handle baud

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Geert, On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: > On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > > For patches 3-6, 13, 15-16 and 22 and 24, > > > > Reviewed-by: Laurent Pinchart > > Many thanks for your review comments! You're welcome. > > I'm not sure

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Laurent, On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > For patches 3-6, 13, 15-16 and 22 and 24, > > Reviewed-by: Laurent Pinchart Many thanks for your review comments! > I'm not sure I'd bother with patch 25/25, but I'm not against merging it > either. I'd be surprised if

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Geert, On Friday 20 November 2015 10:07:31 Geert Uytterhoeven wrote: > On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: > > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: > >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > >>> Could you briefly explain (and

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Fri, Nov 20, 2015 at 3:50 PM, Laurent Pinchart wrote: > On Friday 20 November 2015 10:07:31 Geert Uytterhoeven wrote: >> On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: >> > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: >> >> On Thu,

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Geert, On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: > On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > > For patches 3-6, 13, 15-16 and 22 and 24, > > > > Reviewed-by: Laurent Pinchart > > Many thanks for your review

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Laurent, On Fri, Nov 20, 2015 at 9:58 AM, Laurent Pinchart wrote: > On Friday 20 November 2015 09:22:16 Geert Uytterhoeven wrote: >> On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: >> > Could you briefly explain (and even better in a source code

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

On Thu, Nov 19, 2015 at 7:38 PM, Geert Uytterhoeven wrote: > This patch series adds support to the Renesas SCI serial driver for > - the optional external clock on (H)SCI(F) and some SCIFA, where this > pin can serve as a clock input, > - the optional clock

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Laurent, On Thu, Nov 19, 2015 at 10:08 PM, Laurent Pinchart wrote: > For patches 3-6, 13, 15-16 and 22 and 24, > > Reviewed-by: Laurent Pinchart Many thanks for your review comments! > I'm not sure I'd bother

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Geert, Thank you for the patches. For patches 3-6, 13, 15-16 and 22 and 24, Reviewed-by: Laurent Pinchart I'm not sure I'd bother with patch 25/25, but I'm not against merging it either. I'd be surprised if the serial driver still worked at all on SH :-) On Thursday 19 November 2015

[PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi, This patch series adds support to the Renesas SCI serial driver for - the optional external clock on (H)SCI(F) and some SCIFA, where this pin can serve as a clock input, - the optional clock sources for the Baud Rate Generator for External Clock (BRG), as found on some

[PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi, This patch series adds support to the Renesas SCI serial driver for - the optional external clock on (H)SCI(F) and some SCIFA, where this pin can serve as a clock input, - the optional clock sources for the Baud Rate Generator for External Clock (BRG), as found on some

Re: [PATCH 00/25] serial: sh-sci: Add external clock and BRG Support

Hi Geert, Thank you for the patches. For patches 3-6, 13, 15-16 and 22 and 24, Reviewed-by: Laurent Pinchart I'm not sure I'd bother with patch 25/25, but I'm not against merging it either. I'd be surprised if the serial driver still worked at all