Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-28 Thread Theodore Ts'o
On Sun, Nov 27, 2016 at 05:27:58PM -0800, Eric Biggers wrote: > > Shouldn't the branch be rebased to remove the CONFIG_VMAP_STACK fixes which > are > already in Linus' tree? > > fscrypto: don't use on-stack buffer for key derivation > fscrypto: don't use on-stack buffer for filename

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-28 Thread Theodore Ts'o
On Sun, Nov 27, 2016 at 05:27:58PM -0800, Eric Biggers wrote: > > Shouldn't the branch be rebased to remove the CONFIG_VMAP_STACK fixes which > are > already in Linus' tree? > > fscrypto: don't use on-stack buffer for key derivation > fscrypto: don't use on-stack buffer for filename

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Eric Biggers
On Sun, Nov 27, 2016 at 11:21:56PM +0100, Richard Weinberger wrote: > Ted, > > On 27.11.2016 18:52, Theodore Ts'o wrote: > > On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote: > >> > >> Do you want us to address Eric's review comments on top of the fscrypt > >> branch or shall we

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Eric Biggers
On Sun, Nov 27, 2016 at 11:21:56PM +0100, Richard Weinberger wrote: > Ted, > > On 27.11.2016 18:52, Theodore Ts'o wrote: > > On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote: > >> > >> Do you want us to address Eric's review comments on top of the fscrypt > >> branch or shall we

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Theodore Ts'o
On Sun, Nov 27, 2016 at 11:21:56PM +0100, Richard Weinberger wrote: > > Okay. Then I'll queue UBIFS encryption for the v4.10 merge window. > Just to be sure, I base my UBIFS next tree on your fscrypt tree such that > it will build fine and Linus won't see same commits with a different sha1? Yep,

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Theodore Ts'o
On Sun, Nov 27, 2016 at 11:21:56PM +0100, Richard Weinberger wrote: > > Okay. Then I'll queue UBIFS encryption for the v4.10 merge window. > Just to be sure, I base my UBIFS next tree on your fscrypt tree such that > it will build fine and Linus won't see same commits with a different sha1? Yep,

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Richard Weinberger
Ted, On 27.11.2016 18:52, Theodore Ts'o wrote: > On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote: >> >> Do you want us to address Eric's review comments on top of the fscrypt >> branch or shall we rebase? >> I'd suggest the former. > > Yes, let's address them on top of the

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Richard Weinberger
Ted, On 27.11.2016 18:52, Theodore Ts'o wrote: > On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote: >> >> Do you want us to address Eric's review comments on top of the fscrypt >> branch or shall we rebase? >> I'd suggest the former. > > Yes, let's address them on top of the

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Theodore Ts'o
On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote: > > Do you want us to address Eric's review comments on top of the fscrypt > branch or shall we rebase? > I'd suggest the former. Yes, let's address them on top of the existing fscrypt branch. I don't consider any of his

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-27 Thread Theodore Ts'o
On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote: > > Do you want us to address Eric's review comments on top of the fscrypt > branch or shall we rebase? > I'd suggest the former. Yes, let's address them on top of the existing fscrypt branch. I don't consider any of his

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-25 Thread Richard Weinberger
Ted, On 14.11.2016 04:05, Theodore Ts'o wrote: > Richard, > > Your fscrypt patches look good. I've created an fscrypt branch on the > ext4.git tree which contains your changes as well as Eric Bigger's > recent fspatch cleanups changes. If you want to base your ubifs > changes on that branch,

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-25 Thread Richard Weinberger
Ted, On 14.11.2016 04:05, Theodore Ts'o wrote: > Richard, > > Your fscrypt patches look good. I've created an fscrypt branch on the > ext4.git tree which contains your changes as well as Eric Bigger's > recent fspatch cleanups changes. If you want to base your ubifs > changes on that branch,

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-14 Thread Richard Weinberger
Ted, On 14.11.2016 04:05, Theodore Ts'o wrote: > Richard, > > Your fscrypt patches look good. I've created an fscrypt branch on the > ext4.git tree which contains your changes as well as Eric Bigger's > recent fspatch cleanups changes. If you want to base your ubifs > changes on that branch,

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-14 Thread Richard Weinberger
Ted, On 14.11.2016 04:05, Theodore Ts'o wrote: > Richard, > > Your fscrypt patches look good. I've created an fscrypt branch on the > ext4.git tree which contains your changes as well as Eric Bigger's > recent fspatch cleanups changes. If you want to base your ubifs > changes on that branch,

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-13 Thread Theodore Ts'o
Richard, Your fscrypt patches look good. I've created an fscrypt branch on the ext4.git tree which contains your changes as well as Eric Bigger's recent fspatch cleanups changes. If you want to base your ubifs changes on that branch, that would be great. The ext4 dev branch will be including

Re: [PATCH 00/29] UBIFS File Encryption v1

2016-11-13 Thread Theodore Ts'o
Richard, Your fscrypt patches look good. I've created an fscrypt branch on the ext4.git tree which contains your changes as well as Eric Bigger's recent fspatch cleanups changes. If you want to base your ubifs changes on that branch, that would be great. The ext4 dev branch will be including

[PATCH 00/29] UBIFS File Encryption v1

2016-11-13 Thread Richard Weinberger
This patch series implements file level encryption for UBIFS. It makes use of the generic fscrypto framework as used by ext4 and f2fs. Among file contents also file names are encrypted, for more details on fscrypto please see [0] and [1]. To support encrypted files in UBIFS multiple preparations

[PATCH 00/29] UBIFS File Encryption v1

2016-11-13 Thread Richard Weinberger
This patch series implements file level encryption for UBIFS. It makes use of the generic fscrypto framework as used by ext4 and f2fs. Among file contents also file names are encrypted, for more details on fscrypto please see [0] and [1]. To support encrypted files in UBIFS multiple preparations