Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-06 Thread Jiri Olsa
On Sat, Nov 04, 2017 at 11:29:08AM +0100, Jiri Olsa wrote: SNIP > > both browser_disasm_line and disasm_line__browser lost the 'disasm' > by using the generic annotation_line struct.. so there's no need > to keep it in its name > > I'll update changelogs and resend/repush branch

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-06 Thread Jiri Olsa
On Sat, Nov 04, 2017 at 11:29:08AM +0100, Jiri Olsa wrote: SNIP > > both browser_disasm_line and disasm_line__browser lost the 'disasm' > by using the generic annotation_line struct.. so there's no need > to keep it in its name > > I'll update changelogs and resend/repush branch

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 01:59:01PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > > > hi, > > > I'm working on script profiling support and came up > > > with some generic

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 01:59:01PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu: > > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > > > hi, > > > I'm working on script profiling support and came up > > > with some generic

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-03 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > > hi, > > I'm working on script profiling support and came up > > with some generic annotation code changes, which IMO > > make the code simpler and more generic. > > > >

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-03 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 02, 2017 at 01:16:32PM +0100, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > > hi, > > I'm working on script profiling support and came up > > with some generic annotation code changes, which IMO > > make the code simpler and more generic. > > > >

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-02 Thread Jiri Olsa
On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > hi, > I'm working on script profiling support and came up > with some generic annotation code changes, which IMO > make the code simpler and more generic. > > The main idea of this patchset is to have generic > struct (annotation_line),

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-11-02 Thread Jiri Olsa
On Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa wrote: > hi, > I'm working on script profiling support and came up > with some generic annotation code changes, which IMO > make the code simpler and more generic. > > The main idea of this patchset is to have generic > struct (annotation_line),

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 11, 2017 at 09:30:05PM +0200, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 04:18:59PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > > > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 11, 2017 at 09:30:05PM +0200, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 04:18:59PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > > > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Jiri Olsa
On Wed, Oct 11, 2017 at 04:18:59PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > > > hi, >

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Jiri Olsa
On Wed, Oct 11, 2017 at 04:18:59PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > > > hi, >

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > > hi, > > > I'm working on script profiling support and came up > > > > Can you describe

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > > hi, > > > I'm working on script profiling support and came up > > > > Can you describe

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Jiri Olsa
On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > hi, > > I'm working on script profiling support and came up > > Can you describe what you mean by "script profiling" and "script > annotation"? I have

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Jiri Olsa
On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > hi, > > I'm working on script profiling support and came up > > Can you describe what you mean by "script profiling" and "script > annotation"? I have

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > hi, > I'm working on script profiling support and came up Can you describe what you mean by "script profiling" and "script annotation"? - Arnaldo > with some generic annotation code changes, which IMO > make the code simpler and

Re: [PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > hi, > I'm working on script profiling support and came up Can you describe what you mean by "script profiling" and "script annotation"? - Arnaldo > with some generic annotation code changes, which IMO > make the code simpler and

[PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Jiri Olsa
hi, I'm working on script profiling support and came up with some generic annotation code changes, which IMO make the code simpler and more generic. The main idea of this patchset is to have generic struct (annotation_line), which holds the common profile data. Having this we can easily add new

[PATCH 00/35] perf annotate: Use generic annotation line

2017-10-11 Thread Jiri Olsa
hi, I'm working on script profiling support and came up with some generic annotation code changes, which IMO make the code simpler and more generic. The main idea of this patchset is to have generic struct (annotation_line), which holds the common profile data. Having this we can easily add new